orbitWidth not getting set on initialization #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e slide width. orbitWidth never gets set with this case causing the animations to fail. I added a way to set orbitWidth no matter if the slide width is greater or not. After writing this it might just be better to set a default in the initialization but you can do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case the orbit.width() was being set to a value greater than the slide width. orbitWidth never gets set with this case causing the animations to fail. I added a way to set orbitWidth no matter if the slide width is greater or not. After writing this it might just be better to set a default in the initialization but you can do that.