Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(bug) text between mentions inside textarea getting deleted #11

Closed
alexthewilde opened this issue Jun 26, 2016 · 4 comments · Fixed by #14
Closed

(bug) text between mentions inside textarea getting deleted #11

alexthewilde opened this issue Jun 26, 2016 · 4 comments · Fixed by #14
Labels

Comments

@alexthewilde
Copy link
Contributor

There's a critical bug occurring within a textarea upon deleting a mention and then hitting enter. You can reproduce this behaviour in the Tribute Demo:

  1. Enter a mention followed by text followed by another mention:
to @Jordan Humphreys 
lorem ipsum
from @Sir Walter Riley 
  1. Remove second mention using backspace key
to @Jordan Humphreys 
lorem ipsum
  1. Hit enter: complete lorem ipsum text after first mention gets removed
to @Jordan Humphreys 
@alexthewilde alexthewilde changed the title Text between mentions inside textarea getting deleted (bug) text between mentions inside textarea getting deleted Jun 26, 2016
@mrsweaters
Copy link
Collaborator

@alexthewilde I am able to reproduce this. Thank you for reporting. It looks like the active state is not getting disabled in some scenarios. I'll see if I can track this down today.

@alexthewilde
Copy link
Contributor Author

@mrsweaters great! I'm happy to help out with testing as I really want to use tribute in production soon.

@mrsweaters
Copy link
Collaborator

@alexthewilde Please test #14 to see if it fixes your issue.

@mrsweaters mrsweaters added the bug label Jun 30, 2016
@alexthewilde
Copy link
Contributor Author

@mrsweaters that fixes it perfectly, thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants