-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appendCurrent doesnt seem to do anything #27
Comments
|
@mrsweaters Looking at the source, it looks like both |
Ah! You are correct, that should actually be specific to |
Cool, thanks for confirming! I'm currently working on a VueJS wrapper for Tribute, so due to the way data would be passed to the plugin, I can simply manually replace all the data whenever it changes, doing something like: setValues(values){
// If it has a "values" property, it's actually a collection
if( values.hasOwnProperty("values") ){
this.tribute.collection = values;
}
else {
this.tribute.collection[0].values = values;
}
} |
@syropian Yeah that should work. Thanks for working on a wrapper for VueJS! When you're done, feel free to submit a PR to add it to the repo. That would be sweet! |
Fixed in 2.0.3! |
Will do, how do you want me to go about creating a PR? Just a link in the README to the wrapper repo? |
Sure, that will be fine. |
it works but the menu still holding old data, once close it and open means its working fine, how to update forcefully? |
I'm having trouble appending/replacing the items. Here's a little JSFiddle https://jsfiddle.net/jrpar74q/
Am I missing something obvious? I tried passing
true
as a second arg to replace the items, and that didn't work either.The text was updated successfully, but these errors were encountered: