New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page jumps up when top of textarea is scrolled out of view #74

Closed

DavidBanksNZ opened this issue Aug 22, 2017 · 1 comment

DavidBanksNZ commented Aug 22, 2017

How can we reproduce this bug?

Go to the example https://zurb.github.io/tribute/example/
In the contenteditable input, enter lots of new lines and scroll the page down so that the top of the contenteditable is scrolled out of view
Start typing a mention

What did you expect to happen?

The page does not jump.

What happened instead?

The page jumps up so that the top of the contenteditable is scrolled back into view

This is caused by the following line https://github.com/zurb/tribute/blob/master/src/TributeRange.js#L43
Commenting out that line seems to fix the issue, but that may have unintended consequences in other situations.

Collaborator

mrsweaters commented Aug 23, 2017

I pushed a fix that should scroll to the top of the menu at the current cart position in the input: 5e76def

This should fix your problem.

mrsweaters closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment