Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention menu wrongly positioned in version 3.1.0 #83

Closed
ThomHurks opened this issue Oct 3, 2017 · 10 comments
Closed

Mention menu wrongly positioned in version 3.1.0 #83

ThomHurks opened this issue Oct 3, 2017 · 10 comments
Labels

Comments

@ThomHurks
Copy link
Contributor

In version 3.1.0 there's a change regarding positioning. In my case, this broke the positioning of the mentions window. I have a comment box on the right of the screen (I'm just using Bootstrap columns, nothing special) and the mentions box now appears on the left side of the screen. The tribute-container div is a child of the <body> and it has the style top: 413px; left: 449px; position: absolute; display: block; which wouldn't even be the correct positioning if it was relative to the comment box. The vertical position does seem to be correct though, it's only the horizontal positioning that is broken.

If you need more info, I'll be glad to help.

@mrsweaters
Copy link
Collaborator

@ThomHurks Thank you for reporting! Can you try to reproduce your issue in the Codepen below so I can debug it.
https://codepen.io/mrsweaters/pen/OxxdWv?editors=1010#0

@ThomHurks
Copy link
Contributor Author

ThomHurks commented Oct 3, 2017

Here you go: https://codepen.io/anon/pen/aLLMvw?editors=1010
Change the version back to 3.0.3 and you can see that it works fine.

Besides this, I noticed that on my website, the mentions window has some empty space to the left of the list elements which isn't present in the examples. I'm just using tribute as-is, with default config and no changed CSS. It seems to be caused by -webkit-padding-start: 40px; on the ul element, which is present in my Google Chrome user agent stylesheet.

Edit: ah, you're using Foundation which has padding: 0; on ul elements and then you don't get the weird empty space. So by default you're not compatible with Bootstrap. Perhaps put that CSS in your own CSS?

@mrsweaters
Copy link
Collaborator

I've pushed an update in 3.1.1 that should fix your issue. Test it out and let me know if you are still experiencing issues.

@mrsweaters mrsweaters added the bug label Oct 3, 2017
@ThomHurks
Copy link
Contributor Author

The issue with the extra padding on the left of the list elements seems fixed. Nice! However, the mentions window is still wrongly positioned on the horizontal axis. I updated the codepen to 3.1.1 and you can see it going wrong when you type @<something>

https://codepen.io/anon/pen/aLLMvw?editors=1010

@mrsweaters
Copy link
Collaborator

@ThomHurks Well shoot. One thing I'm noticing is that if I view your codepen in Chrome the position is correct, but if I view it in Firefox the positioning is off but the textarea is also rendered in a different spot. What browser are you viewing in? Also what is the intended layout of the page?

@ThomHurks
Copy link
Contributor Author

ThomHurks commented Oct 3, 2017

screen shot 2017-10-03 at 21 53 13-fullpage

I just tried a different browser, this is what it looks like in Firefox for me. The intended layout is a column of comments on the right side of the page. The textarea is where you write a comment.

@ThomHurks
Copy link
Contributor Author

codepen io_anon_pen_allmvw_editors 1010

This second screenshot is Chrome, so it's also wrong in Chrome for me.

@mrsweaters
Copy link
Collaborator

@ThomHurks Okay thanks, that helps!

@lihi-intsights
Copy link

I'm experiencing the same issue...
I guess something with the left positioning went wrong because it was fine before.

@mrsweaters
Copy link
Collaborator

@BorntraegerMarc I have rolled back the positioning changes you made until we can figure out a more universal approach. Thank you everyone for reporting and tracking this issue.

If you are still seeing positioning issue please open a separate issue! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants