Fix array index out of bounds on enter key event #773
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On keyboard enter, don't select when filteredItems is empty.
If
filteredItems
is empty array here:tribute/src/TributeEvents.js
Lines 226 to 230 in 252ec34
Then
item
will be undefined here:tribute/src/Tribute.js
Lines 473 to 479 in 252ec34
I noticed this when hitting the enter key on strings that don't match any values but coincidentally contain my trigger character, e.g.
:
in hyperlinks.