-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core categories expansion #25
Conversation
Yeah, this looks good as long as this is the approach we decide on long term. We'll have to ensure that our category ids match legacy stuff that @sesq is working on. Let's wait to merge until we have a joint plan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I concur with @joshuarubin's comments.
After speaking with Ops, it looks like we want these categories not just to be available for use in Legacy, but to be immediately available in Legacy from the get-go. This presents a challenge because 1) adding new categories in legacy would require a nontrivial amount of development time and
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
category.go
needs to be updated with the "long" description of the categories.
schema.graphql
needs to be updated with the additions as well.
category.proto
Outdated
@@ -495,4 +495,10 @@ enum Category { | |||
KIDTRAVEL_4 = 10487; | |||
UKTRAVEL_4 = 10488; | |||
TRAVEL_4 = 10489; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't yet know that these are the final names of the categories, or that their IDs match legacy.
Signed-off-by: Joshua Rubin <jrubin@zvelo.com>
@drekar @jbriggs-zvelo @zvbuhl can you take a look at these changes before I merge please? |
Signed-off-by: Joshua Rubin <jrubin@zvelo.com>
Signed-off-by: Joshua Rubin <jrubin@zvelo.com>
Signed-off-by: Joshua Rubin <jrubin@zvelo.com>
This item is still on hold pending confirmation from Ops that the new category IDs will append vs. mutate existing. I have just been informed that they will most likely be appending to the end in alignment with the code changes alredy made herein, so we shouldn't need to do any more except for add the full names as @joshuarubin mentions. |
Thanks @joshuarubin for the update to add the long names and update the api metadata. When we get the final OK from Ops confirming these IDs match theirs in legacy, this PR should be ready to merge! |
per https://www.pivotaltracker.com/story/show/155148554