Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't create a second Driver after destroying the first one #48

Closed
LiamPietralla opened this issue Nov 3, 2023 · 10 comments
Closed

Can't create a second Driver after destroying the first one #48

LiamPietralla opened this issue Nov 3, 2023 · 10 comments
Labels
fixed Should be fixed
Milestone

Comments

@LiamPietralla
Copy link

After calling driver.Destroy() I would expect to be able to create and start a new driver instance.

Instead the DriverReady event is never fired, and I can see this is because the Controller property is never set.

Not sure if something needs to be updated, so that the driver and be re-created and started again.

@marcus-j-davies
Copy link
Member

marcus-j-davies commented Nov 3, 2023

HI @LiamPietralla - Thanks for the report.

I believe this has already been fixed in V4.
The Destroy method is now a lot more destructive in v4.

See:

In essence, its because the Inited value was not cleared in Destroy

V4 is not far from being released.

@marcus-j-davies marcus-j-davies added the fixed Should be fixed label Nov 3, 2023
@marcus-j-davies marcus-j-davies added this to the 4.0 milestone Nov 3, 2023
@LiamPietralla
Copy link
Author

Awesome thanks @marcus-j-davies, will check that out later

@marcus-j-davies
Copy link
Member

I am in the middle of fine tuning V4 before release, so I wouldn't jump right in yet.

But see the following PR's to gain a view on the changes to expect.

@marcus-j-davies
Copy link
Member

Closing as fixed in v4 (soon to be released)

@marcus-j-davies
Copy link
Member

marcus-j-davies commented Nov 3, 2023

@LiamPietralla

iff you want to test V4 - pull down the code, and also pull down the Latest PSI - can be found in the V4 branch (if using the embedded runtime)

But the test PSI is only for Win64

@LiamPietralla
Copy link
Author

Yeah interesting, I am getting "The Platform Support Image version (server.psi) is lower than the requested schema version" even though I am using the library in Client mode, do I need to include the new psi in the build maybe? Will take another look tomorrow

@marcus-j-davies
Copy link
Member

marcus-j-davies commented Nov 3, 2023

Hi @LiamPietralla - no you don't need to (I need to change the message)

if in client mode, it will default to using the schema it was built against, so you will need set the schema of the server you are connecting to with the overload if connecting to a server that is lower.

@marcus-j-davies
Copy link
Member

i.e V4 is built against the latest Schema - so to connect to a lower version, set the version In the Driver Constructor

@marcus-j-davies
Copy link
Member

Message Changed:
7e5b758

@LiamPietralla
Copy link
Author

@marcus-j-davies awesome, all working now and no issues with V4! Much thanks 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Should be fixed
Projects
None yet
Development

No branches or pull requests

2 participants