-
-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HS-WX300 Switch/Dimmer Parameter 3 seems to not work correctly #4047
Comments
Honestly, this sounds like a firmware bug in the device. The driver only sets the parameter to a value and has no control over how the device behaves. |
I get your point. Although it would seem like if it was a firmware issue, there would be several issues found through a google search. The only thing I can find is two posts related to HAss. All that said, I have emailed HS Support although I don’t expect any resolution. They always blame it on HAss. |
Don't give in to their excuses then. The configuration CC is standardized and if you set a parameter with the correct value and size as stated in the manual, it simply cannot be the application's fault. That's not how Z-Wave works. All the application does is tell the device to change a config parameter. It cannot control the LEDs (or anything really) on the device itself. The device firmware is in charge of the hardware.
There's also the option to use Silabs' PC controller to set the param. That way they cannot blame it on HA 🤣 |
Thank you for your last comment. I used it in my communications with HS. I seem to have gotten some traction. From Homeseer: It looks like this is an error in documentation as parameter 3 explicitly says both that it will control the bottom LED and that it will control all of them. I will reach out to our engineers about this so we can get the doc updated and perhaps get a feature request in that allows for both options. |
This issue has not seen any recent activity and was marked as "cannot fix ❌". Feel free to reopen if the issue persists. |
I gave homeseer support this link to report their findings. |
I'm confused because I don't understand how the integration works at the code level, but if the docs are wrong, can the logic not be just swapped in the code? Also, latest docs say this - https://docs.homeseer.com/products/hs-wx300-r2-user-guide Param 3: 0 = Bottom LED ON if load is OFF ...is this still the wrong docs? Where in the codebase does this logic live? I don't mind doing a PR ... but my searching has failed me so far. Oh - this is in zwavejs not hass core. I'll search this repo next. |
Looks like their docs are still wrong unless the code has already been fixed:
The English is expressed a little differently, but I think the logic matches their (presumably incorrect) docs. @pdobrien3 Do you want to ping your contacts at HS and followup if they ever actually updated their docs? Is this project opposed to reversing the logic against what the (presumably incorrect) docs say? |
@rrauenza I'm fine updating our config files to match the actual device behavior. |
Thanks ... there is a subtle language issue in the existing templates:
Neither of these apply. The indicator is configurable to be either on or off when the load is off. This setting doesn't affect anything about the indicator and the load being on.
I don't know if this subtle distinction is only for this particular device ... or if the template is subtly wrong for other devices as well. I was going to proceed by just not referring to the template and fixing it locally in the wx300 json, unless you'd rather I just point to the inverted template. |
I see! Usually the LED indicator either follows the load state (on when on, off when off) or inverts it (on when off, off when on).
Actually let me reach out to my contact at HomeSeer - the situation has changed a bit since this issue was created. They should be able to clarify. |
Response from HomeSeer:
Seeing that the |
After re-interviewing, device information is lost:
|
Please make a driver log of the re-interview, loglevel |
This looks like a device bug. Here's the relevant log snippet with comments:
You can try excluding, factory resetting and including the device again to see if that fixes it. If not, this is a case for HomeSeer's support - they may want to see that log snippet. |
exclusion, factory reset, and inclusion fixed the issue. Thanks !!! |
Is your problem within Home Assistant (Core or Z-Wave JS Integration)?
NO, my problem is NOT within Home Assistant or the ZWave JS integration
Is your problem within ZWaveJS2MQTT?
NO, my problem is NOT within ZWaveJS2MQTT
Checklist
I have checked the troubleshooting section and my problem is not described there.
I have read the changelog and my problem was not mentioned there.
Describe the bug
What causes the bug?
Unknown
What do you observe?
Parameter 3, which controls the bottom LED operation, doesn't seem to work correctly. Here is what happens on my HS-WX300 that is setup as a switch
on when load is on
load is off == LED 1 is on
load is on == All 7 LEDs are on
on when load is off
load is off == All 7 LEDs are off
load is on == All 7 LEDs are on
What did you expect to happen?
on when load is on
load is off == LED 1 is off
load is on == LED 1 is on
on when load is off
load is off == LED 1 is on
load is on == LED 1 is off
Steps to reproduce the behavior:
Device information
Manufacturer: Homeseer
Model name: HS-WX300
Node ID in your network: 120
How are you using
node-zwave-js
?zwavejs2mqtt
Docker image (latest)zwavejs2mqtt
Docker image (dev)zwavejs2mqtt
Docker manually built (please specify branches)ioBroker.zwave2
adapter (please specify version)HomeAssistant zwave_js
integration (please specify version)pkg
node-red-contrib-zwave-js
(please specify version, double click node to find out)Which branches or versions?
version:
node-zwave-js
branch:zwavejs2mqtt
branch:zwavejs2mqtt: 6.2.0
zwave-js: 8.9.1
Did you change anything?
no
If yes, what did you change?
No response
Did this work before?
No, it never worked anywhere
If yes, where did it work?
No response
Attach Driver Logfile
2022-01-05 23:13:51.445 INFO ZWAVE-SERVER: ZwaveJS server listening on port 3000
The text was updated successfully, but these errors were encountered: