Spanish language pack

[JonL1]

No description provided.

[MrWook]

Hey, thanks for your contribution with the new language package.

I appreciate your efforts with the list but could you add the sources to the list generator like descript in the documentation
https://zxcvbn-ts.github.io/zxcvbn/guide/languages/#add-a-new-language-package.
This way everybody nows where all this data is coming from and maybe can be updated in the future if needed.

[JonL1]

Hey, thanks for your contribution with the new language package.

I appreciate your efforts with the list but could you add the sources to the list generator like descript in the documentation https://zxcvbn-ts.github.io/zxcvbn/guide/languages/#add-a-new-language-package. This way everybody nows where all this data is coming from and maybe can be updated in the future if needed.

It was all done manually as our government doesn't provide with an easy format to extract from. Is it OK if I create a repo with the raw files and add the information in the repo from where and how they were extracted?

I will correct the rest of naming errors.

[JonL1]

I found something for the generators. I'll work on that.

[MrWook]

I would be fine if you create a github repository and explain where you got them from.
But if you have something else even better :)

[JonL1]

The generators work correctly but we should add some pre-processing function to filter compound names.

Spanish (ab)uses compound first names. So instead of being named "Antonio", "Jose", "Pedro" your parents choose to call you "Antonio Manuel", "Jose Miguel" or "Pedro Antonio" to honour(keep happy) other family members.

And as this is quite popular the list of first names given by the government is plagued by such. For the purpose of the matcher this is useless as any of the compound names will already match the single name from the list.

I'm sending a new PR for the Spanish language pack including compound names and I open a new issue on how to deal with compound names.

[JonL1]

As mentioned here wikipedia data is not included in my commit.

Added an empty wikipedia.json. I hope you can process it on your side as I'm currently on mobile data. If I download the wikipedia data it will make a huge dent on my limits :)

[MrWook]

I'm sorry the wikipedia list needs to return an empty array 🙈

[JonL1]

Done.