Improve a bit gdscript syntax #3198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dustdfg
commented
Mar 20, 2024
dustdfg
commented
- Add some keywords
- Add annotations support
runtime/syntax/gdscript.yaml
Outdated
|
|
||
| # Operators | ||
| - statement: "[.:;,+*|=!\\%@]|<|>|/|-|&" | ||
|
|
||
| # Annotations | ||
| - special: "^@\\b(export|export_category|export_color_no_alpha|export_dir|export_enum|export_exp_easing|export_file|export_flags|export_flags_2d_navigation|export_flags_2d_physics|export_flags_2d_render|export_flags_3d_navigation|export_flags_3d_physics|export_flags_3d_render|export_flags_avoidance|export_global_dir|export_global_file|export_group|export_multiline|export_node_path|export_placeholder|export_range|export_subgroup|icon|onready|rpc|tool|warning_ignore)\\b+" |
There was a problem hiding this comment.
Comparing with Godot docs the @static_unload annotation seems to be missing. The first \\b and the + at the end don't do anything useful.
Suggested change
| - special: "^@\\b(export|export_category|export_color_no_alpha|export_dir|export_enum|export_exp_easing|export_file|export_flags|export_flags_2d_navigation|export_flags_2d_physics|export_flags_2d_render|export_flags_3d_navigation|export_flags_3d_physics|export_flags_3d_render|export_flags_avoidance|export_global_dir|export_global_file|export_group|export_multiline|export_node_path|export_placeholder|export_range|export_subgroup|icon|onready|rpc|tool|warning_ignore)\\b+" | |
| - special: "^@(export|export_category|export_color_no_alpha|export_dir|export_enum|export_exp_easing|export_file|export_flags|export_flags_2d_navigation|export_flags_2d_physics|export_flags_2d_render|export_flags_3d_navigation|export_flags_3d_physics|export_flags_3d_render|export_flags_avoidance|export_global_dir|export_global_file|export_group|export_multiline|export_node_path|export_placeholder|export_range|export_subgroup|icon|onready|rpc|static_unload|tool|warning_ignore)\\b" |
There was a problem hiding this comment.
+- typo@static_unload- thanks\\bIt is used everywhere. Something starts from\\band ends from it
There was a problem hiding this comment.
\b It is used everywhere. Something starts from \b and ends from it
\b means word boundary (for example \bas\b would match both "as" and "@as" but not "gas"). In this case it is not necessary because there is always a word boundary (the previous character is a non-word character @ and the following character is a letter).
* Add some keywords * Add annotations support Signed-off-by: Yevhen Babiichuk (DustDFG) <dfgdust@gmail.com> Co-authored-by: Mikko <Andriamanitra@users.noreply.github.com>
dustdfg
force-pushed
the
syntax/gscript-improve
branch
from
7d7fe32
to
370ae2f
Compare
Andriamanitra
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.