Support -bom in encoding option and detect BOM
#3396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niten94
changed the title
-bom in encoding option and detect BOM-bom in encoding option and detect BOM
|
The points below have to be improved but I do not know when I will have time, so I will convert this pull request to a draft:
|
Open and save files with BOM if value of `encoding` option ends in `-bom`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BOM is read and written in files if
encodingoption ends in-bomin this pull request. There are not much encodings supporting BOM so the encoding has to be checked when BOM is used. A new option where usage of BOM is enabled is not added because both options cannot be validated when one is set.The option is set when BOM is detected using utfbom so utfbom is added as a dependency package. Setting
encodingto UTF-32 is not supported so the option is not set when UTF-32 is detected. Bytes that are not valid UTF-8 text are modified so UTF-32 BOM is intentionally not included in buffer.BOM is not written in empty files when
transform.Writer.Closeis not called inoverwriteFileininternal/buffer/save.goso the method is called. It has been not tested if there is an unexpected bug with calling the method.Closes #3369