Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: colors v3 for tabs and buttons #801

Merged
merged 7 commits into from
Oct 17, 2023
Merged

feat: colors v3 for tabs and buttons #801

merged 7 commits into from
Oct 17, 2023

Conversation

ickisIckis
Copy link
Collaborator

@ickisIckis ickisIckis commented Oct 10, 2023

feat(components/tabs): colors version update to v3 and redesign for tabs: BREAKING CHANGE #401
fix(components/tabs): tab disable active state #703
feat(components/buttons): colors version update to v3 for buttons IDPPRIZM-1853
feat(components/swithcer): colors version to v3 update for switcher IDPPRIZM-1878
fix(components/switcher): switcher disable active state #703

fix: tab disable active state #703
@ickisIckis ickisIckis added the state:in_progress We work on this issue label Oct 10, 2023
@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Visit the preview URL for this PR (updated for commit 828b26d):

https://prizm-v3--pr801-feat-tabs-v3-colors-ruqbio07.web.app

(expires Sat, 21 Oct 2023 05:15:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 6cf3db9b3e1bf46180849c1db2e28221d0904ddf

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Visit the preview URL for this PR (updated for commit 828b26d):

https://prizm-v2--pr801-feat-tabs-v3-colors-x3yvq28j.web.app

(expires Sat, 21 Oct 2023 05:18:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: ab7e21e23e82e687a92ac5a830ac2768df6e61b5

@github-actions
Copy link

github-actions bot commented Oct 10, 2023

Visit the preview URL for this PR (updated for commit 828b26d):

https://prizm-v1--pr801-feat-tabs-v3-colors-wjrqpems.web.app

(expires Sat, 21 Oct 2023 05:18:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 3f40bac4652dbd13be483e7e4de02de469ed4b3f

@ickisIckis ickisIckis changed the title feat: colors v3 for tabs feat: colors v3 for tabs and buttons Oct 10, 2023
@ickisIckis ickisIckis added state:ready ready for release (pass tested) and removed state:in_progress We work on this issue labels Oct 12, 2023
@ickisIckis
Copy link
Collaborator Author

  1. Focus на табах смещает элемент (заменить на shadow)
  2. Выбранный таб не получает стили на фокус (либо не давать ему устанавливать фокус на себя - проскакивать на следующий, либо - починить отображение)
  3. Добавить hover на иконку у closable tab - Button/Primary-Solid-Hover
  4. Исправить поведение на hover в выпадающем списке табов

@ZurabDev
Copy link
Contributor

Просьба добавить что тут есть breacking-changes в описание

@ZurabDev
Copy link
Contributor

Просьба добавить пример с комбинацией с панелью

@ZurabDev ZurabDev added this to the 3.2.0 milestone Oct 13, 2023
@ZurabDev ZurabDev merged commit 54a0183 into main Oct 17, 2023
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:ready ready for release (pass tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants