Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] CJK search is equivalent to a whitespace #528

Closed
1 task done
BigBoyBarney opened this issue Apr 22, 2024 · 0 comments
Closed
1 task done

[Bug] CJK search is equivalent to a whitespace #528

BigBoyBarney opened this issue Apr 22, 2024 · 0 comments
Labels
priority: high High priority state: done Has been fixed or implemented type: bug Something isn't working
Milestone
v111

Comments

@BigBoyBarney
Copy link

BigBoyBarney commented Apr 22, 2024 •
edited by zyrouge
Loading

Description

CJK characters are completely ignored where searching.

Steps to Reproduce

  1. Use the nightly build
  2. Go to 'songs''
  3. Search for any CJK string that should match a title / artist etc
  4. It's equivalent to a whitespace, and thus does not match anything.

Expected Behavior

Searching for CJK characters properly matches CJK strings.
I assume the new fuzzy search has no CJK support.

Screenshots

As you can see, CJK characters are not matched at all.

A couple more examples:

This seems to be the "default" match when searching for a whitespace (the same as with any pure CJK search)

Device

  • Device: Xiaomi Mi 11T Pro
  • OS: Android 14
  • Version: v2024.4.111-nightly+53b5a8c

Checklist

Cheers!
@BigBoyBarney BigBoyBarney added the type: bug Something isn't working label Apr 22, 2024
@zyrouge zyrouge added the priority: high High priority label Apr 22, 2024
@zyrouge zyrouge added this to the v112 milestone Apr 22, 2024
zyrouge added a commit that referenced this issue Oct 26, 2024
@zyrouge
fix: replace symbols instead of non-alphanumeric (#528)
6e987bc
@zyrouge zyrouge closed this as completed Oct 26, 2024
@zyrouge zyrouge modified the milestones: v112, v111 Oct 26, 2024
@zyrouge zyrouge added the state: done Has been fixed or implemented label Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: high High priority state: done Has been fixed or implemented type: bug Something isn't working
Projects
None yet
Milestone
v111
Development

No branches or pull requests
2 participants
@zyrouge @BigBoyBarney