Revert 'Prevent click event after item has been dragged' from #7 #23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7 includes a flag and handler to ignore the first 'click' event directly after dropping an item.
It's unclear why this change was needed and it causes unexpected functionality in my application.
In my application, after dragging and dropping an item, my next click on anything within the window is swallowed, the next click after that is registered.
This is because of the
this.preventClick
flag being set totrue
on drag end and subsequently tofalse
after a window 'click' event.@qtsd has already forked and reverted the change, plus some. I've just reverted the click handler addition here.
In the meantime, until this is merged and released, the last released version
react-dnd-mouse-backend@0.1.2
does not have this 'click-swallowing' behavior.