Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RFC3986 parser #14

Merged
merged 6 commits into from
Jan 9, 2019
Merged

Use RFC3986 parser #14

merged 6 commits into from
Jan 9, 2019

Conversation

ksss
Copy link
Collaborator

@ksss ksss commented Apr 22, 2018

$ mruby -e 'p URI.parse("http://example_app.com/").to_s'

before

the scheme http does not accept registry part: example_app.com (or bad hostname?) (URI::InvalidURIError)

after

"http://example_app.com/"

@take-cheeze
Copy link

@ksss Seems like there is regexp parsing error in 00_efc3986_parser.rb.
Please try: mattn/mruby-onig-regexp#90

@ksss
Copy link
Collaborator Author

ksss commented Jan 9, 2019

@take-cheeze Thank you for the advice.
The Onigmo did not support non-word char in group name. (ref mattn/mruby-onig-regexp#91)
I was worried about the solution, but finally I decided to change the group name in regexp.

@ksss ksss merged commit 3b653bb into zzak:master Jan 9, 2019
@ksss ksss deleted the parser branch January 9, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants