Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

does not work anymore with ECL #15

Closed
vrx opened this issue Dec 9, 2022 · 3 comments
Closed

does not work anymore with ECL #15

vrx opened this issue Dec 9, 2022 · 3 comments

Comments

@vrx
Copy link

vrx commented Dec 9, 2022

Hi,

Since commit 829bf7c on the 24th of august, the library does load anymore in ECL using quicklisp

It seems to be connected to SB libraries

quicklisp/local-projects/osc/devices/socket-functions.lisp" 0x55b0e2262aa0>, position 1958:
;;; Cannot find the external symbol NOT-CONNECTED-ERROR in #<"SB-BSD-SOCKETS" package>

OR

;;; Internal error:
;;; ** There is no package with the name SB-EXT.

coming back to 652a10d fixes the issue

@zzkt
Copy link
Owner

zzkt commented Dec 9, 2022

I think there is still some sbcl specific code in the devices module that needs to be loaded conditionally. If you are not using that, it should still work if the module is disabled.

if you add :if-feature :sbcl to the :module "devices" declaration in osc.asd does it load and/or work as expected?

ntrocado added a commit to ntrocado/osc that referenced this issue Jan 25, 2023
@zzkt
Copy link
Owner

zzkt commented Jan 25, 2023

Thanks @ntrocado looks good. does this change (i.e. #16) work for you @vrx ?

@zzkt
Copy link
Owner

zzkt commented Jan 2, 2024

seems to be working now...

@zzkt zzkt closed this as completed Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants