-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: num2words, babel, gettext, sentry imports #26475
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
num2words - 260KB - Used frequently on ERPNext sites. babel - 1.1MB Gets imported because of dates, localization sentry - 2.8MB should be loaded only if envvar is set gettext - required for reading translations
github-actions
bot
added
the
add-test-cases
Add test case to validate fix or enhancement
label
May 18, 2024
ankush
added
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
Backport the PR to v15
labels
May 18, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 18, 2024
num2words - 260KB - Used frequently on ERPNext sites. babel - 1.1MB Gets imported because of dates, localization sentry - 2.8MB should be loaded only if envvar is set gettext - required for reading translations (cherry picked from commit 445e1db) # Conflicts: # frappe/app.py # frappe/hooks.py # frappe/utils/sentry.py
mergify bot
pushed a commit
that referenced
this pull request
May 18, 2024
num2words - 260KB - Used frequently on ERPNext sites. babel - 1.1MB Gets imported because of dates, localization sentry - 2.8MB should be loaded only if envvar is set gettext - required for reading translations (cherry picked from commit 445e1db)
ankush
added a commit
that referenced
this pull request
May 19, 2024
num2words - 260KB - Used frequently on ERPNext sites. babel - 1.1MB Gets imported because of dates, localization sentry - 2.8MB should be loaded only if envvar is set gettext - required for reading translations (cherry picked from commit 445e1db) Co-authored-by: Ankush Menat <ankush@frappe.io>
ankush
added a commit
that referenced
this pull request
May 20, 2024
…6476) * perf: num2words, babel, gettext, sentry imports (#26475) num2words - 260KB - Used frequently on ERPNext sites. babel - 1.1MB Gets imported because of dates, localization sentry - 2.8MB should be loaded only if envvar is set gettext - required for reading translations (cherry picked from commit 445e1db) # Conflicts: # frappe/app.py # frappe/hooks.py # frappe/utils/sentry.py * chore: conflicts --------- Co-authored-by: Ankush Menat <ankush@frappe.io>
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 22, 2024
# [15.28.0](v15.27.0...v15.28.0) (2024-05-22) ### Bug Fixes * "Not assigned" filter ([#26468](#26468)) ([#26470](#26470)) ([ee6545b](ee6545b)) * compute modal title server side ([#26192](#26192)) ([3b787ac](3b787ac)) * condition of event participants ([#26300](#26300)) ([#26456](#26456)) ([31be0b9](31be0b9)) * default tree view ([07883a7](07883a7)) * Don't fiddle with child table indexes ([#26450](#26450)) ([#26453](#26453)) ([7e0d734](7e0d734)) * **DX:** Don't run CI if there are no tests (backport [#26457](#26457)) ([#26466](#26466)) ([72c693e](72c693e)) * enable fetch_from for Time fieldtype ([#25266](#25266)) ([#26471](#26471)) ([#26483](#26483)) ([f1267ca](f1267ca)) * **grid_row:** don't crash when undefined ([116ba1c](116ba1c)) * preserve checked items after a search ([befcce1](befcce1)) ### Features * **recorder:** Suggest index for optimizing query (backport [#26433](#26433)) ([#26435](#26435)) ([4b780cd](4b780cd)) ### Performance Improvements * num2words, babel, gettext, sentry imports ([#26475](#26475)) ([#26477](#26477)) ([e79e5f9](e79e5f9))
frappe-pr-bot
pushed a commit
that referenced
this pull request
May 22, 2024
# [14.75.0](v14.74.1...v14.75.0) (2024-05-22) ### Bug Fixes * "Not assigned" filter (backport [#26468](#26468)) ([#26469](#26469)) ([6bb3534](6bb3534)) * condition of event participants ([#26300](#26300)) ([#26455](#26455)) ([d940902](d940902)) * **contact list:** add space before designation ([a67ebab](a67ebab)) * Don't fiddle with child table indexes ([#26450](#26450)) ([#26452](#26452)) ([d0d6d93](d0d6d93)) * **DX:** Don't run CI if there are no tests (backport [#26457](#26457)) ([#26465](#26465)) ([d129c01](d129c01)) * enable fetch_from for Time fieldtype ([#25266](#25266)) ([#26471](#26471)) ([#26485](#26485)) ([9cd3bf6](9cd3bf6)) * **grid_row:** don't crash when undefined ([0f91073](0f91073)) * Ignore link doctype in comments ([#26484](#26484)) ([910d4a7](910d4a7)) * pass user and shared params when checking for cache keys ([#26402](#26402)) ([#26403](#26403)) ([30799f7](30799f7)) * preserve checked items after a search ([ae9cdd2](ae9cdd2)) ### Features * what's new (v15 port of [#21014](#21014)) (backport [#25986](#25986)) ([#26494](#26494)) ([6a561d9](6a561d9)) ### Performance Improvements * num2words, babel, gettext, sentry imports (backport [#26475](#26475)) ([#26476](#26476)) ([ea873fd](ea873fd))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
add-test-cases
Add test case to validate fix or enhancement
backport version-14-hotfix
backport to version 14
backport version-15-hotfix
Backport the PR to v15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
num2words - 260KB - Used frequently on ERPNext sites.
babel - 1.1MB Gets imported because of dates, localization
sentry - 2.8MB should be loaded only if envvar is set
gettext - required for reading translations