Prompt DQM for Pure MET Triggers 93X

[physicist87]

https://its.cern.ch/jira/browse/CMSHLT-1421

This PR is for Pure MET Triggers.

This PR is related to #19685

We only modified METMonitor_cff.py to add MET Triggers.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

[fwyzard]

@physicist87 if you don't mind, I will include your commits in a single PR where I am merging other changes, to avoid conflicts with other PRs.

We should keep this PR open until the other is merged.

[fwyzard]

@davidlange6 this PR is signed by DQM, and I think the changes are only in the python configuration.

Do you have any objections if I include it in a second "merged" PR to fix the various conflicts ?

[cmsbuild]

-1

Tested at: 2ce204c

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
de56eaa
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19689/21381/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19689/21381/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19689/21381/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
5.1 step2

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step2_TTbar+TTbarFS+HARVESTFS.log

135.4 step2

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step2_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

8.0 step5

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step5_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

4.22 step5

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step5_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

136.7611 step3

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016+HARVESTDR2_REMINIAOD_data2016/step3_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016+HARVESTDR2_REMINIAOD_data2016.log

1003.0 step3

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step3_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

1306.0 step4

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step4_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

140.53 step3

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step3_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

1000.0 step4

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step4_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1330.0 step4

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step4_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

10042.0 step5

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step5_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

9.0 step4

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step4_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

4.53 step4

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step4_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

25.0 step4

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step4_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

10024.0 step5

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step5

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

50202.0 step4

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step4_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log

136.731 step4

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step4_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

20034.0 step4

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step4_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

25202.0 step4

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step4_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

20434.0 step4

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19/step4_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
de56eaa
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19689/21381/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19689/21381/git-merge-result

[cmsbuild]

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

[davidlange6]

hi @fwyzard - i can't really comment - this PR looks to contain several others, so I don't know what the new/unique stuff in this PR actually is..

[fwyzard]

These PR have been forced to include others' developments, because there were not being integrated.

How do you suggest to proceed ?

.A

[physicist87]

@fwyzard This pr has problem during Test. Should I fix it ? I think I missed your last commit (remove multiple definition of the same modules : c6f3814).
Should I fix this PR ?

[fwyzard]

@davidlange6 for example you could look at the commit history.
AFAICT only the last two commits are new for this PR

• 10d4efb
• 2ce204c

and they touch only the python configuration

• DQMOffline/Trigger/python/METMonitor_cff.py

I am going to include these changes directly in #19685 or in a follow up PR.

[davidlange6]

On Jul 13, 2017, at 8:52 AM, Andrea Bocci ***@***.***> wrote: @davidlange6 for example you could look at the commit history; AFAICT only the last two commits are new for this PR • 10d4efb • 2ce204c and they touch only the python configuration • DQMOffline/Trigger/python/METMonitor_cff.py I am going to include these changes directly in #19685 or in a follow up PR.

which is to say this PR has picked up a bunch of orthogonal unneeded (for the development and testing of this PR) stuff. Is this due to some set of instructions people are following that should be fixed? I think there are also changes in METMonitor.cc/h anyway seems the only questions are how many histogram bins this adds that "unsigned" needs to be unsigned int. to avoid the unneeded copy of the reco::Vertex by making vtx a const pointer.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[fwyzard]

hi David,
@physicist87 should answer about the number of bins.

The reason for picking up the previous PRs is because you keep not merging them, so I'm doing it in #19685 to avoid having to resolve conflicts every single time.

I did do the merge locally, and as I wrote the only changes introduced by this PR are in DQMOffline/Trigger/python/METMonitor_cff.py

You comments about the code then should be addressed to the relevant PR.

[davidlange6]

On Jul 13, 2017, at 9:27 AM, Andrea Bocci ***@***.***> wrote: hi David, @physicist87 should answer about the number of bins. The reason for picking up the previous PRs is because you keep nor merging them, so I'm doing it in #19685 to avoid having to resolve conflicts every single time.

I don't understand what you mean actually. There are aparently a few files changed - but there a bunch of changes in unrelated files added. We aren't in CVS after all. Sorry that making and addressing comments takes time - but I think i'm doing my part to keep up.

I did do the merge locally, and as I wrote the only changes introduced by this PR are in DQMOffline/Trigger/python/METMonitor_cff.py You comments about the code then should be addressed to the relevant PR.

Sorry I cannot work that way (since I'm bad at guessing). We need PRs that have independent changes. Of course sometimes a PR will have to pick up some changes and then rebased if the same piece of a file is changed by multiple PRs. But that is not what we are talking about.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[fwyzard]

Sorry I cannot work that way (since I'm bad at guessing). We need PRs that have independent changes. Of course sometimes a PR will have to pick up some changes and then rebased if the same piece of a file is changed by multiple PRs. But that is not what we are talking about.

That would have been possible one and a half months ago.

In the meantime the PRs accumulated, done by over 10 different people for the same or different code base and python configurations, merging one another and conflicting with one another.

So, now I'm trying to sort out the mess.

What I would ask is to trust what I tell you about which commits "belong" to each PR, in order to base you comments only on the relevant part, and to let me know which ones you consider "ok" to be merged, so I can add them one by one to #19685 (or a follow up I'll be making shortly after).

[physicist87]

@fwyzard
Dear andrea, should I answer the number of bins for each histograms in METMonitor.cc ?

[fwyzard]

yes, please: with the given python configuration, how many bins do we get, counting all the histograms ?

[davidlange6]

On Jul 13, 2017, at 11:54 AM, Andrea Bocci ***@***.***> wrote: Sorry I cannot work that way (since I'm bad at guessing). We need PRs that have independent changes. Of course sometimes a PR will have to pick up some changes and then rebased if the same piece of a file is changed by multiple PRs. But that is not what we are talking about. That would have been possible one and a half months ago. In the meantime the PRs accumulated, done by over 10 different people for the same or different code base and python configurations, merging one another and conflicting with one another. So, now I'm trying to sort out the mess. What I would ask is to trust what I tell you about which commits "belong" to each PR, in order to base you comments only on the relevant part, and to let me know which ones you consider "ok" to be merged, so I can add them one by one to #19685 (or a follow up I'll be making shortly after).

I simply don't see how your generic point applies here at all. But ok, lets try and see if it works without creating lots of work. Probably you should just make a list for each pr.

…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[fwyzard]

Mhm, a list of what ?

[physicist87]

@davidlange6 @fwyzard
In this PR, I only updated Pure MET Trigger modifying METMonitor_cff.py .
The Trigger List is

HLT_L1ETMHadSeeds_v*
HLT_CaloMHT90_v*
HLT_CaloMET70_HBHECleaned_v*
HLT_CaloMET80_HBHECleaned_v*
HLT_CaloMET80_NotCleaned_v*
HLT_CaloMET90_HBHECleaned_v*
HLT_CaloMET90_NotCleaned_v*
HLT_CaloMET100_HBHECleaned_v*
HLT_CaloMET100_NotCleaned_v*
HLT_CaloMET110_NotCleaned_v*
HLT_CaloMET250_HBHECleaned_v*
HLT_CaloMET250_NotCleaned_v*
HLT_CaloMET300_HBHECleaned_v*
HLT_CaloMET350_HBHECleaned_v*
HLT_PFMET200_HBHE_BeamHaloCleaned_v*
HLT_PFMET200_HBHECleaned_v*
HLT_PFMET200_NotCleaned_v*
HLT_PFMET250_HBHECleaned_v*
HLT_PFMET300_HBHECleaned_v*
HLT_PFMETTypeOne200_HBHE_BeamHaloCleaned_v*

Total Triggers are 20.

And each trigger has
deltaphi_jet1jet2 ( nbins : 64, numerator & denominator ),
deltaphi_metjet1 ( nbins : 64, numerator & denominator ),
metPhi_( # of Bins : 64, numerator & denominator ),
metVsLS_ ( #of Bins :2500 , numerator & denominator ),
met_ (#of Bins : 200, numerator & denominator )
met_variable (# of bins : 25 ,numerator & denominator)
effic_met ( #of Bins : 200 ),
effic_metPhi ( #of Bins : 64 ),
effic_met_variable ( # of bins : 25 ),
effic_met_vs_LS ( #of Bins : 2500 ). So total the number of bins is 8627 for each trigger which I add.

Total of the number of bins : 8627 *20 = 172540.