Offline DQM for Higgs HLT #19078

sroychow · 2017-06-02T10:47:18Z

This PR is based on the PR from TOP #18981. This PR is for dilepton MuEg triggers and Trilepton triggers used by Higgs.

cmsbuild · 2017-06-02T10:47:35Z

A new Pull Request was created by @sroychow for master.

It involves the following packages:

DQMOffline/Trigger

@cmsbuild, @dmitrijus, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

mtosi · 2017-06-02T12:22:12Z

DQMOffline/Trigger/python/HiggsMonitoring_cff.py

+mu23TrkIsoVVLEle8CaloIdLTrackIdLIsoVL_muref = hltHIGmonitoring.clone()
+mu23TrkIsoVVLEle8CaloIdLTrackIdLIsoVL_muref.nmuons = cms.uint32(1)
+mu23TrkIsoVVLEle8CaloIdLTrackIdLIsoVL_muref.nelectrons = cms.uint32(1)
+mu23TrkIsoVVLEle8CaloIdLTrackIdLIsoVL_muref.FolderName = cms.string('HLT/Higgs/DiLepton/HLT_Mu23_TrkIsoVVL_Ele8_CaloIdL_TrackIdL_IsoVL_muref/')


probably a silly commnet
but wouldn't it be easier to have a directory structure like
HLT/Higgs/DiLepton/HLT_Mu23_TrkIsoVVL_Ele8_CaloIdL_TrackIdL_IsoVL/mu leg
and
HLT/Higgs/DiLepton/HLT_Mu23_TrkIsoVVL_Ele8_CaloIdL_TrackIdL_IsoVL/ele leg

in addition, do you really need the Higgs sub-directory ?

Hello Mia,
HLT_Mu23_TrkIsoVVL_Ele8_CaloIdL_TrackIdL_IsoVL/mu leg or eleleg makes sense. I named them according to the reference trigger used. For the subdirectory, I followed what other groups did. If you want, I can change to "HLT/DiLepton".

same comments applies to trileptons, of course

mtosi · 2017-06-02T12:41:48Z

DQMOffline/Trigger/python/HiggsMonitoring_Client_cff.py

+    verbose        = cms.untracked.uint32(0), # Set to 2 for all messages
+    resolution     = cms.vstring(),
+    efficiency     = cms.vstring(
+        "effic_muPt_1       'efficiency vs muon pt; muon pt [GeV]; efficiency' muPt_1_numerator       muPt_1_denominator",


are you going to monitor the 1st lepton in the collection ?
I thought the 3rd at least ....

This is the reference from DiElectron trigger. So we monitor the other leg(muon).

uhmm, maybe I choose the wrong line, I was referring to the tri-lepton trigger

Yes I will update the tripleMu trigger.

mtosi · 2017-06-02T12:44:26Z

DQMOffline/Trigger/python/HiggsMonitoring_cff.py

+mu23TrkIsoVVLEle8CaloIdLTrackIdLIsoVL_muref.nmuons = cms.uint32(1)
+mu23TrkIsoVVLEle8CaloIdLTrackIdLIsoVL_muref.nelectrons = cms.uint32(1)
+mu23TrkIsoVVLEle8CaloIdLTrackIdLIsoVL_muref.FolderName = cms.string('HLT/Higgs/DiLepton/HLT_Mu23_TrkIsoVVL_Ele8_CaloIdL_TrackIdL_IsoVL_muref/')
+mu23TrkIsoVVLEle8CaloIdLTrackIdLIsoVL_muref.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_Mu23_TrkIsoVVL_Ele8_CaloIdL_TrackIdL_IsoVL_v*") 


is this available in 2017 ?
I find HLT_Mu23_TrkIsoVVL_Ele12_CaloIdL_TrackIdL_IsoVL_DZ
could you please share the JIRA ticket, please ?

mtosi · 2017-06-02T12:45:39Z

DQMOffline/Trigger/python/HiggsMonitoring_cff.py

+mu8TrkIsoVVLEle23CaloIdLTrackIdLIsoVL_muref.nmuons = cms.uint32(1)
+mu8TrkIsoVVLEle23CaloIdLTrackIdLIsoVL_muref.nelectrons = cms.uint32(1)
+mu8TrkIsoVVLEle23CaloIdLTrackIdLIsoVL_muref.FolderName = cms.string('HLT/Higgs/DiLepton/HLT_Mu8_TrkIsoVVL_Ele23_CaloIdL_TrackIdL_IsoVL_muref/')
+mu8TrkIsoVVLEle23CaloIdLTrackIdLIsoVL_muref.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_Mu8_TrkIsoVVL_Ele23_CaloIdL_TrackIdL_IsoVL_v*") # 


as above, are you sure about this path ?
please, point to the JIRA ticket
I only see
HLT_Mu12_TrkIsoVVL_Ele23_CaloIdL_TrackIdL_IsoVL_DZ

@arunhep @heppye
such kind of checks should be done before STEAM ......

Sorry for this. We confirmed with Top developers that they will make a jira for the Mu8_Ele23 path. I shall drop them from this PR and update later.

mtosi · 2017-06-02T12:47:37Z

DQMOffline/Trigger/python/HiggsMonitoring_cff.py

+higgsTrimumon = hltHIGmonitoring.clone()
+higgsTrimumon.FolderName = cms.string('HLT/Higgs/TriLepton/HLT_TripleMu_12_10_5/')
+higgsTrimumon.nmuons = cms.uint32(3)
+higgsTrimumon.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_TripleMu_12_10_5_v*") # 


which is the JIRA ticket ?
I do not find any triple muon trigger :(

https://its.cern.ch/jira/browse/CMSHLT-1311

ah, ok, I see
this trigger is far from being integrated, as now

mtosi · 2017-06-02T12:47:55Z

DQMOffline/Trigger/python/HiggsMonitoring_cff.py

+higgsTrimumon.FolderName = cms.string('HLT/Higgs/TriLepton/HLT_TripleMu_12_10_5/')
+higgsTrimumon.nmuons = cms.uint32(3)
+higgsTrimumon.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_TripleMu_12_10_5_v*") # 
+higgsTrimumon.denGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_Mu17_TrkIsoVVL_Mu8_TrkIsoVVL_v*","HLT_Mu17_TrkIsoVVL_TkMu8_TrkIsoVVL_v*")


even those paths have to be fixed

These paths are in https://its.cern.ch/jira/browse/CMSHLT-1311 and https://its.cern.ch/jira/browse/CMSHLT-1250.

may bad
but the triple lepton is far from being integrated, right ?

mtosi · 2017-06-02T12:50:20Z

DQMOffline/Trigger/python/HiggsMonitoring_cff.py

+higgsTrielemon.FolderName = cms.string('HLT/Higgs/TriLepton/HLT_Ele16_Ele12_Ele8_CaloIdL_TrackIdL/')
+higgsTrielemon.nelectrons = cms.uint32(3)
+higgsTrielemon.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_Ele16_Ele12_Ele8_CaloIdL_TrackIdL_v*") # 
+higgsTrielemon.denGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_Ele23_Ele12_CaloIdL_TrackIdL_IsoVL_DZ_v*")


what is monitoring HLT_Ele23_Ele12_CaloIdL_TrackIdL_IsoVL_DZ ?

in addition, your leading leg has lower threshold w.r.t. reference trigger !
are you sure this is the proper trigger path to be used ?

mtosi · 2017-06-02T12:51:42Z

DQMOffline/Trigger/python/HiggsMonitoring_cff.py

+diMu9Ele9CaloIdLTrackIdL_muegref.FolderName = cms.string('HLT/Higgs/TriLepton/HLT_DiMu9_Ele9_CaloIdL_TrackIdL_muegRef/')
+diMu9Ele9CaloIdLTrackIdL_muegref.nelectrons = cms.uint32(1)
+diMu9Ele9CaloIdLTrackIdL_muegref.nmuons = cms.uint32(2)
+diMu9Ele9CaloIdLTrackIdL_muegref.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_DiMu9_Ele9_CaloIdL_TrackIdL_v*") # HLT_ZeroBias_v*


are you sure about the name ?
I do not find this trigger path
please, provide the JIRA ticket

https://its.cern.ch/jira/browse/CMSHLT-1311

mtosi · 2017-06-02T12:52:08Z

DQMOffline/Trigger/python/HiggsMonitoring_cff.py

+diMu9Ele9CaloIdLTrackIdL_muegref.nmuons = cms.uint32(2)
+diMu9Ele9CaloIdLTrackIdL_muegref.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_DiMu9_Ele9_CaloIdL_TrackIdL_v*") # HLT_ZeroBias_v*
+diMu9Ele9CaloIdLTrackIdL_muegref.denGenericTriggerEventPSet.hltPaths = cms.vstring(
+	"HLT_Mu23_TrkIsoVVL_Ele8_CaloIdL_TrackIdL_IsoVL_DZ_v*", 


please, check the name of these triggers !!!!!!!!

mtosi · 2017-06-02T12:52:56Z

DQMOffline/Trigger/python/HiggsMonitoring_cff.py

+mu8diEle12CaloIdLTrackIdL_muegref.FolderName = cms.string('HLT/Higgs/TriLepton/HLT_Mu8_DiEle12_CaloIdL_TrackIdL_muegRef/')
+mu8diEle12CaloIdLTrackIdL_muegref.nelectrons = cms.uint32(2)
+mu8diEle12CaloIdLTrackIdL_muegref.nmuons = cms.uint32(1)
+mu8diEle12CaloIdLTrackIdL_muegref.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_Mu8_DiEle12_CaloIdL_TrackIdL_v*") # HLT_ZeroBias_v*


and what about this ?

https://its.cern.ch/jira/browse/CMSHLT-1311

mtosi · 2017-06-02T12:58:53Z

DQMOffline/Trigger/python/HiggsMonitoring_cfi.py

+
+#MET and HT binning
+hltHIGmonitoring.histoPSet.metBinning = cms.vdouble(0,20,40,60,80,100,125,150,175,200)
+hltHIGmonitoring.histoPSet.HTBinning  = cms.vdouble(0,20,40,60,80,100,125,150,175,200,300,400,500,700)


do you really need such fine binning at low value ?

mtosi · 2017-06-02T12:59:27Z

DQMOffline/Trigger/python/HiggsMonitoring_cfi.py

+hltHIGmonitoring.histoPSet.metBinning = cms.vdouble(0,20,40,60,80,100,125,150,175,200)
+hltHIGmonitoring.histoPSet.HTBinning  = cms.vdouble(0,20,40,60,80,100,125,150,175,200,300,400,500,700)
+#Eta binning
+hltHIGmonitoring.histoPSet.eleEtaBinning = cms.vdouble(-2.4,-2.1,-1.7,-1.2,-0.9,-0.6,-0.3,-0.1,0,0.1,0.3,0.6,0.9,1.2,1.7,2.1,2.4)


can you apply the eta binning driven by detector acceptance, please?

mtosi · 2017-06-02T13:00:20Z

DQMOffline/Trigger/python/HiggsMonitoring_cfi.py

+hltHIGmonitoring.jets      = cms.InputTag("pfJetsEI") # ak4PFJets, ak4PFJetsCHS
+hltHIGmonitoring.electrons = cms.InputTag("gedGsfElectrons") # while pfIsolatedElectronsEI are reco::PFCandidate !
+hltHIGmonitoring.muons     = cms.InputTag("muons") # while pfIsolatedMuonsEI are reco::PFCandidate !
+hltHIGmonitoring.vertices  = cms.InputTag("offlinePrimaryVertices")


couldn't you use the goodPrimaryVertices collection ?
I think it should be run w/in RECO step, but I might be wrong,
please check

dmitrijus · 2017-06-06T13:30:18Z

+1

cmsbuild · 2017-06-06T13:30:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20358/console Started: 2017/06/06 15:31

cmsbuild · 2017-06-06T13:30:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

fwyzard · 2017-07-03T13:50:59Z

@cmsbuild, please test with #19119

cmsbuild · 2017-07-03T13:51:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21091/console Started: 2017/07/03 15:53

cmsbuild · 2017-07-03T14:53:39Z

+1
Tested at: 42669f2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19078/21091/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f0ec3de
b1580cd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19078/21091/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19078/21091/git-merge-result

cmsbuild · 2017-07-03T14:53:42Z

Comparison job queued.

cmsbuild · 2017-07-03T17:10:20Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19078/21091/summary.html

Comparison Summary:

You potentially added 195 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1756063
DQMHistoTests: Total failures: 30083
DQMHistoTests: Total nulls: 3
DQMHistoTests: Total successes: 1725811
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

fwyzard · 2017-07-12T09:10:53Z

@dmitrijus do you have any comments for this PR ?
@davidlange6 do you have any comments for this PR ?

I plan to include it in a second "merged" PR to fix the various conflicts.

dmitrijus · 2017-07-13T08:42:13Z

+1

@fwyzard It has a conflict, so, naturally I haven't looked at it.
It can go in, I see nothing wrong with it.

cmsbuild · 2017-07-13T08:42:33Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

fwyzard · 2017-07-13T08:58:07Z

Thanks @dmitrijus .

These all have conflicts because they end up touching the same files.
I don't think it is sustainable to review and merge them one at a time, because each merge is lilely to create more conflicts in the other PRs.

That's why I'm trying to resolve all conflicts locally, and submit a single "merged PR", once the individual PRs are OK.

This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top

higgs hlt dqm 92X

a062d25

cmsbuild added this to the CMSSW_9_2_X milestone Jun 2, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jun 2, 2017

mtosi reviewed Jun 2, 2017

View reviewed changes

updates addressing comments received from PR

6965d43

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jun 6, 2017

cmsbuild removed the tests-pending label Jun 6, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 3, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 3, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 3, 2017

fwyzard added a commit to fwyzard/cmssw that referenced this pull request Jul 11, 2017

Merge pull request cms-sw#19078 from sroychow:higgsHLT92X

4de7d0d

fwyzard mentioned this pull request Jul 11, 2017

HLT DQM for 9.3.x #19684

Closed

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 13, 2017

fwyzard added a commit to fwyzard/cmssw that referenced this pull request Jul 13, 2017

Merge branch pull request cms-sw#19078 from sroychow/higgsHLT92X

cdd45e3

fwyzard mentioned this pull request Jul 13, 2017

HLT DQM for 9.3.x - part 2 #19731

Merged

fwyzard added a commit to fwyzard/cmssw that referenced this pull request Jul 13, 2017

Merge branch pull request cms-sw#19078 from sroychow/higgsHLT92X

10b9acf

fwyzard added a commit to fwyzard/cmssw that referenced this pull request Jul 13, 2017

Merge pull request cms-sw#19078 from sroychow/higgsHLT92X

9b110bf

davidlange6 merged commit 42669f2 into cms-sw:master Jul 18, 2017

fwyzard mentioned this pull request Jul 28, 2017

backport HLT DQM for menu v2.1 to CMSSW 9.2.x #19961

Closed

Offline DQM for Higgs HLT #19078

Offline DQM for Higgs HLT #19078

Conversation

sroychow commented Jun 2, 2017

cmsbuild commented Jun 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dmitrijus commented Jun 6, 2017

cmsbuild commented Jun 6, 2017 • edited

cmsbuild commented Jun 6, 2017

fwyzard commented Jul 3, 2017

cmsbuild commented Jul 3, 2017 • edited

cmsbuild commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

cmsbuild commented Jul 3, 2017

fwyzard commented Jul 12, 2017

dmitrijus commented Jul 13, 2017

cmsbuild commented Jul 13, 2017

fwyzard commented Jul 13, 2017

cmsbuild commented Jun 6, 2017 •

edited

cmsbuild commented Jul 3, 2017 •

edited