Update of #19565: SUSY VBF trigger monitoring 93X #19585

tankit · 2017-07-06T13:23:16Z

#19565 is the PR to add histograms for VBF SUSY path, using #19294 which was merged.
The first PR had Unit Tests failure (see https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19565/21177/summary.html).
So, updated the PR, including HTDQM

cmsbuild · 2017-07-06T13:23:30Z

@tankit, CMSSW_9_3_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

cmsbuild · 2017-07-06T13:23:50Z

A new Pull Request was created by @tankit (Minsuk Kim) for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

mtosi · 2017-07-06T15:46:41Z

DQMOffline/Trigger/python/VBFSUSYMonitor_Client_cff.py

+    verbose        = cms.untracked.uint32(0), # Set to 2 for all messages
+    resolution     = cms.vstring(),
+    efficiency     = cms.vstring(
+        "effic_ht           'HT turnON;             PF HT [GeV]; efficiency'      ht_numerator           ht_denominator",


do you need this ?
if not, please drop
(we need to squeeze the # bins)

mtosi · 2017-07-06T15:46:50Z

DQMOffline/Trigger/python/VBFSUSYMonitor_Client_cff.py

+    efficiency     = cms.vstring(
+        "effic_ht           'HT turnON;             PF HT [GeV]; efficiency'      ht_numerator           ht_denominator",
+        "effic_ht_variable  'HT turnON;             PF HT [GeV]; efficiency'      ht_variable_numerator  ht_variable_denominator",
+        "effic_met          'MET turnON;            PF MET [GeV]; efficiency'     met_numerator          met_denominator",


do you need this ?
if not, please drop
(we need to squeeze the # bins)

It is okay to drop effic_ht and effic_met.
Do I need to update the code and git commit/push again?

mtosi · 2017-07-06T15:49:32Z

@cmsbuild, please test

cmsbuild · 2017-07-06T15:49:50Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21230/console Started: 2017/07/06 17:50

mtosi · 2017-07-06T15:50:01Z

tracked by #19142

cmsbuild · 2017-07-06T17:35:54Z

+1
Tested at: d363bc0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19585/21230/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
6625d2d
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19585/21230/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19585/21230/git-merge-result

cmsbuild · 2017-07-06T17:35:57Z

Comparison job queued.

cmsbuild · 2017-07-06T19:52:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19585/21230/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-19585/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016+HARVESTDR2_REMINIAOD_data2016

Comparison Summary:

You potentially added 17 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 1790655
DQMHistoTests: Total failures: 14540
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1775949
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

cmsbuild · 2017-07-13T09:23:30Z

Pull request #19585 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again.

dmitrijus · 2017-07-13T09:32:18Z

+1

cmsbuild · 2017-07-13T09:32:36Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21430/console Started: 2017/07/13 11:34

cmsbuild · 2017-07-13T09:32:37Z

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @smuzaffar

cmsbuild · 2017-07-13T11:27:25Z

+1
Tested at: 1cfdc43
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19585/21430/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2f0bf8c
9d873f4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19585/21430/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19585/21430/git-merge-result

cmsbuild · 2017-07-13T11:27:28Z

Comparison job queued.

cmsbuild · 2017-07-13T14:13:58Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19585/21430/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 23
DQMHistoTests: Total histograms compared: 2021747
DQMHistoTests: Total failures: 14514
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2007067
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 93 log files, 14 edm output root files, 23 DQM output files

davidlange6 · 2017-07-13T16:11:13Z

hi @fwyzard - this looks ready to go.

fwyzard · 2017-07-13T17:21:27Z

thanks @davidlange6 - I think you can merge it directly in 9.3.x, I don't get any conflicts with the my "merged PR".

davidlange6 · 2017-07-13T20:11:02Z

merge

This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top

tankit added 5 commits July 6, 2017 14:39

Update SusyMonitoring

5eab2ef

Update ObjMonitor for HTDQM

7152006

Update ObjMonitor for HTDQM

cef3e4e

Add HTDQM

30066cf

Add VBFSUSY HLTDQM

d363bc0

cmsbuild changed the base branch from CMSSW_9_3_X to master July 6, 2017 13:23

cmsbuild added this to the CMSSW_9_3_X milestone Jul 6, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jul 6, 2017

mtosi reviewed Jul 6, 2017

View reviewed changes

mtosi mentioned this pull request Jul 6, 2017

SUSY VBF trigger monitoring 93X #19565

Closed

cmsbuild added tests-started and removed tests-pending labels Jul 6, 2017

mtosi mentioned this pull request Jul 6, 2017

HLT DQM #19142

Open

cmsbuild added tests-approved and removed tests-started labels Jul 6, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 6, 2017

cmsbuild added dqm-pending pending-signatures tests-pending labels Jul 13, 2017

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jul 13, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 13, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 13, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 13, 2017

cmsbuild merged commit 8960944 into cms-sw:master Jul 13, 2017

fwyzard added a commit to fwyzard/cmssw that referenced this pull request Jul 13, 2017

Merge pull request cms-sw#19585 from tankit:SUSYVBF_HLTMON

3e67f6a

fwyzard added a commit to fwyzard/cmssw that referenced this pull request Jul 13, 2017

Merge pull request cms-sw#19585 from tankit/SUSYVBF_HLTMON

9341eee

fwyzard mentioned this pull request Jul 28, 2017

backport HLT DQM for menu v2.1 to CMSSW 9.2.x #19961

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update of #19565: SUSY VBF trigger monitoring 93X #19585

Update of #19565: SUSY VBF trigger monitoring 93X #19585

tankit commented Jul 6, 2017

cmsbuild commented Jul 6, 2017

cmsbuild commented Jul 6, 2017

mtosi Jul 6, 2017

mtosi Jul 6, 2017

tankit Jul 7, 2017

mtosi commented Jul 6, 2017

cmsbuild commented Jul 6, 2017 •

edited

mtosi commented Jul 6, 2017

cmsbuild commented Jul 6, 2017

cmsbuild commented Jul 6, 2017

cmsbuild commented Jul 6, 2017

cmsbuild commented Jul 13, 2017

dmitrijus commented Jul 13, 2017

cmsbuild commented Jul 13, 2017 •

edited

cmsbuild commented Jul 13, 2017

cmsbuild commented Jul 13, 2017

cmsbuild commented Jul 13, 2017

cmsbuild commented Jul 13, 2017

davidlange6 commented Jul 13, 2017

fwyzard commented Jul 13, 2017

davidlange6 commented Jul 13, 2017

Update of #19565: SUSY VBF trigger monitoring 93X #19585

Update of #19565: SUSY VBF trigger monitoring 93X #19585

Conversation

tankit commented Jul 6, 2017

cmsbuild commented Jul 6, 2017

cmsbuild commented Jul 6, 2017

mtosi Jul 6, 2017

Choose a reason for hiding this comment

mtosi Jul 6, 2017

Choose a reason for hiding this comment

tankit Jul 7, 2017

Choose a reason for hiding this comment

mtosi commented Jul 6, 2017

cmsbuild commented Jul 6, 2017 • edited

mtosi commented Jul 6, 2017

cmsbuild commented Jul 6, 2017

cmsbuild commented Jul 6, 2017

cmsbuild commented Jul 6, 2017

cmsbuild commented Jul 13, 2017

dmitrijus commented Jul 13, 2017

cmsbuild commented Jul 13, 2017 • edited

cmsbuild commented Jul 13, 2017

cmsbuild commented Jul 13, 2017

cmsbuild commented Jul 13, 2017

cmsbuild commented Jul 13, 2017

davidlange6 commented Jul 13, 2017

fwyzard commented Jul 13, 2017

davidlange6 commented Jul 13, 2017

cmsbuild commented Jul 6, 2017 •

edited

cmsbuild commented Jul 13, 2017 •

edited