Add DQM for VBF Higgs invisible HLT path #19294

amagnan · 2017-06-16T14:56:02Z

No description provided.

cmsbuild · 2017-06-16T14:56:22Z

A new Pull Request was created by @amagnan for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6 you are the release manager for this.

cms-bot commands are listed here

mtosi · 2017-06-16T15:20:59Z

tracked by #19142

mtosi · 2017-06-16T15:23:25Z

DQMOffline/Trigger/plugins/ObjMonitor.h

+  JetDQM jetDQM_;
+
+
+  GenericTriggerEventFlag* num_genTriggerEventFlag_;


please, make unique_ptr

mtosi · 2017-06-16T15:24:37Z

DQMOffline/Trigger/python/VBFMETMonitor_cff.py

+EXO_VBF_METmonitoring = hltobjmonitoring.clone()
+EXO_VBF_METmonitoring.FolderName = cms.string('HLT/Higgs/VBFMET/EXOVBF/')
+EXO_VBF_METmonitoring.numGenericTriggerEventPSet.hltInputTag   = cms.InputTag( "TriggerResults","","reHLT" )
+EXO_VBF_METmonitoring.numGenericTriggerEventPSet.hltPaths = cms.vstring("HLT_EXO_VBF")


we will need to update this string as soon as we have it in confDB ;)

mtosi · 2017-06-16T15:25:03Z

DQMOffline/Trigger/python/ObjMonitor_cfi.py

+hltobjmonitoring = objMonitoring.clone()
+hltobjmonitoring.FolderName = cms.string('HLT/GENERIC/')
+hltobjmonitoring.doMETHistos = cms.bool(True)
+hltobjmonitoring.histoPSet.metPSet = cms.PSet(


please, make use of variable binning ....

so I did but only for the histograms that make sense, for which turn-on vs variable makes sense. I think for the others it is useful to have the distributions with and without the filter but not mandatory to have fine binning because no expected turn-on.....

mtosi · 2017-06-16T15:25:22Z

DQMOffline/Trigger/python/ObjMonitor_cfi.py

+  xmax  = cms.double(3.1416),
+)
+hltobjmonitoring.doJetHistos = cms.bool(True)
+hltobjmonitoring.histoPSet.jet1ptPSet = cms.PSet(


please, make use of variable binning

mtosi · 2017-06-16T15:25:52Z

DQMOffline/Trigger/python/ObjMonitor_cfi.py

+  xmin  = cms.double(   0),
+  xmax  = cms.double(6000),
+)
+hltobjmonitoring.histoPSet.detajjPSet = cms.PSet(


please, decrease the # bins

mtosi · 2017-06-16T15:26:11Z

DQMOffline/Trigger/python/ObjMonitor_cfi.py

+  xmin  = cms.double(   -5),
+  xmax  = cms.double(5),
+)
+hltobjmonitoring.histoPSet.mjjPSet = cms.PSet(


even here you might prefer a variable binning

so here I have both variable and fixed for Mjj

mtosi · 2017-06-16T15:26:50Z

do you have the 2D plot (eta-phi) ?

mtosi · 2017-06-16T15:27:24Z

is it possible that I do not see the client ?
it should be used to do the turnON ....

mtosi · 2017-06-16T15:29:43Z

is it possible that I do not see the client ?
it should be used to do the turnON ....

amagnan · 2017-06-16T15:35:02Z

ahah, I was wondering if I had to do the turn-on by hand, so there should be more ;) Will ask you Monday! Thanks!

mtosi · 2017-06-16T15:42:11Z

DQMGenericClient

mtosi · 2017-06-16T15:44:09Z

the point is that we should try to squeeze as much as possible the # bins

cmsbuild · 2017-06-19T13:52:46Z

Pull request #19294 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again.

amagnan · 2017-06-19T13:55:39Z

Oups, pushed too quickly, some issues with unique_ptr, will fix now, sorry.....

cmsbuild · 2017-06-19T14:04:26Z

Pull request #19294 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again.

amagnan · 2017-06-19T14:06:10Z

OK I hope it is correct now for the unique_ptr. I have added the Client, removed duplicated histograms to keep only the ones with variable binning, and made variable binning for all pT/mass variables to avoid low-stat tails.

mtosi · 2017-06-20T05:46:21Z

@cmsbuild, please test

cmsbuild · 2017-06-20T05:46:35Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/20772/console Started: 2017/06/20 07:48

cmsbuild · 2017-07-04T11:42:14Z

Pull request #19294 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @vanbesien, @davidlange6 can you please check and sign again.

mtosi · 2017-07-04T11:50:19Z

@cmsbuild, please test

…

On Tue, Jul 4, 2017 at 1:42 PM, cmsbuild ***@***.***> wrote: Pull request #19294 <#19294> was updated. @vazzolini <https://github.com/vazzolini>, @kmaeshima <https://github.com/kmaeshima>, @dmitrijus <https://github.com/dmitrijus>, @cmsbuild <https://github.com/cmsbuild>, @vanbesien <https://github.com/vanbesien>, @davidlange6 <https://github.com/davidlange6> can you please check and sign again. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19294 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEt585cSd5srsfqV3rXbbeMVcKx9UAygks5sKiUZgaJpZM4N8kAK> .

cmsbuild · 2017-07-04T11:50:38Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/21126/console Started: 2017/07/04 14:59

cmsbuild · 2017-07-04T14:01:11Z

+1
Tested at: b3ebf45
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19294/21126/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
b1580cd
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19294/21126/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19294/21126/git-merge-result

cmsbuild · 2017-07-04T14:01:15Z

Comparison job queued.

cmsbuild · 2017-07-04T16:22:59Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19294/21126/summary.html

Comparison Summary:

You potentially added 7 lines to the logs
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 22
DQMHistoTests: Total histograms compared: 1756063
DQMHistoTests: Total failures: 29841
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 1726056
DQMHistoTests: Total skipped: 166
DQMHistoTests: Total Missing objects: 0
Checked 90 log files, 14 edm output root files, 22 DQM output files

mtosi · 2017-07-05T08:07:17Z

great !
thanks @amagnan
could you please do a PR w/ the backport in 92x ?
thanks !

amagnan · 2017-07-12T15:49:48Z

So, if I follow correctly, this fix suggested by @davidlange6 was forgotten before, but it is no problem to just put them in PR 19585, which is also for 93X is that correct ? Then it will anyway superseed my previous PR which is already merged. For the backports, my PR 19561 has not been merged yet, and you also have a duplicated one corresponding to 19585, is that correct ? If this is correct, I close 19561, you correct the code with the initialisation in 19585 and in the 92X backport PR and we are good to go..... Right ????

…

On 07/12/2017 04:02 PM, Minsuk Kim wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In DQMOffline/Trigger/plugins/GENERICDQM.h <#19294 (comment)>: > +#define DQMOffline_Trigger_GENERICDQM_H + +#include "DQMServices/Core/interface/MonitorElement.h" +#include "DQMServices/Core/interface/DQMStore.h" +#include "FWCore/ParameterSet/interface/ParameterSetDescription.h" + +struct MEbinning { + int nbins; + double xmin; + double xmax; +}; + +struct OBJME { + MonitorElement* numerator; + MonitorElement* denominator; + inline void clear(){ Hi, I now wonder how it will affect various developments using this base class in 93x and backport to 92x. For example, #19561 <#19561> and #19585 <#19585> have DQM codes with the initializations. Are they okay with the current base class that uses the clear method? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19294 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEeCzLSBEwmeuZt8KiydcQhYVRYXfiBCks5sNNHPgaJpZM4N8kAK>.

-- #################################################### Dr. Anne-Marie Magnan CMS

---------------------- --------------------------- 42-3-037, CERN Imperial College, HEP Dept. CH-1210 Geneva The Blackett Laboratory Prince Consort Road London SW7 2AZ (+41)(0)22 76 6 25 46 http://www.cern.ch http://www.imperial.ac.uk #################################################### â à è é ê ë æ î ï ô ö ù û ü ç ####################################################

tankit · 2017-07-13T02:07:29Z

Yes, PR 19585 is also for 93X.

For the backports, I have to close my backport because it has the duplicated one corresponding to 19585 and your TriggerDQMBase/METDQM/JetDQM codes. This means that it is not a backport. I am sorry for my misunderstanding on backporting.

Because I am using your codes above, your backport should be merged first unless two backports will be combined at the moment. So, I don't think that you close 19561.

@davidlange6 please let us know if you have any comments or suggestions.

tankit · 2017-07-13T03:58:33Z

@amagnan please check the following link in the case that you agree to combine the two backports:
https://github.com/cms-sw/cmssw/compare/CMSSW_9_2_X...tankit:from-CMSSW_9_2_X_2017-07-12-1100?expand=1

This PR includes a backport of the following PRs: - cms-sw#18172 - cms-sw#18950 - cms-sw#18959 - cms-sw#18968 - cms-sw#18971 - cms-sw#19023 - cms-sw#19046 - cms-sw#19078 - cms-sw#19119 - cms-sw#19178 - cms-sw#19290 - cms-sw#19293 - cms-sw#19294 - cms-sw#19490 - cms-sw#19499 - cms-sw#19577 - cms-sw#19585 - cms-sw#19596 - cms-sw#19599 - cms-sw#19627 - cms-sw#19689 - cms-sw#19694 - cms-sw#19703 - cms-sw#19781 - cms-sw#19794 plus the older ones, contained in DQMOffline/Trigger and HLTriggerOffline. It synchronises with CMSSW_9_3_X - DQMServices/ClientConfig - DQMOffline/Configuration - DQMOffline/Trigger - HLTriggerOffline/Btag - HLTriggerOffline/Higgs - HLTriggerOffline/SUSYBSM - HLTriggerOffline/Tau - HLTriggerOffline/Top

make modular ObjMonitor and add histos for VBF Higgs invisible path

5ac491d

cmsbuild added this to the CMSSW_9_2_X milestone Jun 16, 2017

cmsbuild added comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Jun 16, 2017

mtosi reviewed Jun 16, 2017

View reviewed changes

mtosi mentioned this pull request Jun 16, 2017

HLT DQM #19142

Open

adding VBFMET client and reduce binnings

2bbde3a

correcting usage of std::unique_ptr

93653c6

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Jul 4, 2017

cmsbuild added tests-started and removed tests-pending labels Jul 4, 2017

cmsbuild added tests-approved and removed tests-started labels Jul 4, 2017

cmsbuild added comparison-available and removed comparison-pending labels Jul 4, 2017

davidlange6 merged commit 2e75f20 into cms-sw:master Jul 5, 2017

This was referenced Jul 5, 2017

Cmssw 9 3 x #19564

Closed

SUSY VBF trigger monitoring 93X #19565

Closed

dmitrijus mentioned this pull request Jul 6, 2017

Backporting DQM for VBF+MET triggers to 92X #19561

Closed

tankit mentioned this pull request Jul 6, 2017

Update of #19565: SUSY VBF trigger monitoring 93X #19585

Merged

albertdow mentioned this pull request Jul 18, 2017

Monitoring VBF jets for VBF + 2 Taus HLT paths #19794

Merged

fwyzard mentioned this pull request Jul 28, 2017

backport HLT DQM for menu v2.1 to CMSSW 9.2.x #19961

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DQM for VBF Higgs invisible HLT path #19294

Add DQM for VBF Higgs invisible HLT path #19294

amagnan commented Jun 16, 2017

cmsbuild commented Jun 16, 2017

mtosi commented Jun 16, 2017

mtosi Jun 16, 2017

mtosi Jun 16, 2017

mtosi Jun 16, 2017

amagnan Jun 16, 2017

mtosi Jun 16, 2017

mtosi Jun 16, 2017

mtosi Jun 16, 2017

amagnan Jun 16, 2017

mtosi commented Jun 16, 2017

mtosi commented Jun 16, 2017

mtosi commented Jun 16, 2017

amagnan commented Jun 16, 2017

mtosi commented Jun 16, 2017

mtosi commented Jun 16, 2017

cmsbuild commented Jun 19, 2017

amagnan commented Jun 19, 2017

cmsbuild commented Jun 19, 2017

amagnan commented Jun 19, 2017

mtosi commented Jun 20, 2017

cmsbuild commented Jun 20, 2017 •

edited

cmsbuild commented Jul 4, 2017

mtosi commented Jul 4, 2017 via email

cmsbuild commented Jul 4, 2017 •

edited

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 4, 2017

mtosi commented Jul 5, 2017

amagnan commented Jul 12, 2017 via email

tankit commented Jul 13, 2017

tankit commented Jul 13, 2017

		JetDQM jetDQM_;


		GenericTriggerEventFlag* num_genTriggerEventFlag_;

Add DQM for VBF Higgs invisible HLT path #19294

Add DQM for VBF Higgs invisible HLT path #19294

Conversation

amagnan commented Jun 16, 2017

cmsbuild commented Jun 16, 2017

mtosi commented Jun 16, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mtosi commented Jun 16, 2017

mtosi commented Jun 16, 2017

mtosi commented Jun 16, 2017

amagnan commented Jun 16, 2017

mtosi commented Jun 16, 2017

mtosi commented Jun 16, 2017

cmsbuild commented Jun 19, 2017

amagnan commented Jun 19, 2017

cmsbuild commented Jun 19, 2017

amagnan commented Jun 19, 2017

mtosi commented Jun 20, 2017

cmsbuild commented Jun 20, 2017 • edited

cmsbuild commented Jul 4, 2017

mtosi commented Jul 4, 2017 via email

cmsbuild commented Jul 4, 2017 • edited

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 4, 2017

cmsbuild commented Jul 4, 2017

mtosi commented Jul 5, 2017

amagnan commented Jul 12, 2017 via email

tankit commented Jul 13, 2017

tankit commented Jul 13, 2017

cmsbuild commented Jun 20, 2017 •

edited

cmsbuild commented Jul 4, 2017 •

edited