replace explicit configuration of puppi with a reference from cfipython/, generated by PuppiProducer::fillDescriptions

[slava77]

This is a technical PR to reduce replication of configuration(s) and improve maintenability.

• parameters present in cfipython/fillDescriptions reference and repeated in the source python are dropped
• parameters which are present in cfipython/ but have a different value in the source python are kept after dropping the parameter type for improved syntax safety
• parameters with comments not present in cfipython/ are left
• other commented lines are left

Correctness is checked with expanded configuration in wf 136.888 which includes both a PAT and RECO variants of PuppiProducer (checked using edmConfigDump followed by a diff).

@jeongeun
this is an example PR for the follow up migration activity/task.

@camclean @alefisico please check and confirm if this update is acceptable.
Thank you.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33207/21641

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CommonTools/PileupAlgos/python/Puppi_cff.py modified in PR(s): drop type spec and move sequence to task in CommonTools #33201

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

CommonTools/PileupAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @ahinzmann, @jdolen, @gkasieczka, @hatakeyamak, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e00b72/13580/summary.html
COMMIT: 162ce95
CMSSW: CMSSW_11_3_X_2021-03-17-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33207/13580/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2639881
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2639852
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[alefisico]

I dont see any obvious mistake. I think the update is ok.

[slava77]

I dont see any obvious mistake. I think the update is ok.

Thank you for checking/confirming.

[slava77]

+reconstruction

for #33207 162ce95

• configuration python code changes are technical
• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1