xss: XSS To LFI Vulnerability #4869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses a vulnerability found by [AkkuS CW](https://pentest.com.tr) where a simple XSS attempt can lead to an LFI (Local File Inclusion) attack. The issue stems from the system returning the unformatted file contents in an error message when uploading a CSV to the User Importer. This formats the contents before uploading so that if the contents are returned in an error message they will not be executed by the browser which therefore prevents XSS attempts and the possibility of an LFI attack. This also formats all the user-created data sent to ImportError to prevent the same issue.
hejamu
pushed a commit
to physcip/osTicket
that referenced
this pull request
Jul 20, 2019
osTicket v1.10.6 Maintenance release for osTicket 1.10 === Enhancements * issue: Upgrader Wrong Guide Link (osTicket#4739) * iframe: Allow Multiple iFrame Domains (osTicket#4781) * issue: Strip Emoticons (osTicket#4523) === Improvements * issue: Maxfilesize Comma Crash (osTicket#4340) * issue: No Save Button On Quicknotes (osTicket#4706) * issue: PHP 7.2 Ticket Status (osTicket#4758) * issue: Canned Response Variables (osTicket#4759) * issue: FAQ Search Results (osTicket#4771) * issue: FAQ Return Errors (osTicket#4772) * issue: Duplicate Form Titles (osTicket#4788) * issue: Organizations Users Sort (osTicket#4806) * oops: Emojis Strip Korean (osTicket#4823) * issue: iFrame On Install (osTicket#4824) * issue: sendAccessLink On NULL (osTicket#4828) * Update README.md (eccc57a, e5f4180) * issue: iFrame Single Quotes (osTicket#4844) * issue: .eml/.msg Attachments (osTicket#4857) === Performance and Security * xss: XSS To LFI Vulnerability (osTicket#4869) * jquery: Update Again (osTicket#4858)
JoshBeckerPLCH
pushed a commit
to plch/osTicket
that referenced
this pull request
Feb 28, 2020
…ility xss: XSS To LFI Vulnerability
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a vulnerability found by AkkuS where a simple XSS attempt can lead to an LFI (Local File Inclusion) attack. The issue stems from the system returning the unformatted file contents in an error message when uploading a CSV to the User Importer. This formats the contents before uploading so that if the contents are returned in an error message they will not be executed by the browser which therefore prevents XSS attempts and the possibility of an LFI attack. This also formats all the user-created data sent to ImportError to prevent the same issue.