Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue: Strip Emoticons #4523

Merged
merged 1 commit into from Mar 26, 2019

Conversation

Projects
None yet
3 participants
@JediKev
Copy link
Member

commented Sep 19, 2018

This addresses an issue where emoticons/emojis cut off the remainder of the email when being added to a ticket thread.

@JediKev JediKev force-pushed the JediKev:issue/strip-emoticons branch 3 times, most recently from aee64a1 to d82988f Dec 18, 2018

@FG-Lars

This comment has been minimized.

Copy link

commented Mar 7, 2019

v1.11 still has this issue, which was released after this commit.

I'm new to this so I'm just asking, why this fix isn't included?

@FG-Lars

This comment has been minimized.

Copy link

commented Mar 7, 2019

Just had to revert to my backup files.

This fix also strips national characters like Æ Ø Å æ ø å (Norwegian)

@JediKev JediKev force-pushed the JediKev:issue/strip-emoticons branch from d82988f to db08a41 Mar 7, 2019

@JediKev

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

@FG-Lars

Updated. It should not remove Norwegian, German, etc. word characters, only emojis.

Cheers.

@FG-Lars

This comment has been minimized.

Copy link

commented Mar 8, 2019

Yes, that worked! Thanks

I discovered that it strips more:

Typed in:
image

Result:
image

issue: Strip Emoticons
This addresses an issue where emoticons/emojis cut off the remainder of the
email when being added to a ticket thread.

@JediKev JediKev force-pushed the JediKev:issue/strip-emoticons branch from db08a41 to f584a26 Mar 26, 2019

@protich protich merged commit bf741a6 into osTicket:develop Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.