Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue: Strip Emoticons #4523

Merged
merged 1 commit into from Mar 26, 2019
Merged

issue: Strip Emoticons #4523

merged 1 commit into from Mar 26, 2019

Conversation

JediKev
Copy link
Contributor

@JediKev JediKev commented Sep 19, 2018

This addresses an issue where emoticons/emojis cut off the remainder of the email when being added to a ticket thread.

@JediKev JediKev mentioned this pull request Nov 30, 2018
Closed
@JediKev JediKev force-pushed the issue/strip-emoticons branch 3 times, most recently from aee64a1 to d82988f Compare December 18, 2018 21:06
@FG-Lars
Copy link

FG-Lars commented Mar 7, 2019

v1.11 still has this issue, which was released after this commit.

I'm new to this so I'm just asking, why this fix isn't included?

@FG-Lars
Copy link

FG-Lars commented Mar 7, 2019

Just had to revert to my backup files.

This fix also strips national characters like Æ Ø Å æ ø å (Norwegian)

@JediKev
Copy link
Contributor Author

JediKev commented Mar 7, 2019

@FG-Lars

Updated. It should not remove Norwegian, German, etc. word characters, only emojis.

Cheers.

@FG-Lars
Copy link

FG-Lars commented Mar 8, 2019

Yes, that worked! Thanks

I discovered that it strips more:

Typed in:
image

Result:
image

@JediKev
issue: Strip Emoticons
f584a26 
This addresses an issue where emoticons/emojis cut off the remainder of the
email when being added to a ticket thread.
@protich protich merged commit bf741a6 into osTicket:develop Mar 26, 2019
@FG-Lars
Copy link

FG-Lars commented Jun 12, 2019

The issue with the < character is still present in v1.12

image

image

@JediKev
Copy link
Contributor Author

JediKev commented Jun 12, 2019

@FG-Lars

Read/follow on this thread please:
#3791 (comment)

Cheers.

@drmistral
Copy link

Hi, after moved to 1.12, a huge amount of "(empty)2 tickets were produced (and restored by hand :).
I've just found that the cause was in strip_emoticons that causes an (empty)-body tickets each time preg_replace returns null for an internal error. I've found this error is returned each time the text to be processed is not UTF-8, and this happens many times, at least in my case.

@JediKev
Copy link
Contributor Author

JediKev commented Jul 14, 2019

@drmistral

Tested using v1.12 and Gmail and cannot replicate the same results:

Email (Gmail)
https://m.imgur.com/gallery/iG1jxEY

Ticket In Helpdesk
https://m.imgur.com/gallery/XZoAdT9

Cheers.

hejamu pushed a commit to physcip/osTicket that referenced this pull request Jul 20, 2019
Merge tag 'v1.10.6' of https://github.com/osTicket/osTicket into physcip
98b5258 
osTicket v1.10.6

Maintenance release for osTicket 1.10

=== Enhancements
* issue: Upgrader Wrong Guide Link (osTicket#4739)
* iframe: Allow Multiple iFrame Domains (osTicket#4781)
* issue: Strip Emoticons (osTicket#4523)

=== Improvements
* issue: Maxfilesize Comma Crash (osTicket#4340)
* issue: No Save Button On Quicknotes (osTicket#4706)
* issue: PHP 7.2 Ticket Status (osTicket#4758)
* issue: Canned Response Variables (osTicket#4759)
* issue: FAQ Search Results (osTicket#4771)
* issue: FAQ Return Errors (osTicket#4772)
* issue: Duplicate Form Titles (osTicket#4788)
* issue: Organizations Users Sort (osTicket#4806)
* oops: Emojis Strip Korean (osTicket#4823)
* issue: iFrame On Install (osTicket#4824)
* issue: sendAccessLink On NULL (osTicket#4828)
* Update README.md (eccc57a, e5f4180)
* issue: iFrame Single Quotes (osTicket#4844)
* issue: .eml/.msg Attachments (osTicket#4857)

=== Performance and Security
* xss: XSS To LFI Vulnerability (osTicket#4869)
* jquery: Update Again (osTicket#4858)
JoshBeckerPLCH pushed a commit to plch/osTicket that referenced this pull request Feb 28, 2020
@protich
Merge pull request osTicket#4523 from JediKev/issue/strip-emoticons
331e0a6 
issue: Strip Emoticons
@j127
Copy link

j127 commented Apr 28, 2021

Is anyone else still experiencing this problem? Emojis are cutting of the support tickets in 1.14.2 (installed after the Feb 28, 2020 date above). There are more details here. Our support tickets often have unicode flags like this in them, and it deletes anything after the flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JediKev @FG-Lars @drmistral @j127 @protich