Advance search - Do not Merge #833
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an initial version that works, but has a few issues. Please see quran#665 for further discussion.
Replaced several english words that are commonly used by indonesian users for corresponding indonesian language words that are equally commonly used or are getting popular, such as "Unduh" for Download and "Berkas" for File. Rephrasing and redactional changes to current indonesian translation to reflect the more exact meaning of the english prompts and directions. Re-order strings in indonesian translation to the same order as the english. Complete all string translations which were not translated in previous file.
removed should-not-be-translated xml entries
When saving the translations.cache file, if the directory didn't exist, we'd throw an exception (which we'd silently catch). We can fix this by running mkdirs on the parent first, which is the correct thing to do in this case.
This updates Quran to build against Android N, and updates the support libraries. As a result of this, the Spinner implementation changed again, thus breaking our mirrored version. This patch thus reimplements SpinnerCompat as a subclass of the newest AppCompatSpinner, while overriding the correct methods to make sure the dropdown width is correct.
Fix travis by explicitly using jdk8
These new code styles are based off of the Square Android and Google code styles, with some minor modifications. The biggest, most notable change is dropping Hungarian notation. This change should be done incrementally as old files are being cleaned up and refactored.
Quran actually worked pretty well with multi-window mode, minus one issue - toggling the ToolBar wasn't working. This is due to the fact that in multi-window mode, "apps cannot hide the status bar." This mostly fixes quran#679, with the exception of the fact that the status bar still overlays the page in multi-window mode. While this itself can't be fixed (because "apps cannot hide the status bar if they are not running in full-screen mode"), it should be possible, in the future, to drop Quran out of full screen mode when in multi-window mode.
The ActionBar navigation modes have been deprecated for a while now. Consequently, this patch migrates to embedding a Spinner in the ToolBar and toggling that instead. Furthermore, it also begins to reuse the spinner adapter for the translations list instead of making a new one every time.
The gradient was being generated with the width of the screen. When we're on a tablet and showing two pages, we should use half the width for each gradient instead.
This patch replaces the ImageViews for the left and right borders with drawables that are shared between pages and are just drawn on the canvas. This patch also switches QuranPageLayout to be a custom ViewGroup instead of a subclass of FrameLayout, since later on, we'll want to move the drawing of the page header and footer text here.
This also removes two of the catch exception blocks since upstream fixes likely make them unnecessary.
This patch introduces a "mode" that is passed to FragmentStatePagerAdapter, which determines whether we are in single or dual page mode. When switching from one to the other, remove all the fragments from FragmentManager since there is no reason to cache them. Fixes quran#681.
This patch greatly improves tablet orientation change by making a few fixes - first, it stops the ViewPager from restoring its page number when the pages are different between portrait and landscape. Second, it stops calling setCurrentItem more than once. See quran#681 for further discussion.
Previously, we'd remove the window background immediately on phone, and we'd do so after some time on tablet. This makes both remove it immediately.
This was due to a really bad bug where the database handler for the Arabic database would always (unconditionally) return null.
Some people complained about the three entries. This adds a list to the filter to be able to turn these off and only have one recent entry.
Previously, when any translation would fail, we'd show nothing. This fixes that problem.
Setting the disabled flag from here to true allows for builds without the disable crashlytics flag that also don't log to crashlytics.
May Allah reward brother Abdul-Raqeeb for these!
Sometimes, the translation was repeated in the inline view. This happened whenver there was more than one translation (even when one of them was broken). Fixes quran#789.
Disable translations of sura names for German until the sura list can better handle long translation names.
Yas Sin corrected to Ya-Sin
This reverts commit debc6d4. # Conflicts: # app/src/main/res/values/strings.xml
This patch introduces a warsh flavor for the app (see quran#629).
add options for advanced search to seach activity
ahmedre
force-pushed
the
master
branch
2 times, most recently
from
acf48be
to
f4d3065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Experimental prototype for advance search
remove 150 limit restriction.
add more query controls (and, or, not)
only examine the last commit (Advance Search) changes
Let me know what you think