New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advance search - Do not Merge #833
base: main
Are you sure you want to change the base?
Commits on Jul 5, 2016
-
Initial support for Shemerly pages
This is an initial version that works, but has a few issues. Please see quran#665 for further discussion.
Configuration menu - View commit details
-
Copy full SHA for 5ba6c51 - Browse repository at this point
Copy the full SHA 5ba6c51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6717402 - Browse repository at this point
Copy the full SHA 6717402View commit details
Commits on Jul 21, 2016
-
Update strings.xml for Indonesian language (quran#669)
Replaced several english words that are commonly used by indonesian users for corresponding indonesian language words that are equally commonly used or are getting popular, such as "Unduh" for Download and "Berkas" for File. Rephrasing and redactional changes to current indonesian translation to reflect the more exact meaning of the english prompts and directions. Re-order strings in indonesian translation to the same order as the english. Complete all string translations which were not translated in previous file.
Configuration menu - View commit details
-
Copy full SHA for d1a7c4e - Browse repository at this point
Copy the full SHA d1a7c4eView commit details
Commits on Jul 23, 2016
-
removed should-not-be-translated xml entries
Configuration menu - View commit details
-
Copy full SHA for 90f119e - Browse repository at this point
Copy the full SHA 90f119eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3133b9a - Browse repository at this point
Copy the full SHA 3133b9aView commit details
Commits on Aug 20, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 2b7ce96 - Browse repository at this point
Copy the full SHA 2b7ce96View commit details
Commits on Sep 1, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 996d82b - Browse repository at this point
Copy the full SHA 996d82bView commit details -
Attempt to make the db directory before writing
When saving the translations.cache file, if the directory didn't exist, we'd throw an exception (which we'd silently catch). We can fix this by running mkdirs on the parent first, which is the correct thing to do in this case.
Configuration menu - View commit details
-
Copy full SHA for 4431d8c - Browse repository at this point
Copy the full SHA 4431d8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 58e2ecf - Browse repository at this point
Copy the full SHA 58e2ecfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56a7b4b - Browse repository at this point
Copy the full SHA 56a7b4bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6d90aa4 - Browse repository at this point
Copy the full SHA 6d90aa4View commit details -
This updates Quran to build against Android N, and updates the support libraries. As a result of this, the Spinner implementation changed again, thus breaking our mirrored version. This patch thus reimplements SpinnerCompat as a subclass of the newest AppCompatSpinner, while overriding the correct methods to make sure the dropdown width is correct.
Configuration menu - View commit details
-
Copy full SHA for 01f1caa - Browse repository at this point
Copy the full SHA 01f1caaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 985e1fb - Browse repository at this point
Copy the full SHA 985e1fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6924726 - Browse repository at this point
Copy the full SHA 6924726View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6bcffd2 - Browse repository at this point
Copy the full SHA 6bcffd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for a008e67 - Browse repository at this point
Copy the full SHA a008e67View commit details
Commits on Sep 2, 2016
-
These new code styles are based off of the Square Android and Google code styles, with some minor modifications. The biggest, most notable change is dropping Hungarian notation. This change should be done incrementally as old files are being cleaned up and refactored.
Configuration menu - View commit details
-
Copy full SHA for 28095b7 - Browse repository at this point
Copy the full SHA 28095b7View commit details -
Better support for multi-window mode on Android N
Quran actually worked pretty well with multi-window mode, minus one issue - toggling the ToolBar wasn't working. This is due to the fact that in multi-window mode, "apps cannot hide the status bar." This mostly fixes quran#679, with the exception of the fact that the status bar still overlays the page in multi-window mode. While this itself can't be fixed (because "apps cannot hide the status bar if they are not running in full-screen mode"), it should be possible, in the future, to drop Quran out of full screen mode when in multi-window mode.
Configuration menu - View commit details
-
Copy full SHA for f900472 - Browse repository at this point
Copy the full SHA f900472View commit details -
Configuration menu - View commit details
-
Copy full SHA for 94cd6b9 - Browse repository at this point
Copy the full SHA 94cd6b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 828e744 - Browse repository at this point
Copy the full SHA 828e744View commit details -
Replace NAVIGATION_MODE_LIST with Spinner
The ActionBar navigation modes have been deprecated for a while now. Consequently, this patch migrates to embedding a Spinner in the ToolBar and toggling that instead. Furthermore, it also begins to reuse the spinner adapter for the translations list instead of making a new one every time.
Configuration menu - View commit details
-
Copy full SHA for 5a7ae75 - Browse repository at this point
Copy the full SHA 5a7ae75View commit details
Commits on Sep 3, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 76ffff8 - Browse repository at this point
Copy the full SHA 76ffff8View commit details
Commits on Sep 4, 2016
-
Fix gradient for tablet landscape with two pages
The gradient was being generated with the width of the screen. When we're on a tablet and showing two pages, we should use half the width for each gradient instead.
Configuration menu - View commit details
-
Copy full SHA for f580928 - Browse repository at this point
Copy the full SHA f580928View commit details -
Manually draw borders in QuranPageLayout
This patch replaces the ImageViews for the left and right borders with drawables that are shared between pages and are just drawn on the canvas. This patch also switches QuranPageLayout to be a custom ViewGroup instead of a subclass of FrameLayout, since later on, we'll want to move the drawing of the page header and footer text here.
Configuration menu - View commit details
-
Copy full SHA for 15c8bed - Browse repository at this point
Copy the full SHA 15c8bedView commit details
Commits on Sep 5, 2016
-
Update FragmentStatePagerAdapter
This also removes two of the catch exception blocks since upstream fixes likely make them unnecessary.
Configuration menu - View commit details
-
Copy full SHA for b965669 - Browse repository at this point
Copy the full SHA b965669View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3541c3 - Browse repository at this point
Copy the full SHA d3541c3View commit details
Commits on Sep 6, 2016
-
Remove old fragment types on orientation change
This patch introduces a "mode" that is passed to FragmentStatePagerAdapter, which determines whether we are in single or dual page mode. When switching from one to the other, remove all the fragments from FragmentManager since there is no reason to cache them. Fixes quran#681.
Configuration menu - View commit details
-
Copy full SHA for 5a03036 - Browse repository at this point
Copy the full SHA 5a03036View commit details -
Greatly improve tablet orientation change
This patch greatly improves tablet orientation change by making a few fixes - first, it stops the ViewPager from restoring its page number when the pages are different between portrait and landscape. Second, it stops calling setCurrentItem more than once. See quran#681 for further discussion.
Configuration menu - View commit details
-
Copy full SHA for 4993ff3 - Browse repository at this point
Copy the full SHA 4993ff3View commit details -
Don't delay removing window background on tablet
Previously, we'd remove the window background immediately on phone, and we'd do so after some time on tablet. This makes both remove it immediately.
Configuration menu - View commit details
-
Copy full SHA for a204370 - Browse repository at this point
Copy the full SHA a204370View commit details
Commits on Sep 8, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 3a37651 - Browse repository at this point
Copy the full SHA 3a37651View commit details
Commits on Sep 15, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 8f941a4 - Browse repository at this point
Copy the full SHA 8f941a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93508e6 - Browse repository at this point
Copy the full SHA 93508e6View commit details -
Make seekbar preference consistent with prefs
On Lollipop and above, the seekbar preference was misindented (and had the incorrect text size) when compared to the remaining items. This patch fixes this. In the future, these preferences should be replaced with something else (i.e. to make it easier to see the effects of the adjustment instead of just having a meaningless number for size or brightness).
Configuration menu - View commit details
-
Copy full SHA for 14869ba - Browse repository at this point
Copy the full SHA 14869baView commit details
Commits on Sep 16, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 034a89e - Browse repository at this point
Copy the full SHA 034a89eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2af353d - Browse repository at this point
Copy the full SHA 2af353dView commit details -
Improve header and footer text display
Previously, the header and footer were drawn completely according to where the bounds of the page were (so as to not take extra space). This is problematic in many places (especially in landscape), because ayah headers aren't part of the database (and even if they were, they're at the very top of the screen anyway) - consequently, the text overlays them. This patch draws text at a fixed height (and pads the view to make space for the text).
Configuration menu - View commit details
-
Copy full SHA for 9f91631 - Browse repository at this point
Copy the full SHA 9f91631View commit details -
Set the page padding right away (instead of waiting until information about the coordinates of the items on the page loads). This stops the jumping of the page when pages are quickly changed.
Configuration menu - View commit details
-
Copy full SHA for cf41f78 - Browse repository at this point
Copy the full SHA cf41f78View commit details
Commits on Sep 17, 2016
-
Separate header font size from height
This fixes naskh, where, without doing this, the text touches the border that surrounds the screen.
Configuration menu - View commit details
-
Copy full SHA for b94f1b6 - Browse repository at this point
Copy the full SHA b94f1b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 14ed90a - Browse repository at this point
Copy the full SHA 14ed90aView commit details -
Also bump Qaloon and Naskh to 1.0.5. Note that there seems to have been a regression in the support library, that, on Lollipop and below, causes the toolbar's back arrow to point in the wrong direction with Arabic. However, will still go ahead and release this.
Configuration menu - View commit details
-
Copy full SHA for f30eb1d - Browse repository at this point
Copy the full SHA f30eb1dView commit details
Commits on Sep 19, 2016
-
Configuration menu - View commit details
-
Copy full SHA for b92e508 - Browse repository at this point
Copy the full SHA b92e508View commit details
Commits on Oct 4, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 415569b - Browse repository at this point
Copy the full SHA 415569bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f70a60f - Browse repository at this point
Copy the full SHA f70a60fView commit details
Commits on Oct 6, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 3434a3f - Browse repository at this point
Copy the full SHA 3434a3fView commit details
Commits on Nov 15, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 0108af8 - Browse repository at this point
Copy the full SHA 0108af8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65f7c37 - Browse repository at this point
Copy the full SHA 65f7c37View commit details -
Add an import option to settings
Many people have complained about not being to import. This patch adds an actual import preference, which just fires off an ACTION_GET_CONTENT intent. On Kitkat and above, the Storage Access Framework gives people the option to import from applications that are document providers (ex Dropbox, Google Drive, etc). On older devices, this usually offers a file picker as an option. Fixes quran#634.
Configuration menu - View commit details
-
Copy full SHA for 7e85df8 - Browse repository at this point
Copy the full SHA 7e85df8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55642dc - Browse repository at this point
Copy the full SHA 55642dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1429289 - Browse repository at this point
Copy the full SHA 1429289View commit details
Commits on Nov 20, 2016
-
Make certain headers not clickable and cleanup
Make the headers for "Current Page", "Page Bookmarks", and "Not Tagged" not clickable (since they do nothing when clicked or long clicked). Clean up some code.
Configuration menu - View commit details
-
Copy full SHA for 03e0313 - Browse repository at this point
Copy the full SHA 03e0313View commit details -
Configuration menu - View commit details
-
Copy full SHA for 54ea278 - Browse repository at this point
Copy the full SHA 54ea278View commit details
Commits on Nov 21, 2016
-
Configuration menu - View commit details
-
Copy full SHA for a6f6f36 - Browse repository at this point
Copy the full SHA a6f6f36View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7fd642 - Browse repository at this point
Copy the full SHA a7fd642View commit details -
Fix explicit LTR hardcodes for lint
Most of these LTR hardcodes are needed for supporting pre-api 17. To fix this, split out layout-ar and layout-ar-v17, with the latter being an exact copy of the respective files from layout. Some of the other cases (the various ViewPager indicators) actually always receive data in the correct order, so they need to be LTR. These cases have been placed in the code instead. It should be possible to remove some of these explicit layout direction attributes in the future after some additional work.
Configuration menu - View commit details
-
Copy full SHA for 2261605 - Browse repository at this point
Copy the full SHA 2261605View commit details -
Fix QuranSpinner dropdown width
In cases when the calculated dropdown width is less than the width of the actual spinner, use that width as the dropdown width. This stops certain sura names from being cut off.
Configuration menu - View commit details
-
Copy full SHA for 376360f - Browse repository at this point
Copy the full SHA 376360fView commit details -
adding an .editorconfig file to the repo so that new contributors will automatically have their formatting setup correctly. It's built into Android Studio. Settings->Editor->Code Style then Check "Enable EditorConfig".
Configuration menu - View commit details
-
Copy full SHA for b721c07 - Browse repository at this point
Copy the full SHA b721c07View commit details
Commits on Nov 22, 2016
-
[f] .editorconfig to use spaces on all files
The .editorconfig used to adress .java and .sh solely. Since the code style guide says that 2 spaces is used throughout the project. I've changed .editorconfig to use 2 spaces throughout the project.
Configuration menu - View commit details
-
Copy full SHA for e90bfa3 - Browse repository at this point
Copy the full SHA e90bfa3View commit details
Commits on Nov 23, 2016
-
Configuration menu - View commit details
-
Copy full SHA for ec85297 - Browse repository at this point
Copy the full SHA ec85297View commit details -
Configuration menu - View commit details
-
Copy full SHA for e8d1f26 - Browse repository at this point
Copy the full SHA e8d1f26View commit details -
Re-enable lint for ci and release
This also makes "missing translations" a warning instead of an error.
Configuration menu - View commit details
-
Copy full SHA for 7dfaf10 - Browse repository at this point
Copy the full SHA 7dfaf10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8316798 - Browse repository at this point
Copy the full SHA 8316798View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e39439 - Browse repository at this point
Copy the full SHA 0e39439View commit details
Commits on Nov 24, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 694d81f - Browse repository at this point
Copy the full SHA 694d81fView commit details
Commits on Nov 25, 2016
-
Support continuous indentation in editorconfig
This is supported by Android Studio and IntelliJ and is important for keeping consistency with the existing code style.
Configuration menu - View commit details
-
Copy full SHA for 3f27a74 - Browse repository at this point
Copy the full SHA 3f27a74View commit details
Commits on Nov 26, 2016
-
Configuration menu - View commit details
-
Copy full SHA for c389dd8 - Browse repository at this point
Copy the full SHA c389dd8View commit details
Commits on Nov 27, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 9133548 - Browse repository at this point
Copy the full SHA 9133548View commit details -
Split the setting advanced options into a new preferences screen
mohamed committedNov 27, 2016 Configuration menu - View commit details
-
Copy full SHA for 45c3f56 - Browse repository at this point
Copy the full SHA 45c3f56View commit details
Commits on Nov 28, 2016
-
This implements recent pages for Quran (using similar behavior to Quran for iOS). A table of recent pages now exists within the bookmarks database. Whenever a Quran page is selected, it is added to the table. When the page changes, the new page replaces the old one in recents. The recents table currently maintains a maximum of 3 items. Fixes quran#691.
Configuration menu - View commit details
-
Copy full SHA for d4ab0e6 - Browse repository at this point
Copy the full SHA d4ab0e6View commit details -
RxPreferences was used for listening to changes on the last page. Now that this code has changes, this is no longer needed. Will consider adding it back in the future if needed insha'Allah.
Configuration menu - View commit details
-
Copy full SHA for 4bb1a29 - Browse repository at this point
Copy the full SHA 4bb1a29View commit details -
Configuration menu - View commit details
-
Copy full SHA for 18b7820 - Browse repository at this point
Copy the full SHA 18b7820View commit details -
Split advanced setting options into a new activity with new fragment …
…and clean up all calsses
mohamed committedNov 28, 2016 Configuration menu - View commit details
-
Copy full SHA for 11a6213 - Browse repository at this point
Copy the full SHA 11a6213View commit details -
Merge branch 'master' of https://github.com/quran/quran_android
mohamed committedNov 28, 2016 Configuration menu - View commit details
-
Copy full SHA for 3ed03af - Browse repository at this point
Copy the full SHA 3ed03afView commit details -
Use same text as in the menu to jump last page
This is to have a consistent UI text accross the app. When there is only one recently read page, the title will be the same as the jump menu title in the action bar.
Configuration menu - View commit details
-
Copy full SHA for 10d8732 - Browse repository at this point
Copy the full SHA 10d8732View commit details
Commits on Nov 29, 2016
-
Merge pull request quran#713 from ozbek/master
Use recent pages size to correctly get quantity string
Configuration menu - View commit details
-
Copy full SHA for cff725e - Browse repository at this point
Copy the full SHA cff725eView commit details -
Merge pull request quran#715 from ozbek/i18n
Use same text as in the menu to jump last page
Configuration menu - View commit details
-
Copy full SHA for 7a2b5c3 - Browse repository at this point
Copy the full SHA 7a2b5c3View commit details -
Do all of the comments on the the previous pull request
mohamed committedNov 29, 2016 Configuration menu - View commit details
-
Copy full SHA for be1f836 - Browse repository at this point
Copy the full SHA be1f836View commit details
Commits on Nov 30, 2016
-
Merge pull request quran#714 from mhussien86/master
Split setting screen into options and advanced options issue quran#704
Configuration menu - View commit details
-
Copy full SHA for cb566e1 - Browse repository at this point
Copy the full SHA cb566e1View commit details -
Add translation for "Recent pages" (quran#716)
Add translation for "Recent pages"
Configuration menu - View commit details
-
Copy full SHA for 9ab16a4 - Browse repository at this point
Copy the full SHA 9ab16a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f5be49 - Browse repository at this point
Copy the full SHA 5f5be49View commit details
Commits on Dec 4, 2016
-
Avoid an extra delete when it's not needed
When updating recent pages, we often delete entries, add a new one, and then prune the list to make sure there are no more than 3 entries. If our first delete caused us to delete at one row, we don't have to delete again.
Configuration menu - View commit details
-
Copy full SHA for d698172 - Browse repository at this point
Copy the full SHA d698172View commit details -
Improve Recent pages implementation
Previously, recent pages was doing a database query every time a page changed in order to update the recent pages table. This patch cleans this up by batching update information and only writing to the database in onPause. It also provides a much cleaner implementation for getting the last page. Previously, getting the last page meant getting recents and then returning the last page. This implementation adds an Observable with the very latest last page seen (even if it hasn't been committed to the database yet). This observable is prepopulated with the most recent page from the database and thereafter never depends on the database. This patch also refactors recent pages out into a RecentPageModel and adds unit tests for it. A RecentPagePresenter is also added to begin the process of decoupling business logic from PagerActivity.
Configuration menu - View commit details
-
Copy full SHA for c5f41da - Browse repository at this point
Copy the full SHA c5f41daView commit details -
Fix broken unit test (quran#720)
The unit test called a method that called onNext on a subject. This subject was subscribed to as an observable to do some extra work, but was doing this work on an io thread. The bug was that the unit test was doing the checks before the code that was supposed to run on the io thread ran (since the unit test itself is synchronous unless we explicitly wait for something). The fix is to explicitly wait for the observable to get an event, thereby letting us know that the code was executed, before checking that the right things were called.
Configuration menu - View commit details
-
Copy full SHA for fd54461 - Browse repository at this point
Copy the full SHA fd54461View commit details
Commits on Dec 7, 2016
-
Configuration menu - View commit details
-
Copy full SHA for d63eb85 - Browse repository at this point
Copy the full SHA d63eb85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 921861e - Browse repository at this point
Copy the full SHA 921861eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1623625 - Browse repository at this point
Copy the full SHA 1623625View commit details -
This updates most of the libraries to the latest version.
Ahmed El-Helw authored and Ahmed El-Helw committedDec 7, 2016 Configuration menu - View commit details
-
Copy full SHA for cc1a0bd - Browse repository at this point
Copy the full SHA cc1a0bdView commit details -
Use the gradle plugin's annotation processing
Android gradle plugin 2.2 and above support annotation processors, so switching to those instead of android-apt.
Ahmed El-Helw authored and Ahmed El-Helw committedDec 7, 2016 Configuration menu - View commit details
-
Copy full SHA for 9e676be - Browse repository at this point
Copy the full SHA 9e676beView commit details
Commits on Dec 9, 2016
-
Configuration menu - View commit details
-
Copy full SHA for a02ed53 - Browse repository at this point
Copy the full SHA a02ed53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a5be81 - Browse repository at this point
Copy the full SHA 2a5be81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8470d98 - Browse repository at this point
Copy the full SHA 8470d98View commit details
Commits on Dec 11, 2016
-
Settings: remove advanced options category, move volume key navigation (
quran#731) * Remove "Advanced options" category As we are using a separate screen and have "Advanced options" in the title, the category seems redundant. Also move volume key navigation to reading prefs category.
Configuration menu - View commit details
-
Copy full SHA for 1cf56b7 - Browse repository at this point
Copy the full SHA 1cf56b7View commit details
Commits on Dec 12, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 15fc948 - Browse repository at this point
Copy the full SHA 15fc948View commit details -
Configuration menu - View commit details
-
Copy full SHA for 06a5fb8 - Browse repository at this point
Copy the full SHA 06a5fb8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64ce460 - Browse repository at this point
Copy the full SHA 64ce460View commit details -
Failing tests should show stack trace
Some flakey tests are only failing on Travis. This change should help us identify why the failures happen.
Ahmed El-Helw authored and Ahmed El-Helw committedDec 12, 2016 Configuration menu - View commit details
-
Copy full SHA for 327ec36 - Browse repository at this point
Copy the full SHA 327ec36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3432fde - Browse repository at this point
Copy the full SHA 3432fdeView commit details -
Support shortcuts on 7.1 and certain launchers
Android 7.1 supports app shortcuts natively (as do some launchers, even on pre-7.1 versions). This patch supports a shortcut for jumping to the most recent page.
Configuration menu - View commit details
-
Copy full SHA for a5187d5 - Browse repository at this point
Copy the full SHA a5187d5View commit details -
Lint fails on java 8 syntax, so use android-retrolambda-lombok to work around this issue.
Configuration menu - View commit details
-
Copy full SHA for 95f5394 - Browse repository at this point
Copy the full SHA 95f5394View commit details
Commits on Dec 13, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 66a02e1 - Browse repository at this point
Copy the full SHA 66a02e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33c0d24 - Browse repository at this point
Copy the full SHA 33c0d24View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6cb3274 - Browse repository at this point
Copy the full SHA 6cb3274View commit details -
Refactoring for Dagger Application modules
This patch moves ApplicationComponent and ApplicationModule into an application package. It also splits up ApplicationModule into smaller modules (Network and Database).
Configuration menu - View commit details
-
Copy full SHA for e169fe8 - Browse repository at this point
Copy the full SHA e169fe8View commit details -
Support Stetho network interceptor for debug
This patch adds a separate component for Debug, which overrides the NetworkModule with the debug module (that enables the network interceptor for Stetho).
Configuration menu - View commit details
-
Copy full SHA for ca35a1a - Browse repository at this point
Copy the full SHA ca35a1aView commit details
Commits on Dec 14, 2016
-
Fix regression in Audio manager
RxJava 2 does not allow null returns. Some of the audio manager observables were returning null in some cases. This cleans it up and fixes quran#738.
Configuration menu - View commit details
-
Copy full SHA for d84fadf - Browse repository at this point
Copy the full SHA d84fadfView commit details
Commits on Dec 15, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 2987bbf - Browse repository at this point
Copy the full SHA 2987bbfView commit details -
Remember the last reading mode (quran#736)
This will enable going back to translation mode when jump to last page is selected from the action bar. Fix quran#530.
Configuration menu - View commit details
-
Copy full SHA for 9dafc94 - Browse repository at this point
Copy the full SHA 9dafc94View commit details -
Fix flakey recent page model test
The testUpdateLatestPageWithSlowRecents test was flakey - it is intended to ensure that if somehow, a person got to a page before the data came back from the database, that we'd disregard the database data in this case and use the person's pages instead. This change makes the test deterministic by artificially delaying the recent pages result, and only advancing the time after a page is emitted.
Configuration menu - View commit details
-
Copy full SHA for 24ceb11 - Browse repository at this point
Copy the full SHA 24ceb11View commit details -
Fix flakey TagBookmarkPresenter tests
Many of the tag bookmark presenter tests were flakey because we didn't really know when async operations were complete. This fixes the problem by moving all the work done after the async process to a method, which the test then overrides to know when the async operation is complete.
Configuration menu - View commit details
-
Copy full SHA for 4b5ea3f - Browse repository at this point
Copy the full SHA 4b5ea3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for f26a5c1 - Browse repository at this point
Copy the full SHA f26a5c1View commit details
Commits on Dec 18, 2016
-
Fix force close in non-Madani build types (quran#739)
That's caused by 2987bbf because advanced settings intent was hard coded in xml. This also adds a summary to advanced settings preference.
Configuration menu - View commit details
-
Copy full SHA for c77f05f - Browse repository at this point
Copy the full SHA c77f05fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c626bb - Browse repository at this point
Copy the full SHA 1c626bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 526e1ca - Browse repository at this point
Copy the full SHA 526e1caView commit details -
Configuration menu - View commit details
-
Copy full SHA for b69d578 - Browse repository at this point
Copy the full SHA b69d578View commit details -
Configuration menu - View commit details
-
Copy full SHA for 704906a - Browse repository at this point
Copy the full SHA 704906aView commit details
Commits on Dec 19, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 173de03 - Browse repository at this point
Copy the full SHA 173de03View commit details
Commits on Dec 21, 2016
-
Remove unnecessary arg in AudioUtils.getQariUrl() (quran#744)
Apparently, getQariUrl() is called with `true` as the second argument everywhere.
Configuration menu - View commit details
-
Copy full SHA for 62ce52d - Browse repository at this point
Copy the full SHA 62ce52dView commit details -
Configuration menu - View commit details
-
Copy full SHA for a93b2d9 - Browse repository at this point
Copy the full SHA a93b2d9View commit details
Commits on Dec 22, 2016
-
Static provides methods generate more efficient code in Dagger 2.
Configuration menu - View commit details
-
Copy full SHA for d75b62d - Browse repository at this point
Copy the full SHA d75b62dView commit details
Commits on Dec 23, 2016
-
Implement initial TranslationPresenter
This translation presenter is intended to replace TranslationTask.
Configuration menu - View commit details
-
Copy full SHA for 693aaa9 - Browse repository at this point
Copy the full SHA 693aaa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60eecf6 - Browse repository at this point
Copy the full SHA 60eecf6View commit details -
Use TranslationPresenter in inline translation
This also refactors the code in TranslationPresenter to mostly be in an abstract parent class, so that most of the code can be cleanly shared between InlineTranslationPresenter and TranslationPresenter.
Configuration menu - View commit details
-
Copy full SHA for 641be8c - Browse repository at this point
Copy the full SHA 641be8cView commit details -
Support page number for TranslationPresenter
Update AbstractTranslationPresenter to allow for any callback type, so that inline translations can just have a no-parameter callback, whereas the one for page translations can also receive a page parameter in the callback (which will be useful for tablet soon insha'Allah).
Configuration menu - View commit details
-
Copy full SHA for 3e7f665 - Browse repository at this point
Copy the full SHA 3e7f665View commit details -
Use TranslationPresenter in TabletFragment
This also allows the removal of TranslationTask, since it is no longer being used.
Configuration menu - View commit details
-
Copy full SHA for 7b479c0 - Browse repository at this point
Copy the full SHA 7b479c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64dc4a9 - Browse repository at this point
Copy the full SHA 64dc4a9View commit details
Commits on Dec 24, 2016
-
Split image response callback into an interface
Instead of re-using AyahTracker, split out the image callback to a new interface since it's only relevant when showing images. This will likely end up being removed when QuranPageWorker is switched to use RxJava.
Configuration menu - View commit details
-
Copy full SHA for 0faccc1 - Browse repository at this point
Copy the full SHA 0faccc1View commit details -
Add a provider for providing and caching ayahinfo
Instead of the previous way, where PagerActivity would attempt to get a handle to the database and cache it forever (to be shared by the pages), this patch moves the logic to an AyahInfoDatabaseProvider instead.
Configuration menu - View commit details
-
Copy full SHA for 09e7550 - Browse repository at this point
Copy the full SHA 09e7550View commit details
Commits on Dec 25, 2016
-
Share some common code between phone and tablet
There is a lot of replicated code between tablet and the Quran page - certain tasks are common between the two (fetching bookmarks, page bounds, and ayah bounds). This patch adds a QuranPagePresenter and starts moving the common code into it.
Configuration menu - View commit details
-
Copy full SHA for ba3ce63 - Browse repository at this point
Copy the full SHA ba3ce63View commit details
Commits on Dec 26, 2016
-
Share more code between Quran and Tablet
This diff moves most of the "ayah tracking" code (highlighting and unhighlighting of ayahs, getting the ayah at a position, etc) into a shared presenter to be used by both QuranPageFragment and TabletFragment. The fragment has to specify an array of its pages, and any command is then given to each page to handle it depending on its page type. This greatly simplifies the existing tablet code, which historically was very similar to the phone code, with the exception of a check for which page to map a command to. The fact that its shared means that Quran and Tablet can now have similar experiences (without double the effort).
Configuration menu - View commit details
-
Copy full SHA for 06b3f93 - Browse repository at this point
Copy the full SHA 06b3f93View commit details -
Change the order or page load operations
Make the ayah coordinates load after the page coordinates and before the bookmarks (since bookmarks can't be shown without ayah coordinates). Also decrease the amount of time to wait before starting to fetch the page coordinates.
Configuration menu - View commit details
-
Copy full SHA for 095bb02 - Browse repository at this point
Copy the full SHA 095bb02View commit details -
Configuration menu - View commit details
-
Copy full SHA for dc22989 - Browse repository at this point
Copy the full SHA dc22989View commit details
Commits on Dec 27, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 98af861 - Browse repository at this point
Copy the full SHA 98af861View commit details -
Configuration menu - View commit details
-
Copy full SHA for 959559b - Browse repository at this point
Copy the full SHA 959559bView commit details -
Only try to re-download images if download failed
Since bind may be called multiple times, only try to re-fetch the images if they weren't fetched the first time around.
Configuration menu - View commit details
-
Copy full SHA for 0001768 - Browse repository at this point
Copy the full SHA 0001768View commit details -
Improve handling of Arabic database
The Arabic database is optional, and the file may not be there. Don't crash if it's not there, and try again if we failed to get it each time we ask for Arabic data.
Configuration menu - View commit details
-
Copy full SHA for 5845ad8 - Browse repository at this point
Copy the full SHA 5845ad8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a19d8b - Browse repository at this point
Copy the full SHA 5a19d8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cfebff1 - Browse repository at this point
Copy the full SHA cfebff1View commit details -
Configuration menu - View commit details
-
Copy full SHA for acfa46c - Browse repository at this point
Copy the full SHA acfa46cView commit details -
Improve dependency injection structure
Introduce two new Dagger scopes - ActivityScope and QuranPageScope. Also add two new components - a PagerActivityComponent, which is a submodule of ApplicationComponent for injecting PagerActivity, and a QuranPageComponent, which is a subcomponent of PagerActivityComponent, and can be used for injecting each QuranPage.
Configuration menu - View commit details
-
Copy full SHA for 07e8cc9 - Browse repository at this point
Copy the full SHA 07e8cc9View commit details -
Configuration menu - View commit details
-
Copy full SHA for df5419d - Browse repository at this point
Copy the full SHA df5419dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0721833 - Browse repository at this point
Copy the full SHA 0721833View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9e31ccc - Browse repository at this point
Copy the full SHA 9e31cccView commit details
Commits on Dec 28, 2016
-
Support multiple pages in TranslationPresenter
This patch updates TranslationPresenter to be able to deal with multiple pages. This allows tablet to use one TranslationPresenter that is shared between both the left and right pages (instead of one for the left page and one for the right one). This also uses Dagger to inject TranslationPresenters wherever they are needed.
Configuration menu - View commit details
-
Copy full SHA for fa01026 - Browse repository at this point
Copy the full SHA fa01026View commit details -
Let TranslationModel be ActivityScope
There's no reason to make a new TranslationModel for every single page of the ViewPager that we visit, so make it ActivityScope and inject it instead of manually making a new one every time.
Configuration menu - View commit details
-
Copy full SHA for 2f36074 - Browse repository at this point
Copy the full SHA 2f36074View commit details
Commits on Dec 29, 2016
-
Only read intent if not saved instance state (quran#747)
Because the code for reading values for the ViewPager always happened after checking saved instance state, the values there would override the saved instance state values. This fixes a bug where, upon opening a page, switching to the other mode, and switching a few pages, you'd go back to the mode you started in before switching (or, on tablet, it'd happen right away when switching from portrait to landscape).
Configuration menu - View commit details
-
Copy full SHA for e372348 - Browse repository at this point
Copy the full SHA e372348View commit details
Commits on Dec 30, 2016
-
Switch Translation Manager to RecyclerView (quran#745)
* Added butterknife for view/resources injection * quran#709 - Switch Translation Manager to RecyclerView * quran#709 - fixed incorrect method name to match getter in TranslationAdapter * quran#709 - renamed TranslationAdapter to TranslationsAdapter * quran#709 - added ButterKnife to about screen * quran#709 - Cleaned up TranslationManagerActivity - Removed Hungarian notation - Removed unnecessary instanceof check * quran#709 - Cleaned up TranslationManagerActivity - Removed redundant LinearLayout in translation_manager * quran#709 - Cleaned up TranslationsAdapter - Changed PublishSubject ti UnicastSubject as there will only be one subscriber - Removed TextUtils static import - Cached recurring method calls
Configuration menu - View commit details
-
Copy full SHA for 2b4883e - Browse repository at this point
Copy the full SHA 2b4883eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97a52de - Browse repository at this point
Copy the full SHA 97a52deView commit details
Commits on Jan 9, 2017
-
Introduce functional tests (quran#756)
* quran#750 - Added the Espresso functional testing library * quran#750 - Added base activity test class * quran#750 - Added basic test QuranActivityTest: - Click on Surah in list view an ensure it opens Surah by checking triggered intents - Removed unused code * quran#750 - Remove unnecessary new line in BaseActivityTest * quran#750 - Reset shared preferences at every test to ensure consistency * quran#750 - Refactored QuranActivityTest to work on all flavours * quran#750 - Renamed test in QuranActivityTest
Configuration menu - View commit details
-
Copy full SHA for d25aa60 - Browse repository at this point
Copy the full SHA d25aa60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 819b3f5 - Browse repository at this point
Copy the full SHA 819b3f5View commit details -
Rename old TranslationView and clean it up
Rename the old TranslationView to InlineTranslationView (used in the inline translation mode). Also remove all the unnecessary pieces.
Configuration menu - View commit details
-
Copy full SHA for 80058d8 - Browse repository at this point
Copy the full SHA 80058d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d8f256 - Browse repository at this point
Copy the full SHA 0d8f256View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96dd6fe - Browse repository at this point
Copy the full SHA 96dd6feView commit details -
Configuration menu - View commit details
-
Copy full SHA for f2ad855 - Browse repository at this point
Copy the full SHA f2ad855View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2c3eae1 - Browse repository at this point
Copy the full SHA 2c3eae1View commit details -
Configuration menu - View commit details
-
Copy full SHA for f7b2fda - Browse repository at this point
Copy the full SHA f7b2fdaView commit details -
Configuration menu - View commit details
-
Copy full SHA for ed144a6 - Browse repository at this point
Copy the full SHA ed144a6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 120efe5 - Browse repository at this point
Copy the full SHA 120efe5View commit details -
Fix some bugs and cache the translation list instead of getting it on every single refresh call.
Configuration menu - View commit details
-
Copy full SHA for 6a559c1 - Browse repository at this point
Copy the full SHA 6a559c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for e756c33 - Browse repository at this point
Copy the full SHA e756c33View commit details -
Configuration menu - View commit details
-
Copy full SHA for cf7dc69 - Browse repository at this point
Copy the full SHA cf7dc69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dfdd6c - Browse repository at this point
Copy the full SHA 8dfdd6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0277772 - Browse repository at this point
Copy the full SHA 0277772View commit details -
Configuration menu - View commit details
-
Copy full SHA for f02b3ea - Browse repository at this point
Copy the full SHA f02b3eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a6572f - Browse repository at this point
Copy the full SHA 0a6572fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 73b6877 - Browse repository at this point
Copy the full SHA 73b6877View commit details -
Remove textIsSelectable for now
Remove textIsSelectable for now because it doesn't work reliably when there's also an onClickListener on the same TextView.
Configuration menu - View commit details
-
Copy full SHA for e566aee - Browse repository at this point
Copy the full SHA e566aeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for a740d16 - Browse repository at this point
Copy the full SHA a740d16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5499c21 - Browse repository at this point
Copy the full SHA 5499c21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50c7508 - Browse repository at this point
Copy the full SHA 50c7508View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0295a5a - Browse repository at this point
Copy the full SHA 0295a5aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a1b303 - Browse repository at this point
Copy the full SHA 3a1b303View commit details -
Make updating highlights more efficient
Pass in a change parameter to notifyItemRangeChanged so we only update the background instead of trying to update all the data. Also attempt to combine the two notifyItemRangeChanged calls when possible.
Configuration menu - View commit details
-
Copy full SHA for 7118126 - Browse repository at this point
Copy the full SHA 7118126View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e83811 - Browse repository at this point
Copy the full SHA 0e83811View commit details -
This patch supports multiple translations, but doesn't expose any ui to be able to choose multiple translations to be viewed yet. It also will hide the translator label if there is only one translation.
Configuration menu - View commit details
-
Copy full SHA for 2812d13 - Browse repository at this point
Copy the full SHA 2812d13View commit details -
Configuration menu - View commit details
-
Copy full SHA for a37f122 - Browse repository at this point
Copy the full SHA a37f122View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8d8f6e - Browse repository at this point
Copy the full SHA a8d8f6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for faa1ad9 - Browse repository at this point
Copy the full SHA faa1ad9View commit details -
Add a checkbox besides the translations, and allow selecting multiple translations at the same time.
Configuration menu - View commit details
-
Copy full SHA for be9b419 - Browse repository at this point
Copy the full SHA be9b419View commit details -
Don't use translation as spinner title
For the full screen view, use a similar title and subtitle to Quran view. For the inline view, show "Translations" for now.
Configuration menu - View commit details
-
Copy full SHA for 402fdc8 - Browse repository at this point
Copy the full SHA 402fdc8View commit details -
Error log: Error:Conflict with dependency 'com.android.support:support-annotations' in project ':app'. Resolved versions for app (25.1.0) and test app (23.1.1) differ. See http://g.co/androidstudio/app-test-app-conflict for details.
Configuration menu - View commit details
-
Copy full SHA for 4868a82 - Browse repository at this point
Copy the full SHA 4868a82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d1755a - Browse repository at this point
Copy the full SHA 0d1755aView commit details
Commits on Jan 10, 2017
-
Update toolbar in translation view (quran#763)
Apparently, translationItems will not have enough time to get populated in onCreate() when we try to update the toolbar with translation items. So, let's call updateActionBarSpinner() once we get translationItems updated. Fixes quran#757
Configuration menu - View commit details
-
Copy full SHA for 0bfca2a - Browse repository at this point
Copy the full SHA 0bfca2aView commit details
Commits on Jan 11, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9a5dbf6 - Browse repository at this point
Copy the full SHA 9a5dbf6View commit details
Commits on Jan 13, 2017
-
QuranAyah was being used in many cases where SuraAyah should be used instead. This patch replaces all those instances and removes QuranAyah.
Configuration menu - View commit details
-
Copy full SHA for 7d74fb6 - Browse repository at this point
Copy the full SHA 7d74fb6View commit details -
Invalidate NumberFormat when Locale changes
Fixes quran#746. Because the callback would happen after the locale changed (but before the change was fully in effect), when switching from Arabic back to the default language, the app would make a new NumberFormat using the locale, which at that point, was still the Arabic locale. This causes Arabic numbers in between non-Arabic text on the main page.
Configuration menu - View commit details
-
Copy full SHA for a42bf27 - Browse repository at this point
Copy the full SHA a42bf27View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fe1fea - Browse repository at this point
Copy the full SHA 2fe1feaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b4747d - Browse repository at this point
Copy the full SHA 8b4747dView commit details
Commits on Jan 14, 2017
-
Configuration menu - View commit details
-
Copy full SHA for d7bd1d9 - Browse repository at this point
Copy the full SHA d7bd1d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f3d61d - Browse repository at this point
Copy the full SHA 6f3d61dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2914fed - Browse repository at this point
Copy the full SHA 2914fedView commit details
Commits on Jan 16, 2017
-
Configuration menu - View commit details
-
Copy full SHA for a816cea - Browse repository at this point
Copy the full SHA a816ceaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2afab3d - Browse repository at this point
Copy the full SHA 2afab3dView commit details -
Update bookmarks & tags contextual action bar translation (quran#771)
Add several translation lines for the bookmarks & tags bar which have not been added to the Indonesian strings. This might resolve the "weird translation" that pop up in the Bookmark bar for the recent pages.
Configuration menu - View commit details
-
Copy full SHA for 44469b5 - Browse repository at this point
Copy the full SHA 44469b5View commit details
Commits on Jan 17, 2017
-
Create booleans.xml (quran#774)
activating surah names translation for indonesian language
Configuration menu - View commit details
-
Copy full SHA for 1703cc5 - Browse repository at this point
Copy the full SHA 1703cc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa5c60b - Browse repository at this point
Copy the full SHA fa5c60bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d2805e9 - Browse repository at this point
Copy the full SHA d2805e9View commit details
Commits on Jan 19, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 4e3265f - Browse repository at this point
Copy the full SHA 4e3265fView commit details
Commits on Jan 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for ac55668 - Browse repository at this point
Copy the full SHA ac55668View commit details
Commits on Jan 27, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 6515cd4 - Browse repository at this point
Copy the full SHA 6515cd4View commit details -
Configuration menu - View commit details
-
Copy full SHA for aead639 - Browse repository at this point
Copy the full SHA aead639View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7cf2fb6 - Browse repository at this point
Copy the full SHA 7cf2fb6View commit details -
Fix the exporting of data for debug build
Due to the package name change, file_paths.xml also needs to change to reflect the correct directory.
Configuration menu - View commit details
-
Copy full SHA for 738cfdb - Browse repository at this point
Copy the full SHA 738cfdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for cfdcf33 - Browse repository at this point
Copy the full SHA cfdcf33View commit details -
Fix exporting bookmarks often not working
Exporting bookmarks often fails due to the thread being interrupted (when okio sees an interrupted thread, it throws an exception instead of flushing the sink during the sink.close() call). This resets the interrupted status on the thread so that exporting bookmarks works.
Configuration menu - View commit details
-
Copy full SHA for eaba5c0 - Browse repository at this point
Copy the full SHA eaba5c0View commit details -
Use
external-files-path
instead ofexternal-path
(quran#780)Because, we are actually using `external-files-path` albeit in hard-coded way. This should now fix exporting data in all other build variants and flavors as well.
Configuration menu - View commit details
-
Copy full SHA for 16d99ba - Browse repository at this point
Copy the full SHA 16d99baView commit details
Commits on Jan 28, 2017
-
Fix a crash when removing advanced preferences
Certain advanced preferences (app location and logging) are removed when they are not available. This was causing a crash in the app. This patch fixes it.
Configuration menu - View commit details
-
Copy full SHA for 0a52e65 - Browse repository at this point
Copy the full SHA 0a52e65View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93ec669 - Browse repository at this point
Copy the full SHA 93ec669View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9bd854 - Browse repository at this point
Copy the full SHA f9bd854View commit details -
Fix an NPE on long press in landscape
This could happen if the coordinates weren't yet loaded (or failed to load).
Configuration menu - View commit details
-
Copy full SHA for c31d6ab - Browse repository at this point
Copy the full SHA c31d6abView commit details -
Fix a strange verify related crash on 4.0.x
There are no methods used by this class that are above minSdk, but it's still complaining. It works in debug and crashes on release, but this proguard line seems to fix it.
Configuration menu - View commit details
-
Copy full SHA for 1d61ac8 - Browse repository at this point
Copy the full SHA 1d61ac8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a002a60 - Browse repository at this point
Copy the full SHA a002a60View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34f43e8 - Browse repository at this point
Copy the full SHA 34f43e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3664aa6 - Browse repository at this point
Copy the full SHA 3664aa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8f2b2d - Browse repository at this point
Copy the full SHA a8f2b2dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 72d3613 - Browse repository at this point
Copy the full SHA 72d3613View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c4d2fd - Browse repository at this point
Copy the full SHA 6c4d2fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 187ecf9 - Browse repository at this point
Copy the full SHA 187ecf9View commit details -
Configuration menu - View commit details
-
Copy full SHA for df7b489 - Browse repository at this point
Copy the full SHA df7b489View commit details -
Configuration menu - View commit details
-
Copy full SHA for 86bd9a4 - Browse repository at this point
Copy the full SHA 86bd9a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0adcd0 - Browse repository at this point
Copy the full SHA f0adcd0View commit details -
This happens when the audio fragment comes back in place of the tags one - this is rare and not the typical case, so added a check to deal with it gracefully.
Configuration menu - View commit details
-
Copy full SHA for 19bc477 - Browse repository at this point
Copy the full SHA 19bc477View commit details -
Protect against null bookmarks or tags
This can likely happen when the json data is malformed (i.e. doesn't contain a tags field or a bookmarks field), but protect against it anyway.
Configuration menu - View commit details
-
Copy full SHA for cf2f734 - Browse repository at this point
Copy the full SHA cf2f734View commit details -
Protect against a crash when toggling bookmark
This happens if start is null, which can happen if the item was deselected.
Configuration menu - View commit details
-
Copy full SHA for 8d0d6a1 - Browse repository at this point
Copy the full SHA 8d0d6a1View commit details
Commits on Jan 29, 2017
-
Fix copying and sharing being broken
This was due to a really bad bug where the database handler for the Arabic database would always (unconditionally) return null.
Configuration menu - View commit details
-
Copy full SHA for 7fdac92 - Browse repository at this point
Copy the full SHA 7fdac92View commit details -
Option to minimize the recents list
Some people complained about the three entries. This adds a list to the filter to be able to turn these off and only have one recent entry.
Configuration menu - View commit details
-
Copy full SHA for 7581262 - Browse repository at this point
Copy the full SHA 7581262View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45acd51 - Browse repository at this point
Copy the full SHA 45acd51View commit details
Commits on Jan 30, 2017
-
Gracefully handle broken translation dbs
Previously, when any translation would fail, we'd show nothing. This fixes that problem.
Configuration menu - View commit details
-
Copy full SHA for ef87027 - Browse repository at this point
Copy the full SHA ef87027View commit details -
More explicit initialization of Crashlytics
Setting the disabled flag from here to true allows for builds without the disable crashlytics flag that also don't log to crashlytics.
Configuration menu - View commit details
-
Copy full SHA for 6ca4c4a - Browse repository at this point
Copy the full SHA 6ca4c4aView commit details
Commits on Feb 1, 2017
-
May Allah reward brother Abdul-Raqeeb for these!
Configuration menu - View commit details
-
Copy full SHA for b3ed33c - Browse repository at this point
Copy the full SHA b3ed33cView commit details
Commits on Feb 3, 2017
-
11
Configuration menu - View commit details
-
Copy full SHA for 124a771 - Browse repository at this point
Copy the full SHA 124a771View commit details
Commits on Feb 8, 2017
-
Sometimes, the translation was repeated in the inline view. This happened whenver there was more than one translation (even when one of them was broken). Fixes quran#789.
Configuration menu - View commit details
-
Copy full SHA for 31ed526 - Browse repository at this point
Copy the full SHA 31ed526View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab0f855 - Browse repository at this point
Copy the full SHA ab0f855View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02c953d - Browse repository at this point
Copy the full SHA 02c953dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdce299 - Browse repository at this point
Copy the full SHA cdce299View commit details -
Temporarily disable translated names for German
Disable translations of sura names for German until the sura list can better handle long translation names.
Configuration menu - View commit details
-
Copy full SHA for 050f730 - Browse repository at this point
Copy the full SHA 050f730View commit details
Commits on Feb 10, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 4f9a28d - Browse repository at this point
Copy the full SHA 4f9a28dView commit details
Commits on Feb 28, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 7c77aca - Browse repository at this point
Copy the full SHA 7c77acaView commit details
Commits on Mar 15, 2017
-
Correcting a small type in surah name (quran#815)
Yas Sin corrected to Ya-Sin
Configuration menu - View commit details
-
Copy full SHA for 26112fe - Browse repository at this point
Copy the full SHA 26112feView commit details
Commits on Mar 19, 2017
-
Configuration menu - View commit details
-
Copy full SHA for ac14e36 - Browse repository at this point
Copy the full SHA ac14e36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 37ec98d - Browse repository at this point
Copy the full SHA 37ec98dView commit details -
Configuration menu - View commit details
-
Copy full SHA for debc6d4 - Browse repository at this point
Copy the full SHA debc6d4View commit details
Commits on Mar 20, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 441e8e9 - Browse repository at this point
Copy the full SHA 441e8e9View commit details -
This reverts commit debc6d4. # Conflicts: # app/src/main/res/values/strings.xml
Configuration menu - View commit details
-
Copy full SHA for 1012c02 - Browse repository at this point
Copy the full SHA 1012c02View commit details -
بعض التّعديلات في برنامجكم القيّم وفّقكم الله في جزئية (مساعدة) مثل التّاء المربوطة وهمزات الوصل والقطع
Configuration menu - View commit details
-
Copy full SHA for 6774d91 - Browse repository at this point
Copy the full SHA 6774d91View commit details -
Configuration menu - View commit details
-
Copy full SHA for 52bbbba - Browse repository at this point
Copy the full SHA 52bbbbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for d99f2f7 - Browse repository at this point
Copy the full SHA d99f2f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d67f2e - Browse repository at this point
Copy the full SHA 2d67f2eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d026351 - Browse repository at this point
Copy the full SHA d026351View commit details -
This patch introduces a warsh flavor for the app (see quran#629).
Configuration menu - View commit details
-
Copy full SHA for 839f8a5 - Browse repository at this point
Copy the full SHA 839f8a5View commit details
Commits on Mar 27, 2017
-
Configuration menu - View commit details
-
Copy full SHA for e78a23b - Browse repository at this point
Copy the full SHA e78a23bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 784f664 - Browse repository at this point
Copy the full SHA 784f664View commit details