Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advance search - Do not Merge #833

Open
wants to merge 1,588 commits into
base: main
Choose a base branch
from
Open
This pull request is big! We’re only showing the most recent 250 commits.

Commits on Jul 5, 2016

  1. Initial support for Shemerly pages

    This is an initial version that works, but has a few issues. Please see quran#665
    for further discussion.
    ahmedre committed Jul 5, 2016
    Configuration menu
    Copy the full SHA
    5ba6c51 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6717402 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2016

  1. Update strings.xml for Indonesian language (quran#669)

    Replaced several english words that are commonly used by indonesian users for corresponding indonesian language words that are equally commonly used or are getting popular, such as "Unduh" for Download and "Berkas" for File.
    
    Rephrasing and redactional changes to current indonesian translation to reflect the more exact meaning of the english prompts and directions.
    
    Re-order strings in indonesian translation to the same order as the english. Complete all string translations which were not translated in previous file.
    habibr authored and ahmedre committed Jul 21, 2016
    Configuration menu
    Copy the full SHA
    d1a7c4e View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2016

  1. Cleaning up strings.xml

    removed should-not-be-translated xml entries
    habibr authored and ahmedre committed Jul 23, 2016
    Configuration menu
    Copy the full SHA
    90f119e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3133b9a View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2016

  1. Updated my username (quran#677)

    ajsb85 authored and ahmedre committed Aug 20, 2016
    Configuration menu
    Copy the full SHA
    2b7ce96 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2016

  1. Configuration menu
    Copy the full SHA
    996d82b View commit details
    Browse the repository at this point in the history
  2. Attempt to make the db directory before writing

    When saving the translations.cache file, if the directory didn't exist,
    we'd throw an exception (which we'd silently catch). We can fix this by
    running mkdirs on the parent first, which is the correct thing to do in
    this case.
    ahmedre committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    4431d8c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    58e2ecf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    56a7b4b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6d90aa4 View commit details
    Browse the repository at this point in the history
  6. Build against Nougat

    This updates Quran to build against Android N, and updates the support
    libraries. As a result of this, the Spinner implementation changed
    again, thus breaking our mirrored version. This patch thus reimplements
    SpinnerCompat as a subclass of the newest AppCompatSpinner, while
    overriding the correct methods to make sure the dropdown width is
    correct.
    ahmedre committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    01f1caa View commit details
    Browse the repository at this point in the history
  7. Bump build tools version

    ahmedre committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    985e1fb View commit details
    Browse the repository at this point in the history
  8. Update travis for Android N

    ahmedre committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    6924726 View commit details
    Browse the repository at this point in the history
  9. Fix travis (quran#680)

    Fix travis by explicitly using jdk8
    ahmedre committed Sep 1, 2016
    Configuration menu
    Copy the full SHA
    6bcffd2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a008e67 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2016

  1. Update code styles for Quran

    These new code styles are based off of the Square Android and Google
    code styles, with some minor modifications. The biggest, most notable
    change is dropping Hungarian notation. This change should be done
    incrementally as old files are being cleaned up and refactored.
    ahmedre committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    28095b7 View commit details
    Browse the repository at this point in the history
  2. Better support for multi-window mode on Android N

    Quran actually worked pretty well with multi-window mode, minus one
    issue - toggling the ToolBar wasn't working. This is due to the fact
    that in multi-window mode, "apps cannot hide the status bar."
    
    This mostly fixes quran#679, with the exception of the fact that the status
    bar still overlays the page in multi-window mode. While this itself can't
    be fixed (because "apps cannot hide the status bar if they are not running
    in full-screen mode"), it should be possible, in the future, to drop
    Quran out of full screen mode when in multi-window mode.
    ahmedre committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    f900472 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    94cd6b9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    828e744 View commit details
    Browse the repository at this point in the history
  5. Replace NAVIGATION_MODE_LIST with Spinner

    The ActionBar navigation modes have been deprecated for a while now.
    Consequently, this patch migrates to embedding a Spinner in the ToolBar
    and toggling that instead.
    
    Furthermore, it also begins to reuse the spinner adapter for the
    translations list instead of making a new one every time.
    ahmedre committed Sep 2, 2016
    Configuration menu
    Copy the full SHA
    5a7ae75 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2016

  1. Update android plugin to rc1

    ahmedre committed Sep 3, 2016
    Configuration menu
    Copy the full SHA
    76ffff8 View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2016

  1. Fix gradient for tablet landscape with two pages

    The gradient was being generated with the width of the screen. When
    we're on a tablet and showing two pages, we should use half the width
    for each gradient instead.
    ahmedre committed Sep 4, 2016
    Configuration menu
    Copy the full SHA
    f580928 View commit details
    Browse the repository at this point in the history
  2. Manually draw borders in QuranPageLayout

    This patch replaces the ImageViews for the left and right borders with
    drawables that are shared between pages and are just drawn on the
    canvas.
    
    This patch also switches QuranPageLayout to be a custom ViewGroup instead
    of a subclass of FrameLayout, since later on, we'll want to move the
    drawing of the page header and footer text here.
    ahmedre committed Sep 4, 2016
    Configuration menu
    Copy the full SHA
    15c8bed View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2016

  1. Update FragmentStatePagerAdapter

    This also removes two of the catch exception blocks since upstream fixes
    likely make them unnecessary.
    ahmedre committed Sep 5, 2016
    Configuration menu
    Copy the full SHA
    b965669 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d3541c3 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2016

  1. Remove old fragment types on orientation change

    This patch introduces a "mode" that is passed to
    FragmentStatePagerAdapter, which determines whether we are in single or
    dual page mode. When switching from one to the other, remove all the
    fragments from FragmentManager since there is no reason to cache them.
    Fixes quran#681.
    ahmedre committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    5a03036 View commit details
    Browse the repository at this point in the history
  2. Greatly improve tablet orientation change

    This patch greatly improves tablet orientation change by making a few
    fixes - first, it stops the ViewPager from restoring its page number
    when the pages are different between portrait and landscape. Second, it
    stops calling setCurrentItem more than once. See quran#681 for further
    discussion.
    ahmedre committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    4993ff3 View commit details
    Browse the repository at this point in the history
  3. Don't delay removing window background on tablet

    Previously, we'd remove the window background immediately on phone, and
    we'd do so after some time on tablet. This makes both remove it
    immediately.
    ahmedre committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    a204370 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2016

  1. Configuration menu
    Copy the full SHA
    3a37651 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2016

  1. Configuration menu
    Copy the full SHA
    8f941a4 View commit details
    Browse the repository at this point in the history
  2. Fix seekbar indentation

    ahmedre committed Sep 15, 2016
    Configuration menu
    Copy the full SHA
    93508e6 View commit details
    Browse the repository at this point in the history
  3. Make seekbar preference consistent with prefs

    On Lollipop and above, the seekbar preference was misindented (and had
    the incorrect text size) when compared to the remaining items. This
    patch fixes this. In the future, these preferences should be replaced
    with something else (i.e. to make it easier to see the effects of the
    adjustment instead of just having a meaningless number for size or
    brightness).
    ahmedre committed Sep 15, 2016
    Configuration menu
    Copy the full SHA
    14869ba View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2016

  1. Reformat AndroidManifest

    ahmedre committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    034a89e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2af353d View commit details
    Browse the repository at this point in the history
  3. Improve header and footer text display

    Previously, the header and footer were drawn completely according to
    where the bounds of the page were (so as to not take extra space). This
    is problematic in many places (especially in landscape), because ayah
    headers aren't part of the database (and even if they were, they're at
    the very top of the screen anyway) - consequently, the text overlays
    them. This patch draws text at a fixed height (and pads the view to make
    space for the text).
    ahmedre committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    9f91631 View commit details
    Browse the repository at this point in the history
  4. Set page padding early on

    Set the page padding right away (instead of waiting until information
    about the coordinates of the items on the page loads). This stops the
    jumping of the page when pages are quickly changed.
    ahmedre committed Sep 16, 2016
    Configuration menu
    Copy the full SHA
    cf41f78 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2016

  1. Separate header font size from height

    This fixes naskh, where, without doing this, the text touches the border
    that surrounds the screen.
    ahmedre committed Sep 17, 2016
    Configuration menu
    Copy the full SHA
    b94f1b6 View commit details
    Browse the repository at this point in the history
  2. Update support lib to 24.2.1

    ahmedre committed Sep 17, 2016
    Configuration menu
    Copy the full SHA
    14ed90a View commit details
    Browse the repository at this point in the history
  3. Bump version to 2.7.2

    Also bump Qaloon and Naskh to 1.0.5. Note that there seems to have been
    a regression in the support library, that, on Lollipop and below, causes
    the toolbar's back arrow to point in the wrong direction with Arabic.
    However, will still go ahead and release this.
    ahmedre committed Sep 17, 2016
    Configuration menu
    Copy the full SHA
    f30eb1d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2016

  1. Configuration menu
    Copy the full SHA
    b92e508 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2016

  1. Viewing new rub3 permenantly instead of just poping it up (quran#687)

    Ahmed Abdelaal authored and ahmedre committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    415569b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f70a60f View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2016

  1. Configuration menu
    Copy the full SHA
    3434a3f View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2016

  1. Configuration menu
    Copy the full SHA
    0108af8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    65f7c37 View commit details
    Browse the repository at this point in the history
  3. Add an import option to settings

    Many people have complained about not being to import. This patch adds
    an actual import preference, which just fires off an ACTION_GET_CONTENT
    intent. On Kitkat and above, the Storage Access Framework gives people
    the option to import from applications that are document providers (ex
    Dropbox, Google Drive, etc). On older devices, this usually offers a
    file picker as an option. Fixes quran#634.
    ahmedre committed Nov 15, 2016
    Configuration menu
    Copy the full SHA
    7e85df8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    55642dc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1429289 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2016

  1. Make certain headers not clickable and cleanup

    Make the headers for "Current Page", "Page Bookmarks", and "Not Tagged"
    not clickable (since they do nothing when clicked or long clicked).
    Clean up some code.
    ahmedre committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    03e0313 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    54ea278 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2016

  1. Cleanup and some lint fixes

    ahmedre committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    a6f6f36 View commit details
    Browse the repository at this point in the history
  2. More lint fixes

    ahmedre committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    a7fd642 View commit details
    Browse the repository at this point in the history
  3. Fix explicit LTR hardcodes for lint

    Most of these LTR hardcodes are needed for supporting pre-api 17. To fix
    this, split out layout-ar and layout-ar-v17, with the latter being an
    exact copy of the respective files from layout.
    
    Some of the other cases (the various ViewPager indicators) actually
    always receive data in the correct order, so they need to be LTR. These
    cases have been placed in the code instead. It should be possible to
    remove  some of these explicit layout direction attributes in the
    future after some additional work.
    ahmedre committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    2261605 View commit details
    Browse the repository at this point in the history
  4. Fix QuranSpinner dropdown width

    In cases when the calculated dropdown width is less than the width of
    the actual spinner, use that width as the dropdown width. This stops
    certain sura names from being cut off.
    ahmedre committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    376360f View commit details
    Browse the repository at this point in the history
  5. editorconfig

    adding an .editorconfig file to the repo so that new contributors will automatically have their formatting setup correctly.
    
    It's built into Android Studio. Settings->Editor->Code Style then Check "Enable EditorConfig".
    hafah committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    b721c07 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2016

  1. [f] .editorconfig to use spaces on all files

    The .editorconfig used to adress .java and .sh solely. Since the code style guide says that
    2 spaces is used throughout the project. I've changed .editorconfig to use 2 spaces throughout
    the project.
    hafah committed Nov 22, 2016
    Configuration menu
    Copy the full SHA
    e90bfa3 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2016

  1. Configuration menu
    Copy the full SHA
    ec85297 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e8d1f26 View commit details
    Browse the repository at this point in the history
  3. Re-enable lint for ci and release

    This also makes "missing translations" a warning instead of an error.
    ahmedre committed Nov 23, 2016
    Configuration menu
    Copy the full SHA
    7dfaf10 View commit details
    Browse the repository at this point in the history
  4. Cleanup README

    ahmedre committed Nov 23, 2016
    Configuration menu
    Copy the full SHA
    8316798 View commit details
    Browse the repository at this point in the history
  5. Merge pull request quran#706 from hafah/patch-1

    .editorconfig
    ahmedre committed Nov 23, 2016
    Configuration menu
    Copy the full SHA
    0e39439 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2016

  1. License code under GPLv3

    Fixes quran#434.
    ahmedre committed Nov 24, 2016
    Configuration menu
    Copy the full SHA
    694d81f View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2016

  1. Support continuous indentation in editorconfig

    This is supported by Android Studio and IntelliJ and is important for
    keeping consistency with the existing code style.
    ahmedre committed Nov 25, 2016
    Configuration menu
    Copy the full SHA
    3f27a74 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2016

  1. Configuration menu
    Copy the full SHA
    c389dd8 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2016

  1. Minor code cleanup

    ahmedre committed Nov 27, 2016
    Configuration menu
    Copy the full SHA
    9133548 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    45c3f56 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2016

  1. Implement recent pages

    This implements recent pages for Quran (using similar behavior to Quran
    for iOS). A table of recent pages now exists within the bookmarks
    database. Whenever a Quran page is selected, it is added to the table.
    When the page changes, the new page replaces the old one in recents. The
    recents table currently maintains a maximum of 3 items. Fixes quran#691.
    ahmedre committed Nov 28, 2016
    Configuration menu
    Copy the full SHA
    d4ab0e6 View commit details
    Browse the repository at this point in the history
  2. Remove RxPreferences

    RxPreferences was used for listening to changes on the last page. Now
    that this code has changes, this is no longer needed. Will consider
    adding it back in the future if needed insha'Allah.
    ahmedre committed Nov 28, 2016
    Configuration menu
    Copy the full SHA
    4bb1a29 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    18b7820 View commit details
    Browse the repository at this point in the history
  4. Split advanced setting options into a new activity with new fragment …

    …and clean up all calsses
    mohamed committed Nov 28, 2016
    Configuration menu
    Copy the full SHA
    11a6213 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3ed03af View commit details
    Browse the repository at this point in the history
  6. Use same text as in the menu to jump last page

    This is to have a consistent UI text accross the app.
    When there is only one recently read page, the title will be
    the same as the jump menu title in the action bar.
    ozbek committed Nov 28, 2016
    Configuration menu
    Copy the full SHA
    10d8732 View commit details
    Browse the repository at this point in the history

Commits on Nov 29, 2016

  1. Merge pull request quran#713 from ozbek/master

    Use recent pages size to correctly get quantity string
    ahmedre committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    cff725e View commit details
    Browse the repository at this point in the history
  2. Merge pull request quran#715 from ozbek/i18n

    Use same text as in the menu to jump last page
    ahmedre committed Nov 29, 2016
    Configuration menu
    Copy the full SHA
    7a2b5c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    be1f836 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2016

  1. Merge pull request quran#714 from mhussien86/master

    Split setting screen into options and advanced options issue  quran#704
    ahmedre committed Nov 30, 2016
    Configuration menu
    Copy the full SHA
    cb566e1 View commit details
    Browse the repository at this point in the history
  2. Add translation for "Recent pages" (quran#716)

    Add translation for "Recent pages"
    ozbek authored and ahmedre committed Nov 30, 2016
    Configuration menu
    Copy the full SHA
    9ab16a4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5f5be49 View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2016

  1. Avoid an extra delete when it's not needed

    When updating recent pages, we often delete entries, add a new one, and
    then prune the list to make sure there are no more than 3 entries. If
    our first delete caused us to delete at one row, we don't have to delete
    again.
    ahmedre committed Dec 4, 2016
    Configuration menu
    Copy the full SHA
    d698172 View commit details
    Browse the repository at this point in the history
  2. Improve Recent pages implementation

    Previously, recent pages was doing a database query every time a page
    changed in order to update the recent pages table. This patch cleans
    this up by batching update information and only writing to the database
    in onPause.
    
    It also provides a much cleaner implementation for getting the last page.
    Previously, getting the last page meant getting recents and then
    returning the last page. This implementation adds an Observable with the
    very latest last page seen (even if it hasn't been committed to the
    database yet). This observable is prepopulated with the most recent page
    from the database and thereafter never depends on the database.
    
    This patch also refactors recent pages out into a RecentPageModel and
    adds unit tests for it. A RecentPagePresenter is also added to begin
    the process of decoupling business logic from PagerActivity.
    ahmedre committed Dec 4, 2016
    Configuration menu
    Copy the full SHA
    c5f41da View commit details
    Browse the repository at this point in the history
  3. Fix broken unit test (quran#720)

    The unit test called a method that called onNext on a subject. This
    subject was subscribed to as an observable to do some extra work, but
    was doing this work on an io thread. The bug was that the unit test was
    doing the checks before the code that was supposed to run on the io
    thread ran (since the unit test itself is synchronous unless we
    explicitly wait for something). The fix is to explicitly wait for the
    observable to get an event, thereby letting us know that the code was
    executed, before checking that the right things were called.
    ahmedre committed Dec 4, 2016
    Configuration menu
    Copy the full SHA
    fd54461 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2016

  1. RxJava2 (quran#724)

    ahmedre committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    d63eb85 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    921861e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1623625 View commit details
    Browse the repository at this point in the history
  4. Update libraries

    This updates most of the libraries to the latest version.
    Ahmed El-Helw authored and Ahmed El-Helw committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    cc1a0bd View commit details
    Browse the repository at this point in the history
  5. Use the gradle plugin's annotation processing

    Android gradle plugin 2.2 and above support annotation processors, so
    switching to those instead of android-apt.
    Ahmed El-Helw authored and Ahmed El-Helw committed Dec 7, 2016
    Configuration menu
    Copy the full SHA
    9e676be View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2016

  1. Configuration menu
    Copy the full SHA
    a02ed53 View commit details
    Browse the repository at this point in the history
  2. Use Retrolambda (quran#729)

    ahmedre committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    2a5be81 View commit details
    Browse the repository at this point in the history
  3. Upgrade gradle to 2.2.3 and update README

    ahmedre authored and Ahmed El-Helw committed Dec 9, 2016
    Configuration menu
    Copy the full SHA
    8470d98 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2016

  1. Settings: remove advanced options category, move volume key navigation (

    quran#731)
    
    * Remove "Advanced options" category
    
    As we are using a separate screen and have "Advanced options" in the title, the category seems redundant. Also move volume key navigation to reading prefs category.
    ozbek authored and ahmedre committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    1cf56b7 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2016

  1. Configuration menu
    Copy the full SHA
    15fc948 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    06a5fb8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    64ce460 View commit details
    Browse the repository at this point in the history
  4. Failing tests should show stack trace

    Some flakey tests are only failing on Travis. This change should help us
    identify why the failures happen.
    Ahmed El-Helw authored and Ahmed El-Helw committed Dec 12, 2016
    Configuration menu
    Copy the full SHA
    327ec36 View commit details
    Browse the repository at this point in the history
  5. Minor test cleanup

    ahmedre committed Dec 12, 2016
    Configuration menu
    Copy the full SHA
    3432fde View commit details
    Browse the repository at this point in the history
  6. Support shortcuts on 7.1 and certain launchers

    Android 7.1 supports app shortcuts natively (as do some launchers, even
    on pre-7.1 versions). This patch supports a shortcut for jumping to the
    most recent page.
    ahmedre committed Dec 12, 2016
    Configuration menu
    Copy the full SHA
    a5187d5 View commit details
    Browse the repository at this point in the history
  7. Fix lint issues with java 8

    Lint fails on java 8 syntax, so use android-retrolambda-lombok to work
    around this issue.
    ahmedre committed Dec 12, 2016
    Configuration menu
    Copy the full SHA
    95f5394 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2016

  1. Configuration menu
    Copy the full SHA
    66a02e1 View commit details
    Browse the repository at this point in the history
  2. Update gradle version to 3.2

    ahmedre committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    33c0d24 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6cb3274 View commit details
    Browse the repository at this point in the history
  4. Refactoring for Dagger Application modules

    This patch moves ApplicationComponent and ApplicationModule into an
    application package. It also splits up ApplicationModule into smaller
    modules (Network and Database).
    ahmedre committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    e169fe8 View commit details
    Browse the repository at this point in the history
  5. Support Stetho network interceptor for debug

    This patch adds a separate component for Debug, which overrides the
    NetworkModule with the debug module (that enables the network
    interceptor for Stetho).
    ahmedre committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    ca35a1a View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2016

  1. Fix regression in Audio manager

    RxJava 2 does not allow null returns. Some of the audio manager
    observables were returning null in some cases. This cleans it up and
    fixes quran#738.
    ahmedre committed Dec 14, 2016
    Configuration menu
    Copy the full SHA
    d84fadf View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2016

  1. Configuration menu
    Copy the full SHA
    2987bbf View commit details
    Browse the repository at this point in the history
  2. Remember the last reading mode (quran#736)

    This will enable going back to translation mode
    when jump to last page is selected from the action bar.
    
    Fix quran#530.
    ozbek authored and ahmedre committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    9dafc94 View commit details
    Browse the repository at this point in the history
  3. Fix flakey recent page model test

    The testUpdateLatestPageWithSlowRecents test was flakey - it is intended
    to ensure that if somehow, a person got to a page before the data came
    back from the database, that we'd disregard the database data in this
    case and use the person's pages instead.
    
    This change makes the test deterministic by artificially delaying the
    recent pages result, and only advancing the time after a page is
    emitted.
    ahmedre committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    24ceb11 View commit details
    Browse the repository at this point in the history
  4. Fix flakey TagBookmarkPresenter tests

    Many of the tag bookmark presenter tests were flakey because we didn't
    really know when async operations were complete. This fixes the problem
    by moving all the work done after the async process to a method, which
    the test then overrides to know when the async operation is complete.
    ahmedre committed Dec 15, 2016
    Configuration menu
    Copy the full SHA
    4b5ea3f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f26a5c1 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2016

  1. Fix force close in non-Madani build types (quran#739)

    That's caused by 2987bbf because
    advanced settings intent was hard coded in xml.
    
    This also adds a summary to advanced settings preference.
    ozbek authored and ahmedre committed Dec 18, 2016
    Configuration menu
    Copy the full SHA
    c77f05f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1c626bb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    526e1ca View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b69d578 View commit details
    Browse the repository at this point in the history
  5. Minor code cleanup

    ahmedre committed Dec 18, 2016
    Configuration menu
    Copy the full SHA
    704906a View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2016

  1. Configuration menu
    Copy the full SHA
    173de03 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2016

  1. Remove unnecessary arg in AudioUtils.getQariUrl() (quran#744)

    Apparently, getQariUrl() is called with `true` as the second argument everywhere.
    ozbek authored and ahmedre committed Dec 21, 2016
    Configuration menu
    Copy the full SHA
    62ce52d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a93b2d9 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2016

  1. Use static provides methods

    Static provides methods generate more efficient code in Dagger 2.
    ahmedre committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    d75b62d View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2016

  1. Implement initial TranslationPresenter

    This translation presenter is intended to replace TranslationTask.
    ahmedre committed Dec 23, 2016
    Configuration menu
    Copy the full SHA
    693aaa9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    60eecf6 View commit details
    Browse the repository at this point in the history
  3. Use TranslationPresenter in inline translation

    This also refactors the code in TranslationPresenter to mostly be in an
    abstract parent class, so that most of the code can be cleanly shared
    between InlineTranslationPresenter and TranslationPresenter.
    ahmedre committed Dec 23, 2016
    Configuration menu
    Copy the full SHA
    641be8c View commit details
    Browse the repository at this point in the history
  4. Support page number for TranslationPresenter

    Update AbstractTranslationPresenter to allow for any callback type, so
    that inline translations can just have a no-parameter callback, whereas
    the one for page translations can also receive a page parameter in the
    callback (which will be useful for tablet soon insha'Allah).
    ahmedre committed Dec 23, 2016
    Configuration menu
    Copy the full SHA
    3e7f665 View commit details
    Browse the repository at this point in the history
  5. Use TranslationPresenter in TabletFragment

    This also allows the removal of TranslationTask, since it is no longer
    being used.
    ahmedre committed Dec 23, 2016
    Configuration menu
    Copy the full SHA
    7b479c0 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    64dc4a9 View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2016

  1. Split image response callback into an interface

    Instead of re-using AyahTracker, split out the image callback to a new
    interface since it's only relevant when showing images. This will likely
    end up being removed when QuranPageWorker is switched to use RxJava.
    ahmedre committed Dec 24, 2016
    Configuration menu
    Copy the full SHA
    0faccc1 View commit details
    Browse the repository at this point in the history
  2. Add a provider for providing and caching ayahinfo

    Instead of the previous way, where PagerActivity would attempt to get a
    handle to the database and cache it forever (to be shared by the pages),
    this patch moves the logic to an AyahInfoDatabaseProvider instead.
    ahmedre committed Dec 24, 2016
    Configuration menu
    Copy the full SHA
    09e7550 View commit details
    Browse the repository at this point in the history

Commits on Dec 25, 2016

  1. Share some common code between phone and tablet

    There is a lot of replicated code between tablet and the Quran page -
    certain tasks are common between the two (fetching bookmarks, page
    bounds, and ayah bounds). This patch adds a QuranPagePresenter and
    starts moving the common code into it.
    ahmedre committed Dec 25, 2016
    Configuration menu
    Copy the full SHA
    ba3ce63 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2016

  1. Share more code between Quran and Tablet

    This diff moves most of the "ayah tracking" code (highlighting and
    unhighlighting of ayahs, getting the ayah at a position, etc) into a
    shared presenter to be used by both QuranPageFragment and
    TabletFragment. The fragment has to specify an array of its pages, and
    any command is then given to each page to handle it depending on its
    page type.
    
    This greatly simplifies the existing tablet code, which historically was
    very similar to the phone code, with the exception of a check for which
    page to map a command to. The fact that its shared means that Quran and
    Tablet can now have similar experiences (without double the effort).
    ahmedre committed Dec 26, 2016
    Configuration menu
    Copy the full SHA
    06b3f93 View commit details
    Browse the repository at this point in the history
  2. Change the order or page load operations

    Make the ayah coordinates load after the page coordinates and before the
    bookmarks (since bookmarks can't be shown without ayah coordinates).
    Also decrease the amount of time to wait before starting to fetch the
    page coordinates.
    ahmedre committed Dec 26, 2016
    Configuration menu
    Copy the full SHA
    095bb02 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    dc22989 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2016

  1. Configuration menu
    Copy the full SHA
    98af861 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    959559b View commit details
    Browse the repository at this point in the history
  3. Only try to re-download images if download failed

    Since bind may be called multiple times, only try to re-fetch the images
    if they weren't fetched the first time around.
    ahmedre committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    0001768 View commit details
    Browse the repository at this point in the history
  4. Improve handling of Arabic database

    The Arabic database is optional, and the file may not be there. Don't
    crash if it's not there, and try again if we failed to get it each time
    we ask for Arabic data.
    ahmedre committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    5845ad8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    5a19d8b View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cfebff1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    acfa46c View commit details
    Browse the repository at this point in the history
  8. Improve dependency injection structure

    Introduce two new Dagger scopes - ActivityScope and QuranPageScope.
    Also add two new components - a PagerActivityComponent, which is a
    submodule of ApplicationComponent for injecting PagerActivity, and a
    QuranPageComponent, which is a subcomponent of PagerActivityComponent,
    and can be used for injecting each QuranPage.
    ahmedre committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    07e8cc9 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    df5419d View commit details
    Browse the repository at this point in the history
  10. More DI related cleanup

    ahmedre committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    0721833 View commit details
    Browse the repository at this point in the history
  11. More efficient providing of application context

    A provider for a final variable shouldn't have an explicit @scope,
    because it doesn't need it (the underlying code with @scope will
    generate a double check provider to cache the value, when we know
    the value can't change because the variable is final).
    ahmedre committed Dec 27, 2016
    Configuration menu
    Copy the full SHA
    9e31ccc View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2016

  1. Support multiple pages in TranslationPresenter

    This patch updates TranslationPresenter to be able to deal with multiple
    pages. This allows tablet to use one TranslationPresenter that is shared
    between both the left and right pages (instead of one for the left page
    and one for the right one). This also uses Dagger to inject
    TranslationPresenters wherever they are needed.
    ahmedre committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    fa01026 View commit details
    Browse the repository at this point in the history
  2. Let TranslationModel be ActivityScope

    There's no reason to make a new TranslationModel for every single page
    of the ViewPager that we visit, so make it ActivityScope and inject it
    instead of manually making a new one every time.
    ahmedre committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    2f36074 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2016

  1. Only read intent if not saved instance state (quran#747)

    Because the code for reading values for the ViewPager always happened
    after checking saved instance state, the values there would override the
    saved instance state values. This fixes a bug where, upon opening a
    page, switching to the other mode, and switching a few pages, you'd go
    back to the mode you started in before switching (or, on tablet, it'd
    happen right away when switching from portrait to landscape).
    ahmedre committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    e372348 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2016

  1. Switch Translation Manager to RecyclerView (quran#745)

    * Added butterknife for view/resources injection
    
    * quran#709 - Switch Translation Manager to RecyclerView
    
    * quran#709 - fixed incorrect method name to match getter in TranslationAdapter
    
    * quran#709 - renamed TranslationAdapter to TranslationsAdapter
    
    * quran#709 - added ButterKnife to about screen
    
    * quran#709 - Cleaned up TranslationManagerActivity
    
    - Removed Hungarian notation
    - Removed unnecessary instanceof check
    
    * quran#709 - Cleaned up TranslationManagerActivity
    
    - Removed redundant LinearLayout in translation_manager
    
    * quran#709 - Cleaned up TranslationsAdapter
    
    - Changed PublishSubject ti UnicastSubject as there will only be one subscriber
    - Removed TextUtils static import
    - Cached recurring method calls
    hosainnet authored and ahmedre committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    2b4883e View commit details
    Browse the repository at this point in the history
  2. 709 Refactor translation manager (quran#749)

    * quran#709 - Dispose of UnicastSubject subscription in TranslationManagerActivity to prevent crash
    
    * quran#709 - TranslationsAdapter - refactored click listener to only be set once in ViewHolder's constructor
    hosainnet authored and ahmedre committed Dec 30, 2016
    Configuration menu
    Copy the full SHA
    97a52de View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2017

  1. Introduce functional tests (quran#756)

    * quran#750 - Added the Espresso functional testing library
    
    * quran#750 - Added base activity test class
    
    * quran#750 - Added basic test QuranActivityTest:
    
    - Click on Surah in list view an ensure it opens Surah by checking triggered intents
    - Removed unused code
    
    * quran#750 - Remove unnecessary new line in BaseActivityTest
    
    * quran#750 - Reset shared preferences at every test to ensure consistency
    
    * quran#750 - Refactored QuranActivityTest to work on all flavours
    
    * quran#750 - Renamed test in QuranActivityTest
    hosainnet authored and ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    d25aa60 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    819b3f5 View commit details
    Browse the repository at this point in the history
  3. Rename old TranslationView and clean it up

    Rename the old TranslationView to InlineTranslationView (used in the
    inline translation mode). Also remove all the unnecessary pieces.
    ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    80058d8 View commit details
    Browse the repository at this point in the history
  4. Fix indentation of colors

    ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    0d8f256 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    96dd6fe View commit details
    Browse the repository at this point in the history
  6. Improve ui for translations

    ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    f2ad855 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2c3eae1 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    f7b2fda View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ed144a6 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    120efe5 View commit details
    Browse the repository at this point in the history
  11. Improve TranslationPresenter

    Fix some bugs and cache the translation list instead of getting it on
    every single refresh call.
    ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    6a559c1 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    e756c33 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    cf7dc69 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    8dfdd6c View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    0277772 View commit details
    Browse the repository at this point in the history
  16. Use custom view for divider

    ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    f02b3ea View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    0a6572f View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    73b6877 View commit details
    Browse the repository at this point in the history
  19. Remove textIsSelectable for now

    Remove textIsSelectable for now because it doesn't work reliably when
    there's also an onClickListener on the same TextView.
    ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    e566aee View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    a740d16 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    5499c21 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    50c7508 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    0295a5a View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    3a1b303 View commit details
    Browse the repository at this point in the history
  25. Make updating highlights more efficient

    Pass in a change parameter to notifyItemRangeChanged so we only update
    the background instead of trying to update all the data. Also attempt to
    combine the two notifyItemRangeChanged calls when possible.
    ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    7118126 View commit details
    Browse the repository at this point in the history
  26. Fix text selection

    ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    0e83811 View commit details
    Browse the repository at this point in the history
  27. Support multiple translations

    This patch supports multiple translations, but doesn't expose any ui
    to be able to choose multiple translations to be viewed yet. It also
    will hide the translator label if there is only one translation.
    ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    2812d13 View commit details
    Browse the repository at this point in the history
  28. Fix translation name

    ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    a37f122 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    a8d8f6e View commit details
    Browse the repository at this point in the history
  30. Minor cleanup

    ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    faa1ad9 View commit details
    Browse the repository at this point in the history
  31. Support multiple translations

    Add a checkbox besides the translations, and allow selecting multiple
    translations at the same time.
    ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    be9b419 View commit details
    Browse the repository at this point in the history
  32. Don't use translation as spinner title

    For the full screen view, use a similar title and subtitle to Quran
    view. For the inline view, show "Translations" for now.
    ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    402fdc8 View commit details
    Browse the repository at this point in the history
  33. Fix build error (quran#761)

    Error log:
    
        Error:Conflict with dependency 'com.android.support:support-annotations' in
        project ':app'. Resolved versions for app (25.1.0) and test app (23.1.1)
        differ. See http://g.co/androidstudio/app-test-app-conflict for details.
    ozbek authored and ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    4868a82 View commit details
    Browse the repository at this point in the history
  34. change "Help wanted label" to "PRs Welcome" label (quran#762)

    Ahmed Abdelaal authored and ahmedre committed Jan 9, 2017
    Configuration menu
    Copy the full SHA
    0d1755a View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2017

  1. Update toolbar in translation view (quran#763)

    Apparently, translationItems will not have enough time to get populated in
    onCreate() when we try to update the toolbar with translation items.
    So, let's call updateActionBarSpinner() once we get translationItems updated.
    
    Fixes quran#757
    ozbek authored and ahmedre committed Jan 10, 2017
    Configuration menu
    Copy the full SHA
    0bfca2a View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2017

  1. Setup Travis CI (quran#764)

    hosainnet authored and ahmedre committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    9a5dbf6 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2017

  1. Remove QuranAyah (quran#767)

    QuranAyah was being used in many cases where SuraAyah should be used
    instead. This patch replaces all those instances and removes QuranAyah.
    ahmedre committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    7d74fb6 View commit details
    Browse the repository at this point in the history
  2. Invalidate NumberFormat when Locale changes

    Fixes quran#746. Because the callback would happen after the locale changed
    (but before the change was fully in effect), when switching from Arabic
    back to the default language, the app would make a new NumberFormat
    using the locale, which at that point, was still the Arabic locale. This
    causes Arabic numbers in between non-Arabic text on the main page.
    ahmedre committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    a42bf27 View commit details
    Browse the repository at this point in the history
  3. Minor updates to README

    ahmedre committed Jan 13, 2017
    Configuration menu
    Copy the full SHA
    2fe1fea View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8b4747d View commit details
    Browse the repository at this point in the history

Commits on Jan 14, 2017

  1. Configuration menu
    Copy the full SHA
    d7bd1d9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6f3d61d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2914fed View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2017

  1. Configuration menu
    Copy the full SHA
    a816cea View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2afab3d View commit details
    Browse the repository at this point in the history
  3. Update bookmarks & tags contextual action bar translation (quran#771)

    Add several translation lines for the bookmarks & tags bar which have not been added to the Indonesian strings.
    
    This might resolve the "weird translation" that pop up in the Bookmark bar for the recent pages.
    habibr authored and ahmedre committed Jan 16, 2017
    Configuration menu
    Copy the full SHA
    44469b5 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2017

  1. Create booleans.xml (quran#774)

    activating surah names translation for indonesian language
    habibr authored and ahmedre committed Jan 17, 2017
    Configuration menu
    Copy the full SHA
    1703cc5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa5c60b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d2805e9 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2017

  1. Configuration menu
    Copy the full SHA
    4e3265f View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2017

  1. Cleanup QuranFileUtils (quran#777)

    ozbek authored and ahmedre committed Jan 20, 2017
    Configuration menu
    Copy the full SHA
    ac55668 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2017

  1. Configuration menu
    Copy the full SHA
    6515cd4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aead639 View commit details
    Browse the repository at this point in the history
  3. Update crashlytics version

    ahmedre committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    7cf2fb6 View commit details
    Browse the repository at this point in the history
  4. Fix the exporting of data for debug build

    Due to the package name change, file_paths.xml also needs to change to
    reflect the correct directory.
    ahmedre committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    738cfdb View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cfdcf33 View commit details
    Browse the repository at this point in the history
  6. Fix exporting bookmarks often not working

    Exporting bookmarks often fails due to the thread being interrupted
    (when okio sees an interrupted thread, it throws an exception instead
    of flushing the sink during the sink.close() call). This resets the
    interrupted status on the thread so that exporting bookmarks works.
    ahmedre committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    eaba5c0 View commit details
    Browse the repository at this point in the history
  7. Use external-files-path instead of external-path (quran#780)

    Because, we are actually using `external-files-path` albeit in hard-coded way.
    This should now fix exporting data in all other build variants and flavors as well.
    ozbek authored and ahmedre committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    16d99ba View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2017

  1. Fix a crash when removing advanced preferences

    Certain advanced preferences (app location and logging) are removed when
    they are not available. This was causing a crash in the app. This patch
    fixes it.
    ahmedre committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    0a52e65 View commit details
    Browse the repository at this point in the history
  2. Replace missing Arabic string

    ahmedre committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    93ec669 View commit details
    Browse the repository at this point in the history
  3. Bump version to 2.7.3

    ahmedre committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    f9bd854 View commit details
    Browse the repository at this point in the history
  4. Fix an NPE on long press in landscape

    This could happen if the coordinates weren't yet loaded (or failed to
    load).
    ahmedre committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    c31d6ab View commit details
    Browse the repository at this point in the history
  5. Fix a strange verify related crash on 4.0.x

    There are no methods used by this class that are above minSdk, but it's
    still complaining. It works in debug and crashes on release, but this
    proguard line seems to fix it.
    ahmedre committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    1d61ac8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a002a60 View commit details
    Browse the repository at this point in the history
  7. Fix a few other crashes

    ahmedre committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    34f43e8 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3664aa6 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    a8f2b2d View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    72d3613 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    6c4d2fd View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    187ecf9 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    df7b489 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    86bd9a4 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    f0adcd0 View commit details
    Browse the repository at this point in the history
  16. Fix a class cast exception

    This happens when the audio fragment comes back in place of the tags
    one - this is rare and not the typical case, so added a check to deal
    with it gracefully.
    ahmedre committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    19bc477 View commit details
    Browse the repository at this point in the history
  17. Protect against null bookmarks or tags

    This can likely happen when the json data is malformed (i.e. doesn't
    contain a tags field or a bookmarks field), but protect against it
    anyway.
    ahmedre committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    cf2f734 View commit details
    Browse the repository at this point in the history
  18. Protect against a crash when toggling bookmark

    This happens if start is null, which can happen if the item was
    deselected.
    ahmedre committed Jan 28, 2017
    Configuration menu
    Copy the full SHA
    8d0d6a1 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2017

  1. Fix copying and sharing being broken

    This was due to a really bad bug where the database handler for the
    Arabic database would always (unconditionally) return null.
    ahmedre committed Jan 29, 2017
    Configuration menu
    Copy the full SHA
    7fdac92 View commit details
    Browse the repository at this point in the history
  2. Option to minimize the recents list

    Some people complained about the three entries. This adds a list to the
    filter to be able to turn these off and only have one recent entry.
    ahmedre committed Jan 29, 2017
    Configuration menu
    Copy the full SHA
    7581262 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    45acd51 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2017

  1. Gracefully handle broken translation dbs

    Previously, when any translation would fail, we'd show nothing. This
    fixes that problem.
    ahmedre committed Jan 30, 2017
    Configuration menu
    Copy the full SHA
    ef87027 View commit details
    Browse the repository at this point in the history
  2. More explicit initialization of Crashlytics

    Setting the disabled flag from here to true allows for builds without
    the disable crashlytics flag that also don't log to crashlytics.
    ahmedre committed Jan 30, 2017
    Configuration menu
    Copy the full SHA
    6ca4c4a View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2017

  1. Add Sura Names in German

    May Allah reward brother Abdul-Raqeeb for these!
    ahmedre committed Feb 1, 2017
    Configuration menu
    Copy the full SHA
    b3ed33c View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2017

  1. 11 Configuration menu
    Copy the full SHA
    124a771 View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2017

  1. Fix repeated translation

    Sometimes, the translation was repeated in the inline view. This
    happened whenver there was more than one translation (even when one of
    them was broken). Fixes quran#789.
    ahmedre committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    31ed526 View commit details
    Browse the repository at this point in the history
  2. Fix Arabic typos in About

    Fixes quran#795.
    ahmedre committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    ab0f855 View commit details
    Browse the repository at this point in the history
  3. Fix play button not working

    The bug was introduced in a8f2b2d,
    where the "next page" ayah was changed to use the previous page's ayah.
    This caused us to try to play a range of ayat with an end less than
    start, which caused nothing to play at all. This fixes quran#801.
    ahmedre committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    02c953d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    cdce299 View commit details
    Browse the repository at this point in the history
  5. Temporarily disable translated names for German

    Disable translations of sura names for German until the sura list can
    better handle long translation names.
    ahmedre committed Feb 8, 2017
    Configuration menu
    Copy the full SHA
    050f730 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2017

  1. Configuration menu
    Copy the full SHA
    4f9a28d View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2017

  1. GitHub username changed (quran#813)

    Ahmed9914 authored and ahmedre committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    7c77aca View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2017

  1. Correcting a small type in surah name (quran#815)

    Yas Sin corrected to Ya-Sin
    habibr authored and ahmedre committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    26112fe View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2017

  1. Configuration menu
    Copy the full SHA
    ac14e36 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    37ec98d View commit details
    Browse the repository at this point in the history
  3. test

    test about us 2
    humanities committed Mar 19, 2017
    Configuration menu
    Copy the full SHA
    debc6d4 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2017

  1. test 3

    about us 3
    nyitgroup committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    441e8e9 View commit details
    Browse the repository at this point in the history
  2. Revert "test"

    This reverts commit debc6d4.
    
    # Conflicts:
    #	app/src/main/res/values/strings.xml
    nyitgroup committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    1012c02 View commit details
    Browse the repository at this point in the history
  3. Fix issue quran#814

    بعض التّعديلات في برنامجكم القيّم وفّقكم الله في جزئية (مساعدة) مثل التّاء المربوطة وهمزات الوصل والقطع
    nyitgroup committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    6774d91 View commit details
    Browse the repository at this point in the history
  4. Fix Arabic about strings

    Fixes quran#814
    nyitgroup authored and ahmedre committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    52bbbba View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d99f2f7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    2d67f2e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d026351 View commit details
    Browse the repository at this point in the history
  8. Initial flavor for Warsh

    This patch introduces a warsh flavor for the app (see quran#629).
    ahmedre committed Mar 20, 2017
    Configuration menu
    Copy the full SHA
    839f8a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2017

  1. Configuration menu
    Copy the full SHA
    e78a23b View commit details
    Browse the repository at this point in the history
  2. Advance search

    add options for advanced search to seach activity
    nyitgroup committed Mar 27, 2017
    Configuration menu
    Copy the full SHA
    784f664 View commit details
    Browse the repository at this point in the history