Skip to content

check file meta hash before update #1537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025
Merged

check file meta hash before update #1537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions code/go/0chain.net/blobbercore/allocation/file_changer_update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,15 +121,16 @@ func (nf *UpdateFileChanger) ApplyChangeV2(ctx context.Context, allocationRoot,

//find if ref exists
var refResult struct {
ID int64
Type string
NumUpdates int64 `gorm:"column:num_of_updates" json:"num_of_updates"`
Size int64 `gorm:"column:size" json:"size"`
ID int64
Type string
NumUpdates int64 `gorm:"column:num_of_updates" json:"num_of_updates"`
Size int64 `gorm:"column:size" json:"size"`
FileMetaHash string `gorm:"column:file_meta_hash" json:"file_meta_hash"`
}

err := datastore.GetStore().WithNewTransaction(func(ctx context.Context) error {
tx := datastore.GetStore().GetTransaction(ctx)
return tx.Model(&reference.Ref{}).Select("id", "type", "num_of_updates", "size").Where("lookup_hash = ?", nf.LookupHash).Take(&refResult).Error
return tx.Model(&reference.Ref{}).Select("id", "type", "num_of_updates", "size", "file_meta_hash").Where("lookup_hash = ?", nf.LookupHash).Take(&refResult).Error
}, &sql.TxOptions{
ReadOnly: true,
})
Expand Down Expand Up @@ -187,9 +188,11 @@ func (nf *UpdateFileChanger) ApplyChangeV2(ctx context.Context, allocationRoot,
}
collector.DeleteRefRecord(deleteRecord)
collector.CreateRefRecord(newFile)
decodedKey, _ := hex.DecodeString(newFile.LookupHash)
decodedValue, _ := hex.DecodeString(newFile.FileMetaHash)
err = trie.Update(decodedKey, decodedValue, uint64(newFile.NumBlocks))
if newFile.FileMetaHash != refResult.FileMetaHash {
decodedKey, _ := hex.DecodeString(newFile.LookupHash)
decodedValue, _ := hex.DecodeString(newFile.FileMetaHash)
err = trie.Update(decodedKey, decodedValue, uint64(newFile.NumBlocks))
}
return refResult.Size - newFile.Size, err
}

Expand Down
Loading