-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added R-Shiny to the Front-End Development secion. #184
Conversation
@-grabear on 2017-09-27 22:27 says: grabear/awesome-rshiny#9 |
@-sindresorhus on 2017-10-21 18:50 says: Please read the guidelines more closely. Multiple points not followed from it. Try going through the list point for point and check that you follow it. :) |
@-ucg8j on 2017-10-27 09:26 says: Hi @-sindresorhus a number of changes have been made over the last couple of weeks, many to address the awesome guidelines. Would you be able to take another look at this PR and advise on any points we're still not meeting? |
@-sindresorhus on 2018-07-28 18:19 says: Hey, sorry for the lack of response, please see sindresorhus/awesome#1363. |
@-sindresorhus on 2018-09-18 19:16 says: @-grabear ⬆️ |
@-grabear on 2018-09-19 04:46 says: @-sindresorus I will try to lint this myself tomorrow and make some changes. Been busy! :) |
@-sindresorhus on 2019-02-26 05:24 says: Closing for lack of activity. The repo also has not been updated since mid last year. |
readme.md
Outdated
- [Hyperapp](https://github.com/hyperapp/awesome-hyperapp) - Tiny JavaScript library for building web apps. | ||
|
||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@-DanailMinchev on 2018-08-14 21:50 says: This line is not needed, please remove it
readme.md
Outdated
@@ -230,9 +230,11 @@ | |||
- [Preact](https://github.com/ooade/awesome-preact) - App framework. | |||
- [Progressive Enhancement](https://github.com/jbmoelker/progressive-enhancement-resources) | |||
- [Next.js](https://github.com/unicodeveloper/awesome-nextjs) - Framework for server-rendered React apps. | |||
- [R-Shiny](https://github.com/grabear/awesome-rshiny) - Web Framework built with R. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@-DanailMinchev on 2018-08-14 21:53 says: As per rules in https://github.com/sindresorhus/awesome/blob/master/pull_request_template.md#requirements-for-your-pull-request you should add the entry in the end of the category, so you need to add it after Hyperapp
readme.md
Outdated
@@ -230,9 +230,11 @@ | |||
- [Preact](https://github.com/ooade/awesome-preact) - App framework. | |||
- [Progressive Enhancement](https://github.com/jbmoelker/progressive-enhancement-resources) | |||
- [Next.js](https://github.com/unicodeveloper/awesome-nextjs) - Framework for server-rendered React apps. | |||
- [R-Shiny](https://github.com/grabear/awesome-rshiny) - Web Framework built with R. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@-DanailMinchev on 2018-08-14 22:01 says: also, you should add #readme
in the end of the link and make sure it is linked proprly
readme.md
Outdated
@@ -230,9 +230,11 @@ | |||
- [Preact](https://github.com/ooade/awesome-preact) - App framework. | |||
- [Progressive Enhancement](https://github.com/jbmoelker/progressive-enhancement-resources) | |||
- [Next.js](https://github.com/unicodeveloper/awesome-nextjs) - Framework for server-rendered React apps. | |||
- [R-Shiny](https://github.com/grabear/awesome-rshiny) - Web Framework built with R. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@-DanailMinchev on 2018-08-14 22:06 says: No need to specify the section name in your PR title, please rename it from Added R-Shiny to the Front-End Development secion.
to Add R-Shiny
readme.md
Outdated
@@ -230,9 +230,11 @@ | |||
- [Preact](https://github.com/ooade/awesome-preact) - App framework. | |||
- [Progressive Enhancement](https://github.com/jbmoelker/progressive-enhancement-resources) | |||
- [Next.js](https://github.com/unicodeveloper/awesome-nextjs) - Framework for server-rendered React apps. | |||
- [R-Shiny](https://github.com/grabear/awesome-rshiny) - Web Framework built with R. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@-DanailMinchev on 2018-08-14 22:06 says: please also rebase your PR as it has conflicts currently
Pull request from @grabear.
https://github.com/grabear/awesome-rshiny
This awesome list is a compilation of useful R-Shiny resources. R-shiny has been available for several years now, and has evolved into a highly useful package for Data Scientists who are not necessarily familiar with web development. It gives these scientist an opportunity to create great web application for their publications and affiliated institutions. Accepting this link into the Front End Development section will bring more awareness to the inherit usefulness of Shiny as a web framework.
By submitting this pull request I confirm I've read and complied with the below requirements.
Please read it multiple times. I spent a lot of time on these guidelines and most people miss a lot.
For example,
Add Name of List
, notUpdate readme.md
orAdd awesome list
.Example:
- [Fish](…) - User-friendly shell.
, not- [Fish](…) - Resources for Fish.
.That means 30 days from either the first real commit or when it was open-sourced. Whatever is most recent.
awesome-list
&awesome
as GitHub topics. I encourage you to add more relevant topics.Contents
, notTable of Contents
.contributing.md
. Casing is up to you.Example:
- [AVA](…) - JavaScript test runner.
A
/An
prefixes in the descriptions.Node.js
, notNodeJS
ornode.js
.You can still use Travis for list linting, but the badge has no value in the readme.