Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg(com.lenovo.ue.device): change description and removal #730

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

AnonymousWP
Copy link
Contributor

Fixes #713.

Copy link

@PhrozenByte PhrozenByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this package doesn't prompt a factory reset (i.e. deleting all user data), but rather a hardware reset (i.e. like pressing the on/off button for 10+ seconds) after unlocking the device. If USB debugging is still active you can safely reinstall the package and the device works again, but if USB debugging is disabled you might fail to do so - what leaves you no option but to perform an actual factory reset. I guess marking it as "unsafe" is better nevertheless.

Apart from that: LGTM

@@ -19730,11 +19730,11 @@
{
"id": "com.lenovo.ue.device",
"list": "Oem",
"description": "User Experience Program\nAnalytics stuff. Displays an annoying notification after every reboot prompting you to join this user experience program.",
"description": "User Experience Program\nAnalytics stuff. Displays an annoying notification after every reboot prompting you to join this user experience program.\nNOTE: removing this package may cause a factory reset, see:\nhttps://github.com/0x192/universal-android-debloater/issues/713.",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "User Experience Program\nAnalytics stuff. Displays an annoying notification after every reboot prompting you to join this user experience program.\nNOTE: removing this package may cause a factory reset, see:\nhttps://github.com/0x192/universal-android-debloater/issues/713.",
"description": "User Experience Program\nAnalytics stuff. Displays an annoying notification after every reboot prompting you to join Lenovo's user experience program.\nNOTE: removing this package may cause a hardware reset after unlocking the device, see:\nhttps://github.com/0x192/universal-android-debloater/issues/713.",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aahh okay, so you mean a hard reboot. When I hear people saying reset, I always think of a factory reset. Maybe we should also add what you said here:

If USB debugging is still active you can safely reinstall the package and the device works again, but if USB debugging is disabled you might fail to do so - what leaves you no option but to perform an actual factory reset.

If you can edit your suggestion, I'll commit your suggestion. 👍🏻

Copy link

@PhrozenByte PhrozenByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above 👍

Co-authored-by: Daniel Rudolf <github.com@daniel-rudolf.de>
Copy link

@PhrozenByte PhrozenByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removal of com.lenovo.ue.device causes system reset
2 participants