Feature: width argument to calculate scale from number of available columns
#6
Conversation
Will calculate scaling based on parameter-specified columns number.
|
Nice feature @giulio-Joshi, I Think it will be useful 鉂わ笍 |
|
I'm glad you liked the tool, And thanks to you for tests |
| /// Determine how much scale to use in presence of `width` parameters, | ||
| /// otherwise returns regular `scale` parameter per default behaviour | ||
| /// | ||
| fn calculate_scale(args: &Arguments, dimensions: (u32, u32)) -> u32 { |
There was a problem hiding this comment.
You can make this method as inline method using the #[inline] suggests, This will can provide small but easy speed win.
https://nnethercote.github.io/perf-book/inlining.html
There was a problem hiding this comment.
No problem, even if actually is called just once per run.
Could gain more performance if we read the image from a file, or from stdin (for better bash integration).
There was a problem hiding this comment.
I understand reading the image from a file, but what you mean with reading it from stdin?
There was a problem hiding this comment.
That would mean like how the -@ options works for zip program:
ls *.jpg | zip image_gallery.zip -@All *.jpg files get streamed to zip and each one gets added to image_gallery.zip
But that would mean changing some of the program parameters.
* Documentation consistency * Method inlining
|
Yes of course, changes incoming. |
Hello, its me again 馃槂
I'm using your converter and found myself in this situation: I wanted to
aartyzea bunch of pics from different size, all to an ascii file the same width.This feature come out naturally and gave the occasion of testing a small part of the code.
Do you think this could help you?