-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify main GitHub action to include other configurations and auto-generated changelog #830
Conversation
@Jasonstein @soumyamahunt these are all very beneficial improvements to the current versioning process, but before merging please wait for the PR with the automatic versioning for comparison, because the steps concerning the versioning are removed and replaced by a completely different implementation |
I have made this PR draft and will retarget it to the new automatic versioning PR once that becomes live. |
name: Bump GitHub tag | ||
id: tag_generator | ||
uses: mathieudutour/github-tag-action@v5 | ||
uses: soumyamahunt/github-tag-action@test-other-ver-support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this your own version of tag action?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was about to comment about this, I opened a PR in the action repo that will allow notepads to use the tag action without having to follow semver style tags. Currently I am keeping this for testing, but if the PR accepted we will follow the main repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jasonstein I have some suggestion about release strategy. Right now any push commit with the proper format triggers a release, the drawback of this is the changelog will only contain that specific commit and you will have to later modify changelog. What I want to propose is trigger release with
workflow_dispatch
event with an input, this way we can always follow the format for all commits and the changelog will be generated from appropriate commits without requiring you to modify anything later.
100% agreed.
@Jasonstein I have some suggestion about release strategy. Right now any push commit with the proper format triggers a release, the drawback of this is the changelog will only contain that specific commit and you will have to later modify changelog. What I want to propose is trigger release with |
@Jasonstein I have changed the release process, have a look on the documentations and let me know if I should change anything. |
Notepads CI/CD Pipeline
action to run for other configurations like oldbuild
action used to do. The conditions are adjusted so Sonarcloud only runs withProduction
configuration, while for bothDebug
andRelease
config only build is tested.PR Type
What kind of change does this PR introduce?
Feature