Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify main GitHub action to include other configurations and auto-generated changelog #830

Merged
merged 26 commits into from
Mar 29, 2021

Conversation

soumyamahunt
Copy link
Contributor

@soumyamahunt soumyamahunt commented Mar 25, 2021

  1. This PR makes the Notepads CI/CD Pipeline action to run for other configurations like old build action used to do. The conditions are adjusted so Sonarcloud only runs with Production configuration, while for both Debug and Release config only build is tested.
  2. Added auto generated changelog.
  3. Introduced ignoring execution with documentation or other unnecessary changes.

PR Type

What kind of change does this PR introduce?

Feature

@aleks-ivanov
Copy link
Contributor

@Jasonstein @soumyamahunt these are all very beneficial improvements to the current versioning process, but before merging please wait for the PR with the automatic versioning for comparison, because the steps concerning the versioning are removed and replaced by a completely different implementation

@soumyamahunt soumyamahunt marked this pull request as draft March 25, 2021 11:43
@soumyamahunt
Copy link
Contributor Author

@Jasonstein @soumyamahunt these are all very beneficial improvements to the current versioning process, but before merging please wait for the PR with the automatic versioning for comparison, because the steps concerning the versioning are removed and replaced by a completely different implementation

I have made this PR draft and will retarget it to the new automatic versioning PR once that becomes live.

@soumyamahunt soumyamahunt marked this pull request as ready for review March 27, 2021 07:40
@soumyamahunt soumyamahunt changed the title Modify main GitHub action to include other configurations and robust version checking Modify main GitHub action to include other configurations and auto-generated changelog Mar 27, 2021
name: Bump GitHub tag
id: tag_generator
uses: mathieudutour/github-tag-action@v5
uses: soumyamahunt/github-tag-action@test-other-ver-support
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this your own version of tag action?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to comment about this, I opened a PR in the action repo that will allow notepads to use the tag action without having to follow semver style tags. Currently I am keeping this for testing, but if the PR accepted we will follow the main repo.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jasonstein I have some suggestion about release strategy. Right now any push commit with the proper format triggers a release, the drawback of this is the changelog will only contain that specific commit and you will have to later modify changelog. What I want to propose is trigger release with workflow_dispatch event with an input, this way we can always follow the format for all commits and the changelog will be generated from appropriate commits without requiring you to modify anything later.

100% agreed.

@soumyamahunt
Copy link
Contributor Author

@Jasonstein I have some suggestion about release strategy. Right now any push commit with the proper format triggers a release, the drawback of this is the changelog will only contain that specific commit and you will have to later modify changelog. What I want to propose is trigger release with workflow_dispatch event with an input, this way we can always follow the format for all commits and the changelog will be generated from appropriate commits without requiring you to modify anything later.

@soumyamahunt
Copy link
Contributor Author

@Jasonstein I have changed the release process, have a look on the documentations and let me know if I should change anything.

@0x7c13 0x7c13 merged commit c90606b into 0x7c13:master Mar 29, 2021
@soumyamahunt soumyamahunt deleted the github-action branch March 29, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants