Skip to content

Conversation

liheji
Copy link
Contributor

@liheji liheji commented Aug 30, 2025

feat(notification): add support for Ntfy

  • Implement Ntfy external notifier in Go
  • Add Ntfy configuration component in Vue
  • Update language files with Ntfy translations- Register Ntfy notifier in the main application

Page effect:
ntfy通知01
ntfy通知02
result

@0xJacky 0xJacky requested a review from Copilot August 30, 2025 11:58
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for Ntfy as an external notification service. The implementation includes a Go backend notifier that handles Ntfy API communication and a Vue frontend configuration component for user setup.

  • Implement Ntfy external notifier with authentication support (Bearer token and Basic auth)
  • Add Vue configuration component for Ntfy settings
  • Update language files to include Ntfy translations

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 5 comments.

File Description
internal/notification/ntfy.go Core Ntfy notifier implementation with HTTP client and message formatting
app/src/views/preference/components/ExternalNotify/ntfy.ts Vue configuration component defining Ntfy settings form
app/src/views/preference/components/ExternalNotify/index.ts Register Ntfy config in the notification system
app/src/language/*/app.po Add "Ntfy" translation entries across all supported languages

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

0xJacky and others added 2 commits August 30, 2025 20:11
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@0xJacky 0xJacky merged commit 3335e60 into 0xJacky:dev Aug 30, 2025
21 checks passed
@0xJacky
Copy link
Owner

0xJacky commented Aug 30, 2025

LGTM 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants