Transfer v0.5.1 fixes to upstream #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove dangling pointers in the subscription struct * Remove leftover log
* Add e2e test to make sure transaction have set from field * Recover tx from field before writing block into storage * Recover tx from field if it's not set in JSON-RPC * Fix lint error * Fix lint error * Fix lint error * Move recovering from address to blockchain * Removed unused code * Fix missing tests * Fix typo
* Disable seal configuration but keep CLI flag for sealing in order to remove it in the next minor release * Add unadopted count in account queue in order to clean up inactive transactions in non-validator's TxPool * Fix lint error * Fix lint error * Fix lint error * Make Sealing() unexported in TxPool * Rename unadopted to skips in AccountQueue of TxPool * Add resetSkips and incrementSkips in AccountQueue * Fix updateUnadoptedCounts and rename to updateAccountSkipsCounts * Fixed updateAccountSkipsCounts * Fix lint error * Fix lint error occured after merging base branch * Rename local var in updateAccountSkipsCounts
* add test * Prune lower transactions on promoting * Fix pruning in Promote * Fix failed test Co-authored-by: kourin <kourin.code@gmail.com>
0xAleksaOpacic
requested review from
zivkovicmilos,
lazartravica,
Kourin1996,
dbrajovic and
ferranbt
as code owners
zivkovicmilos
changed the title
0xAleksaOpacic
force-pushed
the
release/0.5.1
branch
from
8e349ea
to
ff0d3d3
Compare
0xAleksaOpacic
force-pushed
the
release/0.5.1
branch
from
cd04e9f
to
ff0d3d3
Compare
Codecov Report
@@ Coverage Diff @@
## develop #760 +/- ##
===========================================
+ Coverage 52.46% 52.77% +0.31%
===========================================
Files 130 130
Lines 17069 17144 +75
===========================================
+ Hits 8955 9048 +93
+ Misses 7469 7451 -18
Partials 645 645
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We had to release 0.5.1 version without all functionalities added into the develop after 0.5. For this we've checked out separate branch release/0.5.1 1 commit before BLS efforts and added 4 fixes. No we need to merge these fixes into the develop
Changes include
Checklist
Testing