Cache FFT roots #261
Merged
Cache FFT roots #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbgl
commented
Sep 22, 2021
src/field/fft.rs
Outdated
| @@ -42,6 +42,13 @@ fn fft_classic_root_table<F: Field>(n: usize) -> FftRootTable<F> { | |||
| root_table | |||
| } | |||
|
|
|||
| pub fn fft_default_strategy_root_table<F: Field>(n: usize) -> FftRootTable<F> { | |||
There was a problem hiding this comment.
We can get rid of this once we merge #258.
dlubarov
reviewed
Sep 22, 2021
| ) -> Vec<F> { | ||
| let n = input.len(); | ||
| let computed_root_table = if let Some(_) = root_table { |
There was a problem hiding this comment.
Argh that's annoying that we can't use unwrap_or_else (in a reasonable way). I don't see a better way though.
nbgl
force-pushed
the
jakub/cache-fft-roots
branch
from
9affce4
to
062bb2e
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unfortunately results in the root table being passed around a bit as part of
ProverOnlyCircuitData, but it does speed up PolynomialBatchCommitment::lde_values by 10%