Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add initial TravisCI config file #9

Merged
merged 6 commits into from Nov 3, 2018

Conversation

Projects
None yet
2 participants
@SeanPrashad
Copy link
Contributor

SeanPrashad commented Nov 1, 2018

Fixes #3: Integrate TravisCI for fast feedback cycles

This initial Travis configuration supports stable, beta, and nightly versions of Rust with failures allowed for nightly.

In addition, it also supports caching Cargo dependencies, as well as linting and tests.

feat: Add initial TravisCI config file
This initial configuration supports stable, beta, and nightly versions
of Rust with failures allowed for nightly.

In addition, it also supports caching Cargo dependencies, as well
as linting and tests.

Fixes #3
@SeanPrashad

This comment has been minimized.

Copy link
Contributor Author

SeanPrashad commented Nov 1, 2018

@0xazure The builds won't pass as the current configuration fails if there are errors reported by Clippy.

Should we pursue this route, or wait for #5 to land?

@0xazure
Copy link
Owner

0xazure left a comment

@SeanPrashad thanks for taking the time to configure Travis!

I'm fine with incorporating this change before a fix for #5 lands, it's not the end of the world if a few Travis builds fail. Ideally #5 will get fixed soon and it won't be an issue.

It would be really great if we could include Windows as an operating system target for TravisCI builds too in addition to linux. I feel pretty confident that if it works on linux it works on macOS so I don't think we need all 3, but making sure we support Windows would be a really great addition.

I took a look at the output produced by Travis for the build and saw that it still tried to run cargo test even after the clippy lints had failed. Is this desired behaviour? On one hand, the builds will take longer to run if clippy fails and it continues on to the tests. On the other, Travis would report more failures at once which might be more useful to contributors.

I also made a few inline comments; in particular we need to discuss caching on Travis and how it might impact build times.

Thanks again, really looking forward to getting this merged 👍

Show resolved Hide resolved .travis.yml
Show resolved Hide resolved README.rst Outdated
Show resolved Hide resolved .travis.yml Outdated

SeanPrashad added some commits Nov 2, 2018

Update Travis's caching criteria
As caching target and ~/.cargo/registry accumulates a lot of dead
weight, removing these will speed up the build significantly.

Reference: https://levans.fr/rust_travis_cache.html
Show resolved Hide resolved README.rst
@0xazure

0xazure approved these changes Nov 3, 2018

@0xazure 0xazure merged commit 3a6b61f into 0xazure:master Nov 3, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@SeanPrashad SeanPrashad deleted the SeanPrashad:issue-3 branch Nov 3, 2018

@0xazure

This comment has been minimized.

Copy link
Owner

0xazure commented Nov 3, 2018

Thanks very much @SeanPrashad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.