new fonts #1566
Merged
new fonts #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronyeh
reviewed
May 7, 2023
ronyeh
reviewed
May 7, 2023
ronyeh
reviewed
May 7, 2023
ronyeh
reviewed
May 7, 2023
|
@ronyeh looking at the link to the sources from musescore that you provided, I decided to include the fonts from finale, they are also OFL. I am looking forward to testing them with the alpha of VexFlow5 |
ronyeh
reviewed
May 7, 2023
| Copyright © 2021 MakeMusic, Inc. (https://www.makemusic.com/), with Reserved Font Name “Jazz”. | ||
| Copyright © 2021 MakeMusic, Inc. (https://www.makemusic.com/), with Reserved Font Name “Ash”. | ||
| Copyright © 2021 MakeMusic, Inc. (https://www.makemusic.com/), with Reserved Font Name “Legacy”. | ||
|
|
There was a problem hiding this comment.
I'm going to merge this PR, but we should consider naming all license files LICENSE.txt, and ideally we should include references to the original source license. For example, for finale fonts we should include this URL:
There was a problem hiding this comment.
@ronyeh I made the reference to the link in the README file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1565
@ronyeh the new fonts for vexflow-fonts are under tools/fonts/@