Allow for displaying only traditional music notation, without tablature #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the user to render only notation, not tablature and notation.
|
Ignore that last comment (I missed the second commit). Thanks for the change. Overall it looks good. Do you mind adding a test that validates the parse error? |
|
Gladly! How do I run the test infrastructure? I'd have written one but didn't know how to use the tests you've build, and bringing up the one HTML file in the tests/ directory didn't seem to do anything. I also notice that some simply notations don't render, even with the stock tabdiv-free. I'll open a issue with test cases. |
|
I noticed that the tests in vextab/ were broken. I just fixed them - so you should be able to open vextab/runtest.html and see all tests pass (after pulling in the most recent changes.) |
Adding unit tests for the new notation-only mode: 1) render with both tablature and notation 2) render with just notation 3) test that we get a parseError when both tablature and notation are false
|
I've added tests - take a look. |
|
Looks good. Thanks for the change. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow the user to display only traditional music notation by adding a "tablature=false" option to the tabstave tag. This is implemented by adding a new state that works with has_notation, has_tablature, and wrapping a few key pieces of code in vextab, tabdiv & the vexflow formatter in a conditional which checks has_tablature.