Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split authorizeOperator in two methods #6

Closed
jbaylina opened this issue Jan 5, 2018 · 4 comments
Closed

Split authorizeOperator in two methods #6

jbaylina opened this issue Jan 5, 2018 · 4 comments

Comments

@jbaylina
Copy link
Collaborator

jbaylina commented Jan 5, 2018

No description provided.

@0xjac
Copy link
Owner

0xjac commented Jan 5, 2018

Should we also split the events into AuthorizedOperator and RevokedOperator?

@0xjac 0xjac mentioned this issue Jan 5, 2018
Closed
@jbaylina
Copy link
Collaborator Author

jbaylina commented Jan 5, 2018

Yes, check with tom for the english, but I would say them OperatorAuthorizadand OperatorRevoked

@0xjac
Copy link
Owner

0xjac commented Jan 5, 2018 •
edited
Loading

I don't know which is best...

  • OperatorAuthorized/OperatorRevoked seems more "proper English"
  • AuthorizedOperator/RevokedOperator makes it easier to know if an operator is authorized/revoked without having to read the word operator every time first.

@tshabs what do you think

@tshabs
Copy link
Collaborator

tshabs commented Jan 5, 2018

I agree the first is proper english, but looking at #14 we might change this word anyway, will come back to you guys this evening on this

@0xjac 0xjac closed this as completed in 80ac0f1 Jan 5, 2018
0xjac pushed a commit that referenced this issue Jan 5, 2018
Split authorizeOperator
590f349 
- split authorizeOperator into authorizeOperator and revokeOperator
- refactor AuthorizeOperator event into AuthorizedOperator and
  RevokedOperator
- closes #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tshabs @0xjac @jbaylina