-
Notifications
You must be signed in to change notification settings - Fork 63
Networks update #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Networks update #840
Conversation
Going through the review i made note of a couple things that might require further discussion.
There may be properties within their In some cases we will need to work with viem chain types, for instance when dealing with a wagmi connector and convert them to our own network type. Do we want to make our Network type compatible? or semi compatible? I think it might be good practice to at least follow some of their naming conventions even if we arent compatible.
|
I'm on board with updating chain id to number. Bigint has other issues like it requires non standard de/serialization and can't be used as a map key. Can go in another PR |
chain_id
is bigintrpc
addedNetworkType.LOCAL
addedtestnet
field removed (using type instead)Note: Keeps deprecated chains and ids as these were available in devops. Should we remove these?