Skip to content

fix: 🐛 Raise an exception in InjectedFunction.on_setup if already up #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2024
Merged

fix: 🐛 Raise an exception in InjectedFunction.on_setup if already up #167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions injection/_core/module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,6 @@ class Arguments(NamedTuple):
class InjectedFunction[**P, T](EventListener):
__slots__ = (
"__dict__",
"__signature__",
"__wrapped__",
"__dependencies",
"__owner",
Expand All @@ -778,8 +777,8 @@ class InjectedFunction[**P, T](EventListener):
__setup_queue: Queue[Callable[..., Any]] | None

def __init__(self, wrapped: Callable[P, T], /) -> None:
self.__update_vars_from(wrapped)
update_wrapper(self, wrapped, updated=())
self.__update_vars_from(wrapped)
self.__dependencies = Dependencies.empty()
self.__owner = None
self.__setup_queue = Queue()
Expand Down Expand Up @@ -863,9 +862,10 @@ def on_setup[**_P, _T](self, wrapped: Callable[_P, _T] | None = None, /): # typ
def decorator(wp): # type: ignore[no-untyped-def]
queue = self.__setup_queue

if queue is not None:
queue.put_nowait(wp)
if queue is None:
raise RuntimeError(f"`{self}` is already up.")

queue.put_nowait(wp)
return wp

return decorator(wrapped) if wrapped else decorator
Expand Down Expand Up @@ -906,9 +906,6 @@ def __setup(self) -> None:
queue.join()
self.__close_setup_queue()

def __set_signature(self) -> None:
self.__signature__ = inspect.signature(self.wrapped, eval_str=True)

def __update_vars_from(self, obj: Any) -> None:
try:
variables = vars(obj)
Expand All @@ -918,7 +915,7 @@ def __update_vars_from(self, obj: Any) -> None:
self.__update_vars(variables)

def __update_vars(self, variables: Mapping[str, Any]) -> None:
restricted_vars = frozenset(
restricted_vars = frozenset(("__signature__", "__wrapped__")) | frozenset(
var for var in dir(self) if not self.__is_dunder(var)
)
vars(self).update(
Expand Down