Skip to content

Conversation

remimd
Copy link
Contributor

@remimd remimd commented Sep 24, 2025

No description provided.

@remimd remimd requested a review from Copilot September 24, 2025 09:35
@remimd remimd self-assigned this Sep 24, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new environment variable PYTHON_INJECTION_THREADSAFE that allows users to enable thread safety globally for the dependency injection library. The change modifies the default behavior from non-threadsafe to configurable thread safety.

Key changes:

  • Added environment variable support to control global thread safety settings
  • Updated the get_lock function to check the environment variable when threadsafe parameter is None
  • Updated documentation to explain the new threadsafe configuration option

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
injection/_core/common/threading.py Adds environment variable parsing and updates lock logic to use global threadsafe setting
README.md Updates documentation to explain the new environment variable and threadsafe behavior

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@remimd remimd merged commit 853f5a0 into dev Sep 24, 2025
5 checks passed
@remimd remimd deleted the threadsafe branch September 24, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant