[ORGA] Afficher le décompte des places dans le header de l'application (PIX-12246) #8803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants : Les variables d'environnement seront accessibles via les liens suivants : |
machestla
force-pushed
the
pix-12246-display-places-counter-in-app-header
branch
3 times, most recently
from
96da03c
to
713e465
Compare
machestla
commented
May 2, 2024
machestla
commented
May 2, 2024
machestla
force-pushed
the
pix-12246-display-places-counter-in-app-header
branch
5 times, most recently
from
c29168c
to
366d933
Compare
machestla
added
👀 Tech Review Needed
👀 Func Review Needed
and removed
Development in progress
labels
machestla
force-pushed
the
pix-12246-display-places-counter-in-app-header
branch
2 times, most recently
from
7097c5e
to
5478fdc
Compare
|
En cas de dépassement, on avait mis le "0 place disponible" en rouge sur la maquette là ça n'est pas le cas : Sinon tout est ok ! |
|
Bien ok l'affichage du nb de places dispos quand l'orga a des crédits 👍 |
machestla
force-pushed
the
pix-12246-display-places-counter-in-app-header
branch
from
5478fdc
to
1ac70a2
Compare
|
Func ok, le rouge est bien là ! |
xav-car
added
Func Review OK
xav-car
reviewed
May 3, 2024
orga/app/components/layout/organization-places-or-credit-info.gjs
Outdated
Show resolved
Hide resolved
xav-car
reviewed
May 3, 2024
orga/app/styles/components/layout/organization-places-or-credit-info.scss
Outdated
Show resolved
Hide resolved
xav-car
reviewed
May 3, 2024
xav-car
reviewed
May 3, 2024
| expect(response.statusCode).to.equal(200); | ||
| }); | ||
|
|
||
| it('should return HTTP code 403 if organization doesnt have the right feature activated', async function () { |
There was a problem hiding this comment.
suggestion : vérifier que le pre handler est appelé est suffisant normalement.
machestla
force-pushed
the
pix-12246-display-places-counter-in-app-header
branch
from
1ac70a2
to
04aa816
Compare
pix-service-auto-merge
force-pushed
the
pix-12246-display-places-counter-in-app-header
branch
from
04aa816
to
627c3d1
Compare
pix-service-auto-merge
deleted the
pix-12246-display-places-counter-in-app-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦄 Problème
Actuellement, le header affiche le nombre de crédits achetés par une orga. Cette information est statique et ne permet pas aux utilisateurs de savoir combien de places ils peuvent utiliser.
🤖 Proposition
Lorsque la fonctionnalité Places est activée, on souhaite :
pour les PixOrga membres et admins, afficher le compteur “Nombre de places disponibles” dans le header à la place du nb de crédits (appeler le model depuis le header)
pour les PixOrga membres et admins, si l’orga a 0 place disponible, on affiche le texte en rouge avec un picto warning (icône doit être non visible pour la navigation clavier)
pour les PixOrga admins, afficher un lien “voir le détail” qui renvoie vers la page Places.
🌈 Remarques
Cela signifie que si la fonctionnalité est activée, on ne voit plus les crédits. En revanche, si elle n’est pas activée, on ne change rien.
💯 Pour tester