Fix search terms clearing post type filter from forms. #3891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Fixes an issue where the default post type that is set from an
<input name="post_type">field in the search form would be cleared if a new search term was entered.Note that this is only true when the Post Type facet/filter is not in use. If the post type facet is enabled, it will be cleared as before. This is the expected behaviour for filters.
Closes #3868
How to test the Change
Changelog Entry
Fixed - An issue in Instant Results where a default post type filter that is set by a field in the search form would be cleared if a new search term was entered.
Credits
Props @JakePT @burhandodhy
Checklist: