Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump tested update version to 5.7 #126

Merged
merged 1 commit into from
Apr 21, 2021
Merged

Bump tested update version to 5.7 #126

merged 1 commit into from
Apr 21, 2021

Conversation

thrijith
Copy link
Member

@thrijith thrijith commented Apr 9, 2021

Description of the Change

  • Tested develop branch, WordPress version 5.7 on a single site installation
  • Checked autoshare behaviour by changing settings for default share
  • Verified newly added tweet status is working as expected
  • Checked PHP logs and browser console to make sure no warnings/errors originate from the plugin

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Applicable Issues

Fixes #110

Changelog Entry

@thrijith thrijith added this to the 1.0.5 milestone Apr 9, 2021
@thrijith thrijith requested a review from jeffpaul April 9, 2021 21:30
thrijith
thrijith commented Apr 9, 2021
View reviewed changes
readme.txt
@@ -16,8 +16,6 @@ Automatically tweets the post title or custom message and a link to the post.

**Disclaimer:** *TWITTER, TWEET, RETWEET and the Twitter logo are trademarks of Twitter, Inc. or its affiliates.*

**Note:** Post types are automatically set to autoshare. Future versions of this plugin could allow this to be set manually.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeffpaul since we have settings now, this can be removed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thrijith yes, seems that we can remove that (both README.md and readme.txt assuming it exists in both files).

@jeffpaul jeffpaul merged commit 428314d into develop Apr 21, 2021
@jeffpaul jeffpaul deleted the feature/5-7-compat branch April 21, 2021 02:33
@jeffpaul jeffpaul mentioned this pull request Apr 21, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffpaul jeffpaul Awaiting requested review from jeffpaul jeffpaul is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.5
Development

Successfully merging this pull request may close these issues.

Test against WordPress 5.7
2 participants
@thrijith @jeffpaul