Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/137: handle nonexistent option #138

Merged
merged 1 commit into from
Sep 24, 2021
Merged

fix/137: handle nonexistent option #138

merged 1 commit into from
Sep 24, 2021

Conversation

Sidsector9
Copy link
Member

Closes #137

Description of the Change

Added a check to see if option key exists.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

@jeffpaul jeffpaul added this to the 1.1.0 milestone Sep 21, 2021
dinhtungdu
dinhtungdu approved these changes Sep 24, 2021
View reviewed changes
Copy link
Contributor

@dinhtungdu dinhtungdu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sidsector9 Thanks so much for the PR. This is looking good to me!

@jeffpaul jeffpaul merged commit 6ad61fd into develop Sep 24, 2021
@jeffpaul jeffpaul deleted the fix/137 branch September 24, 2021 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinhtungdu dinhtungdu dinhtungdu approved these changes

Assignees

@Sidsector9 Sidsector9

Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Warning thrown on activating plugin for the first time
3 participants
@Sidsector9 @dinhtungdu @jeffpaul