Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added autoloader-suffix in composer config #166

Merged
merged 2 commits into from
May 31, 2022
Merged

Added autoloader-suffix in composer config #166

merged 2 commits into from
May 31, 2022

Conversation

iamdharmesh
Copy link
Member

Description of the Change

As described in #164, "Plugin asset/readme update" GH action is failing to deploy readme.txt because of autoload files of the composer. Composer generates new autoload files during composer install in GH action, which are different from the files commited in the svn repo of wp.org.

This PR adds autoloader-suffix in the composer config to generate the same autoload files with every install. So, the readme.txt file can deploy on minor changes or wp tested up to bumps.

Value of autoloader-suffix is in this format 10up{PLUGIN_NAME}{PLUGIN_VERSION} => 10upAutoshareForTwitterV111

Closes #164

Alternate Designs

We may use the IGNORE_OTHER_FILES option of GH action, but I feel autoloader-suffix is a better approach here, because with IGNORE_OTHER_FILES readme.txt file will be deployed with every change in it. (Think of readme update for plugin version bump merged in the trunk but we didn't added tag yet for release to deploy it on wp.org)

Possible Drawbacks

Not any

Verification Process

This can be verified with the successful deployment of readme.txt after the next release.

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests passed.

Changelog Entry

Fixed - "Plugin asset/readme update" GH action failure.

Credits

Props @iamdharmesh

@iamdharmesh iamdharmesh self-assigned this May 27, 2022
@iamdharmesh iamdharmesh requested review from a team and dkotter and removed request for a team May 27, 2022 10:05
@iamdharmesh iamdharmesh added this to the 1.2.0 milestone May 27, 2022
composer.json Show resolved Hide resolved
@iamdharmesh iamdharmesh requested a review from dkotter May 30, 2022 05:10
@iamdharmesh iamdharmesh merged commit 2be53b8 into develop May 31, 2022
@iamdharmesh iamdharmesh deleted the fix/164-2 branch May 31, 2022 14:36
@iamdharmesh iamdharmesh modified the milestones: 1.2.0, 1.1.2 Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

"Plugin asset/readme update" GH action is failing to deploy readme.txt
2 participants