Solidifying types

10up · May 20, 2024 · 93138c7 · 93138c7
1 parent ddbddd7
commit 93138c7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/components/icon-picker/icon-picker.tsx b/components/icon-picker/icon-picker.tsx
@@ -53,7 +53,7 @@ const StyledIconButton = styled(Icon)`
 	}
 `;
 
-export interface IconPickerProps {
+export type IconPickerProps = Omit<React.ComponentProps<typeof BaseControl>, 'children'> & {
 	/**
 	 * Value of the selected icon
 	 */
@@ -62,10 +62,6 @@ export interface IconPickerProps {
 	 * Change handler for when a new icon is selected
 	 */
 	onChange: (icon: { name: string; iconSet: string }) => void;
-	/**
-	 * Label of the icon picker
-	 */
-	label?: string;
 }
 
 export const IconPicker: React.FC<IconPickerProps> = (props) => {

diff --git a/example/src/blocks/icon-picker-example/edit.tsx b/example/src/blocks/icon-picker-example/edit.tsx
@@ -18,7 +18,10 @@ export function BlockEdit(props) {
     const { icon } = attributes;
     const blockProps = useBlockProps();
 
-    const handleIconSelection = value => setAttributes({icon: { name: value.name, iconSet: value.iconSet }});
+    const handleIconSelection = (value: {
+        name: string;
+        iconSet: string;
+    }) => setAttributes({icon: { name: value.name, iconSet: value.iconSet }});
 
     return (
         <>
@@ -44,4 +47,4 @@ export function BlockEdit(props) {
             </div>
         </>
     )
-}
+}