Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spread additional props passed to link component through to rich text component #190

Merged

Conversation

fabiankaegy
Copy link
Member

Description of the Change

This passes on any additional props given to the Link component through to the underlying RichText component. Therefore it allows to further modify the behavior of the RichText component.

How to test the Change

Try adding additional props like onSplit to the Link component.

Changelog Entry

Added - spread additional props passed to link component through to rich text component

Credits

Props @fabiankaegy

Checklist:

  • I agree to follow this project's Code of Conduct.
  • I have updated the documentation accordingly.
  • I have added tests to cover my change.
  • All new and existing tests pass.

Copy link
Member

@Antonio-Laguna Antonio-Laguna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fabiankaegy fabiankaegy merged commit 39625d9 into develop Jan 17, 2023
@fabiankaegy fabiankaegy deleted the feature/spread-additional-props-of-link-onto-rich-text branch January 17, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants