Remove code that adds Classic Editor links #29
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
As discussed in #22, the ideal for this plugin is to focus on converting content from the Classic Editor to the new Block Editor. While it's nice to provide a way for users to still edit content in the Classic Editor, it can be argued that is out of scope for this plugin and is better off handled by other plugins (like the official Classic Editor plugin). This also prevents conflicts with plugins like those.
This PR attempts to remove any code that adds Classic Editor links. This includes:
Alternate Designs
Instead of removing this functionality, there are two other options that were discussed:
The second approach there I think is the most intriguing but the overall out-of-scope argument still applies. If a user wants to still edit content in the Classic Editor, they are probably better off using the official Classic Editor plugin.
Benefits
We remove code that doesn't directly solve the problem this plugin is attempting to solve, namely converting content from the Classic Editor to the Block Editor. Also avoids any conflicts for users that will be running both this plugin and the official Classic Editor plugin.
Possible Drawbacks
We are removing functionality that has already been built, which always leaves a slightly bad taste in my mouth
Verification Process
Install the plugin with these changes and ensure any link that goes to the Classic Editor no longer exists. Then install the official Classic Editor plugin and ensure no duplicate Classic Editor links are shown but the Classic Editor links that are now in place still work.
Checklist:
Applicable Issues
#22